-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Set sha from VMRs main in the Source tag #12709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set sha from VMRs main in the Source tag #12709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the version details by changing the source repository SHA and BarId references for the dotnet/dotnet dependency. This appears to be a routine dependency update to point to a newer commit in the upstream repository.
- Updates the source SHA from
d499f9cdfd5b7b7bb291f95a3c14417d5edc969ftocdc420f453860b662a76fcc72672ed2a65243146 - Updates the BarId from
287756to288940
|
Should it come from vmr |
I'm not sure, I'm operating with the subscription information we have:
So technically, msbuild main could be getting backflows either from the |
|
Yeah, that makes sense--the most recent backflow in our repo could be from either of those sources. I guess I'm not sure what the change in this PR affects? |
Currently the service is not able to do a backflow, because the VMR commit it currently has is not an ancestor to the commit we're trying to backflow. |
|
@rainersigwald do you think we can merge this PR? |
|
Our main is currently blocked, but we can merge as soon as it's open. |
Currently msbuild link has a 10.0.1xx VMR build.
This is wrong as it should come from main.
This PR changes the Source tag to a main build, after which we'll need to do a forward flow, and only then a backflow