Evaluation missing from Design-Time build logs

[KirillOsenkov]

Evaluation is probably happening separately from design-time build, and as a result we are missing all evaluation events, and none of the files are embedded in the .binlog.

I'm filing this issue here to see if we can think of a workaround, perhaps somehow correlating the evaluation events with a design-time build that's based on a ProjectInstance.

This may be related to dotnet/msbuild#4926

[KirillOsenkov]

Corresponding binlog viewer issue: KirillOsenkov/MSBuildStructuredLog#250

[KirillOsenkov]

I found the related issue: #50

[panopticoncentral]

If I recall correctly, we actually do get some evaluation events for non-SDK projects because they are in the global project collection, and we can hook them there. SDK projects, though, don't use the global project collection and we need some sort of CPS API to hook into evaluations. That would also give us the imports as well. It's been a todo on my list that I've been wanting to get back to, so I'll try to make some time for that.

[KirillOsenkov]

@AArnott mentions:

The dataflow in CPS from evaluation to design-time builds is straightforward and I can certainly imaging plumbing something through to correlate the two. But they are distinctly separate operations, so I'm not sure how the "log" would be passed or concatenated to.

Keep in mind that the ProjectInstance can be mutated between evaluation and build. But for most purposes that can probably be ignored as it's rare (last I knew) and probably not done for things the user wants to know about.

[sharwell]

I just hit this one today in 1.0.1.2010501