{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":159564733,"defaultBranch":"main","name":"razor","ownerLogin":"dotnet","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-11-28T21:05:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/9141961?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726793492.0","currentOid":""},"activityList":{"items":[{"before":"6aa9aee9ab1384f3ca620115704526b932da38ef","after":null,"ref":"refs/heads/locfiles/80882852-7362-41f6-b9ac-ab84d0cd9dc6","pushedAt":"2024-09-20T00:51:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"6aa9aee9ab1384f3ca620115704526b932da38ef","ref":"refs/heads/locfiles/80882852-7362-41f6-b9ac-ab84d0cd9dc6","pushedAt":"2024-09-20T00:47:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Calculate SuppressAddComponentParameter in tooling (#10763)\n\nFixes #10736\r\n\r\nChris did a good breakdown of what this value is used for #10736 (comment)","shortMessageHtmlLink":"Calculate SuppressAddComponentParameter in tooling (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2474243325\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10763\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10763/hovercard\" href=\"https://github.com/dotnet/razor/pull/10763\">#10763</a>)"}},{"before":"3b870867b8752caac693f64dc053f59d0de823ac","after":"6aa9aee9ab1384f3ca620115704526b932da38ef","ref":"refs/heads/main","pushedAt":"2024-09-20T00:35:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ryzngard","name":"Andrew Hall","path":"/ryzngard","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/475144?s=80&v=4"},"commit":{"message":"Calculate SuppressAddComponentParameter in tooling (#10763)\n\nFixes #10736\r\n\r\nChris did a good breakdown of what this value is used for #10736 (comment)","shortMessageHtmlLink":"Calculate SuppressAddComponentParameter in tooling (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2474243325\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10763\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10763/hovercard\" href=\"https://github.com/dotnet/razor/pull/10763\">#10763</a>)"}},{"before":"3b870867b8752caac693f64dc053f59d0de823ac","after":null,"ref":"refs/heads/locfiles/dbea3b2a-0aa0-43c9-98b8-a711ddc39e64","pushedAt":"2024-09-19T22:33:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"3b870867b8752caac693f64dc053f59d0de823ac","ref":"refs/heads/locfiles/dbea3b2a-0aa0-43c9-98b8-a711ddc39e64","pushedAt":"2024-09-19T22:30:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Fix some `AssumeNotNull` assumptions (#10901)","shortMessageHtmlLink":"Fix some <code>AssumeNotNull</code> assumptions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2535120778\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10901\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10901/hovercard\" href=\"https://github.com/dotnet/razor/pull/10901\">#10901</a>)"}},{"before":"0f60d02da28acc2a7e11d2453cb300a34ca6f30b","after":"3b870867b8752caac693f64dc053f59d0de823ac","ref":"refs/heads/main","pushedAt":"2024-09-19T21:59:03.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"davidwengier","name":"David Wengier","path":"/davidwengier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/754264?s=80&v=4"},"commit":{"message":"Fix some `AssumeNotNull` assumptions (#10901)","shortMessageHtmlLink":"Fix some <code>AssumeNotNull</code> assumptions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2535120778\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10901\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10901/hovercard\" href=\"https://github.com/dotnet/razor/pull/10901\">#10901</a>)"}},{"before":null,"after":"5135b4c92b62b805af48b18fd0502c1188fa9a11","ref":"refs/heads/dev/alexgav/HardenCompletionTestMore","pushedAt":"2024-09-19T20:27:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"More hardening of the completion test\n\nWe not wait for a specific item in the actual shown completion UI, and also wait for the correct text in the editor post-commit to account for actions such as OnAutoInsert","shortMessageHtmlLink":"More hardening of the completion test"}},{"before":"c2bff15ca1c61c9859b88cf455944dd6f5a3ab1e","after":"0f60d02da28acc2a7e11d2453cb300a34ca6f30b","ref":"refs/heads/main","pushedAt":"2024-09-19T20:23:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"chsienki","name":"Chris Sienkiewicz","path":"/chsienki","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16246502?s=80&v=4"},"commit":{"message":"Extensions refactor (#10850)\n\n* Delete V2 page directive\n\n* Update inject tests to use real classification passes\n\n* Update model tests to use real classification passes\n\n* Delete duplicated model directives and passes\n\n* Delete duplicated inject extensions, directives and nodes\n\n* Delete duplicate inject target extension\n- Update the MVC3 version to optionally not enforce nullability to keep code gen identical\n\n* Remove duplicated taghelper extension methods and metadata\n\n* Remove duplicated diagnostic factories\n\n* Delete duplicated tag helper extensions and intermediate node types\n\n* Delete duplicated component types\n\n* Delete duplicated ViewComponentTypeVisitor\n\n* Delete duplicated viewcomponment taghelper passes","shortMessageHtmlLink":"Extensions refactor (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2511249380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10850\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10850/hovercard\" href=\"https://github.com/dotnet/razor/pull/10850\">#10850</a>)"}},{"before":null,"after":"1ce962439eaa47e7c73a275de6d0b6beea25da0c","ref":"refs/heads/dev/alexgav/HardenCompletionTest","pushedAt":"2024-09-19T20:10:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"Another attempt to harden completion test.\n\nNow we actually open completion UI and wait for the completion session have specified item as the selected item. Previously used test helper got completion session but didn't actually open completion UI or waited for anything specific to be present","shortMessageHtmlLink":"Another attempt to harden completion test."}},{"before":"c2bff15ca1c61c9859b88cf455944dd6f5a3ab1e","after":null,"ref":"refs/heads/locfiles/2d8368cd-dcd2-438c-a6a8-96c08820f0d6","pushedAt":"2024-09-19T07:35:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"c2bff15ca1c61c9859b88cf455944dd6f5a3ab1e","ref":"refs/heads/locfiles/2d8368cd-dcd2-438c-a6a8-96c08820f0d6","pushedAt":"2024-09-19T07:32:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Harden completion test (#10902)","shortMessageHtmlLink":"Harden completion test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2535362569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10902\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10902/hovercard\" href=\"https://github.com/dotnet/razor/pull/10902\">#10902</a>)"}},{"before":"93566fac2ff3768002911f9bd48b8f435e70e683","after":null,"ref":"refs/heads/dev/alexgav/HardenCompletionTest","pushedAt":"2024-09-19T07:11:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"}},{"before":"020f8e75429365596663f29153fc172ace67540b","after":"c2bff15ca1c61c9859b88cf455944dd6f5a3ab1e","ref":"refs/heads/main","pushedAt":"2024-09-19T07:11:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"Harden completion test (#10902)","shortMessageHtmlLink":"Harden completion test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2535362569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10902\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10902/hovercard\" href=\"https://github.com/dotnet/razor/pull/10902\">#10902</a>)"}},{"before":null,"after":"93566fac2ff3768002911f9bd48b8f435e70e683","ref":"refs/heads/dev/alexgav/HardenCompletionTest","pushedAt":"2024-09-19T05:58:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"Harden completion test","shortMessageHtmlLink":"Harden completion test"}},{"before":"020f8e75429365596663f29153fc172ace67540b","after":null,"ref":"refs/heads/locfiles/f7c28634-5f94-4f3b-8c2b-b68d88414e58","pushedAt":"2024-09-18T23:50:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"020f8e75429365596663f29153fc172ace67540b","ref":"refs/heads/locfiles/f7c28634-5f94-4f3b-8c2b-b68d88414e58","pushedAt":"2024-09-18T23:46:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Fix formatting integration tests (#10900)\n\nThese broke due to Razor comment formatting changes, so just updating\r\nthe expected output.","shortMessageHtmlLink":"Fix formatting integration tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534834055\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10900\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10900/hovercard\" href=\"https://github.com/dotnet/razor/pull/10900\">#10900</a>)"}},{"before":"53dae172452df834d9c60758571b756b0f49fb5f","after":"020f8e75429365596663f29153fc172ace67540b","ref":"refs/heads/main","pushedAt":"2024-09-18T23:24:20.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"davidwengier","name":"David Wengier","path":"/davidwengier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/754264?s=80&v=4"},"commit":{"message":"Fix formatting integration tests (#10900)\n\nThese broke due to Razor comment formatting changes, so just updating\r\nthe expected output.","shortMessageHtmlLink":"Fix formatting integration tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534834055\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10900\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10900/hovercard\" href=\"https://github.com/dotnet/razor/pull/10900\">#10900</a>)"}},{"before":"53dae172452df834d9c60758571b756b0f49fb5f","after":null,"ref":"refs/heads/locfiles/0c8a0e61-c0f3-445e-81c2-90b4654ad597","pushedAt":"2024-09-18T18:23:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"53dae172452df834d9c60758571b756b0f49fb5f","ref":"refs/heads/locfiles/0c8a0e61-c0f3-445e-81c2-90b4654ad597","pushedAt":"2024-09-18T18:19:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Fixing HTML attribute commit (#10897)\n\n* Fixing HTML attribute commit\r\n\r\n* PR feedback","shortMessageHtmlLink":"Fixing HTML attribute commit (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532255678\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10897\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10897/hovercard\" href=\"https://github.com/dotnet/razor/pull/10897\">#10897</a>)"}},{"before":"4a0552dba15b016ade30f68271d9dec211aaa413","after":null,"ref":"refs/heads/dev/alexgav/FixingHtmlAttributeCommit","pushedAt":"2024-09-18T17:58:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"}},{"before":"4b3e4096e8b7aa647340e9f1cc21720741c35f86","after":"53dae172452df834d9c60758571b756b0f49fb5f","ref":"refs/heads/main","pushedAt":"2024-09-18T17:57:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"Fixing HTML attribute commit (#10897)\n\n* Fixing HTML attribute commit\r\n\r\n* PR feedback","shortMessageHtmlLink":"Fixing HTML attribute commit (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532255678\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10897\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10897/hovercard\" href=\"https://github.com/dotnet/razor/pull/10897\">#10897</a>)"}},{"before":"4b3e4096e8b7aa647340e9f1cc21720741c35f86","after":null,"ref":"refs/heads/locfiles/38b6cf71-2bc9-454c-b54c-d44d2fd5d5af","pushedAt":"2024-09-18T04:36:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"4b3e4096e8b7aa647340e9f1cc21720741c35f86","ref":"refs/heads/locfiles/38b6cf71-2bc9-454c-b54c-d44d2fd5d5af","pushedAt":"2024-09-18T04:32:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Cohost diagnostics support (#10882)\n\nFixes https://github.com/dotnet/razor/issues/10696\r\nFixes https://github.com/dotnet/razor/issues/10769\r\nFixes https://github.com/dotnet/razor/issues/10874\r\nNeeds Roslyn change: https://github.com/dotnet/roslyn/pull/75102\r\n\r\nThe actual code change was quite straight foward. The test code was a\r\nbigger pain. Previously in cohosting tests we had two MEF composition,\r\none for Razor and one for Roslyn. Since Roslyn diagnostics can only run,\r\nor at least start, in devenv, we now need three MEF compositions -\r\nRoslyn devenv, Roslyn OOP and razor OOP - and two workspaces - Roslyn\r\ndevenv and Roslyn OOP - and our previous MEF infrastructure really\r\ndidn't handle this well, as evidenced by the fact that this PR also\r\nfixes https://github.com/dotnet/razor/issues/10874\r\n\r\nNow our MEF infra is simpler: We still cache catalogs etc. statically\r\nthe save time, but we create an `ExportProvider` as needed and expect\r\nconsumers to dispose of it like any other `IDisposable`, though there is\r\nalso here a test fixture to share the editor composition in the\r\nformatting tests so we don't pay a huge penalty in terms of test run\r\ntime.\r\n\r\nCommit-at-a-time if you want to read the story from beginning to end,\r\nbut it should be reasonably okay to just review as a whole too.","shortMessageHtmlLink":"Cohost diagnostics support (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2523833151\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10882\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10882/hovercard\" href=\"https://github.com/dotnet/razor/pull/10882\">#10882</a>)"}},{"before":"966d7628b98b89f8cdaa1fdf50003284866c8680","after":"4b3e4096e8b7aa647340e9f1cc21720741c35f86","ref":"refs/heads/main","pushedAt":"2024-09-18T04:11:37.000Z","pushType":"pr_merge","commitsCount":15,"pusher":{"login":"davidwengier","name":"David Wengier","path":"/davidwengier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/754264?s=80&v=4"},"commit":{"message":"Cohost diagnostics support (#10882)\n\nFixes https://github.com/dotnet/razor/issues/10696\r\nFixes https://github.com/dotnet/razor/issues/10769\r\nFixes https://github.com/dotnet/razor/issues/10874\r\nNeeds Roslyn change: https://github.com/dotnet/roslyn/pull/75102\r\n\r\nThe actual code change was quite straight foward. The test code was a\r\nbigger pain. Previously in cohosting tests we had two MEF composition,\r\none for Razor and one for Roslyn. Since Roslyn diagnostics can only run,\r\nor at least start, in devenv, we now need three MEF compositions -\r\nRoslyn devenv, Roslyn OOP and razor OOP - and two workspaces - Roslyn\r\ndevenv and Roslyn OOP - and our previous MEF infrastructure really\r\ndidn't handle this well, as evidenced by the fact that this PR also\r\nfixes https://github.com/dotnet/razor/issues/10874\r\n\r\nNow our MEF infra is simpler: We still cache catalogs etc. statically\r\nthe save time, but we create an `ExportProvider` as needed and expect\r\nconsumers to dispose of it like any other `IDisposable`, though there is\r\nalso here a test fixture to share the editor composition in the\r\nformatting tests so we don't pay a huge penalty in terms of test run\r\ntime.\r\n\r\nCommit-at-a-time if you want to read the story from beginning to end,\r\nbut it should be reasonably okay to just review as a whole too.","shortMessageHtmlLink":"Cohost diagnostics support (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2523833151\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10882\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10882/hovercard\" href=\"https://github.com/dotnet/razor/pull/10882\">#10882</a>)"}},{"before":"0612c2dba4b3f2f10b8a7ed0583b08583aade3cb","after":"4a0552dba15b016ade30f68271d9dec211aaa413","ref":"refs/heads/dev/alexgav/FixingHtmlAttributeCommit","pushedAt":"2024-09-18T00:41:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"PR feedback","shortMessageHtmlLink":"PR feedback"}},{"before":"966d7628b98b89f8cdaa1fdf50003284866c8680","after":null,"ref":"refs/heads/locfiles/498b6b53-c7d4-4888-bd70-18e1c017c5b3","pushedAt":"2024-09-17T22:42:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}},{"before":null,"after":"966d7628b98b89f8cdaa1fdf50003284866c8680","ref":"refs/heads/locfiles/498b6b53-c7d4-4888-bd70-18e1c017c5b3","pushedAt":"2024-09-17T22:38:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"},"commit":{"message":"Fix `FormattingContext` disposal (#10887)\n\nFrom a conversation on Teams. `FormattingContext` is disposable because\r\nit owns a workspace, but it also gets non-destructively mutated so it's\r\nunclear as to whether the disposal was working as intended, and unclear\r\nto consumers what needed to happen. Upon review of the code, this PR:\r\n\r\n* Moves workspace ownership to the caller of the formatting code, so its\r\ndisposal is clear\r\n* Makes `AdhocWorkspaceFactory` shared code, because it did the same\r\nthing in OOP and LSP server\r\n* Adds `IHostServicesProvider` to OOP, because thats the thing that was\r\nactually different between OOP and LSP server\r\n* Random cleanup of some related things","shortMessageHtmlLink":"Fix <code>FormattingContext</code> disposal (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2527737705\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10887\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10887/hovercard\" href=\"https://github.com/dotnet/razor/pull/10887\">#10887</a>)"}},{"before":"a06817077d09100211deea64dfa33227c25753c3","after":"966d7628b98b89f8cdaa1fdf50003284866c8680","ref":"refs/heads/main","pushedAt":"2024-09-17T22:04:20.000Z","pushType":"pr_merge","commitsCount":10,"pusher":{"login":"davidwengier","name":"David Wengier","path":"/davidwengier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/754264?s=80&v=4"},"commit":{"message":"Fix `FormattingContext` disposal (#10887)\n\nFrom a conversation on Teams. `FormattingContext` is disposable because\r\nit owns a workspace, but it also gets non-destructively mutated so it's\r\nunclear as to whether the disposal was working as intended, and unclear\r\nto consumers what needed to happen. Upon review of the code, this PR:\r\n\r\n* Moves workspace ownership to the caller of the formatting code, so its\r\ndisposal is clear\r\n* Makes `AdhocWorkspaceFactory` shared code, because it did the same\r\nthing in OOP and LSP server\r\n* Adds `IHostServicesProvider` to OOP, because thats the thing that was\r\nactually different between OOP and LSP server\r\n* Random cleanup of some related things","shortMessageHtmlLink":"Fix <code>FormattingContext</code> disposal (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2527737705\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/razor/issues/10887\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/razor/pull/10887/hovercard\" href=\"https://github.com/dotnet/razor/pull/10887\">#10887</a>)"}},{"before":null,"after":"0612c2dba4b3f2f10b8a7ed0583b08583aade3cb","ref":"refs/heads/dev/alexgav/FixingHtmlAttributeCommit","pushedAt":"2024-09-17T22:01:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexgav","name":"Alex Gavrilov","path":"/alexgav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1863656?s=80&v=4"},"commit":{"message":"Fixing HTML attribute commit","shortMessageHtmlLink":"Fixing HTML attribute commit"}},{"before":"a06817077d09100211deea64dfa33227c25753c3","after":null,"ref":"refs/heads/locfiles/1720f0dc-3d42-4692-bb44-703329dd1cd7","pushedAt":"2024-09-17T21:35:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dotnet-bot","name":"dotnet bot","path":"/dotnet-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9011267?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQwMDo1MTozMi4wMDAwMDBazwAAAAS7cOaU","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQwMDo1MTozMi4wMDAwMDBazwAAAAS7cOaU","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xN1QyMTozNTowNy4wMDAwMDBazwAAAAS5AoPB"}},"title":"Activity · dotnet/razor"}