Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cohost] With the source generator hooked up, C# rename doesn't work #10856

Open
davidwengier opened this issue Sep 9, 2024 · 0 comments
Open

[Cohost] With the source generator hooked up, C# rename doesn't work #10856

davidwengier opened this issue Sep 9, 2024 · 0 comments
Labels
Feature-Cohost
Milestone
17.12 Planning

Comments

@davidwengier
Copy link
Contributor

Roslyn's rename code blocks renames in source generated documents:
https://github.com/dotnet/roslyn/blob/bd5c00e5e09de8564093f42d87fe49d4971f2e84/src/Features/Core/Portable/Rename/SymbolicRenameInfo.cs#L224

We'll have to work around this some way. Maybe:

  • Plumb through a flag to override the behaviour (ie, bool allowRenamesInSourceGeneratedDocuments)
  • Override for Razor documents specifically
  • Produce edits in documents/additional documents if they're mapped via #line directives (and the content matches exactly)

Something to discuss.
davidwengier added a commit that referenced this issue Sep 10, 2024
@davidwengier
Fix, skip or update tooling tests
f929020 
Skipped folding range test tracked by #10859
Skipped rename test tracked by #10856
Updated semantic tokens test tracked by #10857
Update folding range tests tracked by #10860
Update spell checking test tracked by #10863
Skipped formatting tests tracked by #10864
Skipped auto insert tests tracked by #10865
@phil-allen-msft phil-allen-msft added this to the 17.12 Planning milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-Cohost
Projects
None yet
Milestone
17.12 Planning
Development

No branches or pull requests
2 participants
@davidwengier @phil-allen-msft