Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FUSE] Invalid @page directives don't get any code-gen #10863

Closed
davidwengier opened this issue Sep 10, 2024 · 0 comments · Fixed by #10907
Closed

[FUSE] Invalid @page directives don't get any code-gen #10863

davidwengier opened this issue Sep 10, 2024 · 0 comments · Fixed by #10907
Assignees
@chsienki
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Milestone
17.13 Planning

Comments

@davidwengier
Copy link
Contributor

When FUSE is on if you have a @page directive that doesn't start with a /, you get a diagnostic, but no code gen in the C# generated file happens. This might not be an issue, but might be jarring for users as they'll lose route attribute classification etc. Maybe thats a feature though 🤷‍♂️

Just noting it down as a difference
davidwengier added a commit that referenced this issue Sep 10, 2024
@davidwengier
Fix, skip or update tooling tests
f929020 
Skipped folding range test tracked by #10859
Skipped rename test tracked by #10856
Updated semantic tokens test tracked by #10857
Update folding range tests tracked by #10860
Update spell checking test tracked by #10863
Skipped formatting tests tracked by #10864
Skipped auto insert tests tracked by #10865
@phil-allen-msft phil-allen-msft added New Feature: Fuse area-compiler Umbrella for all compiler issues labels Sep 12, 2024
@chsienki chsienki self-assigned this Sep 17, 2024
@chsienki chsienki added this to the 17.13 Planning milestone Sep 17, 2024
@chsienki chsienki mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chsienki chsienki

Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Projects
None yet
Milestone
17.13 Planning
Development

Successfully merging a pull request may close this issue.

Fuse incorrect page directives chsienki/razor-tooling
3 participants
@davidwengier @chsienki @phil-allen-msft