Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohost LSP client initialization follow up #11133

Open
davidwengier opened this issue Oct 31, 2024 · 0 comments
Open

Cohost LSP client initialization follow up #11133

davidwengier opened this issue Oct 31, 2024 · 0 comments

Comments

@davidwengier
Copy link
Contributor

In #11129 we started sending client capabilities to OOP in cohosting, which is great, but we only do it once. To be correct we need to do a couple more steps:

  1. When the LSP server is shut down, we should "unitialize" OOP capabilities. ie, CanGetClientCapabilties should return false.
    • This would also be a good time to clear caches (eg, completion, inlay hints) and other things
  2. When the LSP server restarts again, we should ensure we re-initialize OOP.

Note that by "uninitialize" I don't mean shut down, and by "re-initialize" I mean only the LSP initialization options, not the regular ones.

Also, in case it's not known or clear, in VS the LSP server is shut down when a solution is closed, and restarted when a new one is opened, and a C# file opened in the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants