Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-approve now requires two approvers for insertion tool #997

Open
dmonroym opened this issue Jun 8, 2021 · 3 comments
Open

Auto-approve now requires two approvers for insertion tool #997

dmonroym opened this issue Jun 8, 2021 · 3 comments

Comments

@dmonroym
Copy link
Member

dmonroym commented Jun 8, 2021

#698 worked on approving and setting PRs for auto-complete but now these insertions need two approvers in order to continue being automatic

@dmonroym
Copy link
Member Author

@RikkiGibson this is something that might need to be discussed with @MSMattLic and the VS branch champions. We can keep adding bots that auto-approve these PRs but seems like a way to circumnavigate the issue.

Perhaps when it comes to insertions created by accounts like Project Collection Build Service (devdiv) and Visual Studio Languages Snap Account we can create an exception to go back to simply requiring one approval?

@RikkiGibson
Copy link
Contributor

Agree that the way forward on this would definitely be to get a conversation started with the people who own the configuration in the VS repo.

However, in practice, I haven't found it to be too inconvenient to review the new insertions each day and just approve the most recent successful one.

@MSMattLic
Copy link

I replied to both of you in email regarding the current policies. Please let me know if you have other thoughts or feedback. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants