Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move impl of ILspWorkpace to EditorTestWorkspace/LspTestWorkspace #76753

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 15, 2025

Removes dependency on LSP from workspace tests.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 15, 2025
@tmat tmat marked this pull request as ready for review January 15, 2025 22:22
@tmat tmat requested a review from a team as a code owner January 15, 2025 22:22
@tmat tmat changed the title Lsp workspace Move impl of ILspWorkpace to EditorTestWorkspace/LspTestWorkspace Jan 15, 2025
@tmat
Copy link
Member Author

tmat commented Jan 15, 2025

@dibarbet @jasonmalinowski ptal

@tmat tmat merged commit 6c0d300 into dotnet:main Jan 16, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 16, 2025
333fred added a commit to 333fred/roslyn that referenced this pull request Jan 16, 2025
* upstream/main: (172 commits)
  Move impl of ILspWorkpace to EditorTestWorkspace/LspTestWorkspace (dotnet#76753)
  Field-backed properties: report diagnostic for variable named field declared in accessor (dotnet#76671)
  Add more tests
  Update 'use nameof instead of typeof' to support generic types
  Update dependencies from https://github.com/dotnet/arcade build 20250115.2
  Add docs
  invert
  Update src/Analyzers/CSharp/Tests/CSharpAnalyzers.UnitTests.projitems
  Update options
  Fixup tests
  fixup options
  Update tests
  Add test
  Fix trivia
  Handle params
  Support modifiers with simple lambda parameters. (dotnet#75400)
  Handle params
  Use helper
  Add fixes
  Flesh out
  ...
@dibarbet dibarbet modified the milestones: Next, 17.14 P1 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants