Track the project name for a generator driver and report it via ETW #81036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
VSCode
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
chsienki
force-pushed
the
etwProjectName
branch
from
702be07 to
b01f7a8
Compare
chsienki
commented
Nov 4, 2025
| /// <param name="baseDirectory">Absolute path to the base directory used for file paths of generated files.</param> | ||
| /// <exception cref="ArgumentException"><paramref name="baseDirectory"/> is not an absolute path.</exception> | ||
| public GeneratorDriverOptions(IncrementalGeneratorOutputKind disabledOutputs = IncrementalGeneratorOutputKind.None, bool trackIncrementalGeneratorSteps = false, string? baseDirectory = null) | ||
| public GeneratorDriverOptions(IncrementalGeneratorOutputKind disabledOutputs = IncrementalGeneratorOutputKind.None, bool trackIncrementalGeneratorSteps = false, string? baseDirectory = null, string? projectName = null) |
Member
Author
There was a problem hiding this comment.
@333fred Do we need to go thru an API review meeting for this, or is it ok to just do it via mail?
jaredpar
reviewed
Nov 6, 2025
| additionalTexts, | ||
| generatedFilesBaseDirectory); | ||
| generatedFilesBaseDirectory, | ||
| $"{projectState.Name} ({projectState.Id})"); |
Member
There was a problem hiding this comment.
Should we also be passing a project name, or some name, when doing this on the command line?
Member
Author
There was a problem hiding this comment.
Yeah, that's a good idea.
Pass in assembly name as tracking name from the command line compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple projects building in parallel (such as in a VS solution) the current generator telemetry doesn't allow you to know from which project each invocation of the generator is coming from.
This adds an optional value to the generator options where a caller can add a project name. It populates that from the tooling to pass in the project name + id.