Fix typo: SequenceEquals -> SequenceEqual (#119937)

xtqqczze · web-flow · commit 1e89955954d1 · 2025-09-22T10:43:28.000-07:00
* `SequenceEquals` -&gt; `SequenceEqual`

* `CheckSequenceEquals` -&gt; `CheckSequenceEqual`

* `SequenceEqualsNullData_String` -&gt; `SequenceEqual_NullData_String`

* `SequenceEquals` -&gt; `SequenceEqual`
diff --git a/src/coreclr/tools/aot/ILCompiler.MetadataTransform/Internal/Metadata/NativeFormat/Writer/NativeMetadataWriter.cs b/src/coreclr/tools/aot/ILCompiler.MetadataTransform/Internal/Metadata/NativeFormat/Writer/NativeMetadataWriter.cs
@@ -982,7 +982,7 @@ public static string FlagsToString(this SignatureCallingConvention value)
         }
     }
 
-    // SequenceEquals on IEnumerable is painfully slow and allocates memory.
+    // SequenceEqual on IEnumerable is painfully slow and allocates memory.
     public static class SequenceExtensions
     {
         public static bool SequenceEqual<T>(this List<T> first, List<T> second)
diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/AggregateCatalogTest.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/AggregateCatalogTest.cs
@@ -543,7 +543,7 @@ public void OnChanging(object sender, ComposablePartCatalogChangeEventArgs args)
                 }
                 else
                 {
-                    EqualityExtensions.CheckSequenceEquals(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));
+                    EqualityExtensions.CheckSequenceEqual(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));
                 }
 
                 if (this._expectedRemoves == null)
@@ -552,7 +552,7 @@ public void OnChanging(object sender, ComposablePartCatalogChangeEventArgs args)
                 }
                 else
                 {
-                    EqualityExtensions.CheckSequenceEquals(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));
+                    EqualityExtensions.CheckSequenceEqual(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));
                 }
 
                 Assert.False(ContainsChanges(), "The catalog should NOT contain the changes yet");
@@ -570,7 +570,7 @@ public void OnChanged(object sender, ComposablePartCatalogChangeEventArgs args)
                 }
                 else
                 {
-                    EqualityExtensions.CheckSequenceEquals(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));
+                    EqualityExtensions.CheckSequenceEqual(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));
                 }
 
                 if (this._expectedRemoves == null)
@@ -579,7 +579,7 @@ public void OnChanged(object sender, ComposablePartCatalogChangeEventArgs args)
                 }
                 else
                 {
-                    EqualityExtensions.CheckSequenceEquals(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));
+                    EqualityExtensions.CheckSequenceEqual(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));
                 }
 
                 Assert.Null(args.AtomicComposition);
diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/AssemblyCatalogDebuggerProxyTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/AssemblyCatalogDebuggerProxyTests.cs
@@ -31,7 +31,7 @@ public void Constructor_ValueAsCatalogArgument_ShouldSetPartsProperty()
 
                 var proxy = new AssemblyCatalogDebuggerProxy(catalog);
 
-                EqualityExtensions.CheckSequenceEquals(catalog.Parts, proxy.Parts);
+                EqualityExtensions.CheckSequenceEqual(catalog.Parts, proxy.Parts);
             }
         }
 
diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/UnitTesting/EqualityExtensions.cs b/src/libraries/System.ComponentModel.Composition/tests/System/UnitTesting/EqualityExtensions.cs
@@ -91,13 +91,13 @@ public static bool CheckEquals(object objA, object objB)
 
             if (objA is IEnumerable objAEnumerable && objB is IEnumerable objBEnumerable)
             {
-                return CheckSequenceEquals(objAEnumerable, objBEnumerable);
+                return CheckSequenceEqual(objAEnumerable, objBEnumerable);
             }
 
             return objA.Equals(objB);
         }
 
-        public static bool CheckSequenceEquals(this IEnumerable @this, IEnumerable other)
+        public static bool CheckSequenceEqual(this IEnumerable @this, IEnumerable other)
         {
             if (@this == null || other == null)
                 return @this == other;
diff --git a/src/libraries/System.Memory/tests/ReadOnlySpan/SequenceEqual.T.cs b/src/libraries/System.Memory/tests/ReadOnlySpan/SequenceEqual.T.cs
@@ -157,8 +157,8 @@ public static void MakeSureNoSequenceEqualChecksGoOutOfRange()
         }
 
         [Theory]
-        [MemberData(nameof(TestHelpers.SequenceEqualsNullData), MemberType = typeof(TestHelpers))]
-        public static void SequenceEqualsNullData_String(string[] firstInput, string[] secondInput, bool expected)
+        [MemberData(nameof(TestHelpers.SequenceEqualNullData), MemberType = typeof(TestHelpers))]
+        public static void SequenceEqual_NullData_String(string[] firstInput, string[] secondInput, bool expected)
         {
             ReadOnlySpan<string> theStrings = firstInput;
 
diff --git a/src/libraries/System.Memory/tests/Span/SequenceEqual.T.cs b/src/libraries/System.Memory/tests/Span/SequenceEqual.T.cs
@@ -159,8 +159,8 @@ public static void MakeSureNoSequenceEqualChecksGoOutOfRange()
         }
 
         [Theory]
-        [MemberData(nameof(TestHelpers.SequenceEqualsNullData), MemberType = typeof(TestHelpers))]
-        public static void SequenceEqualsNullData_String(string[] firstInput, string[] secondInput, bool expected)
+        [MemberData(nameof(TestHelpers.SequenceEqualNullData), MemberType = typeof(TestHelpers))]
+        public static void SequenceEqual_NullData_String(string[] firstInput, string[] secondInput, bool expected)
         {
             Span<string> theStrings = firstInput;
 
@@ -176,7 +176,7 @@ public static void SequenceEqualsNullData_String(string[] firstInput, string[] s
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_OverriddenEqualsReturnsFalse_EqualsFalse(int length)
+        public static void SequenceEqual_OverriddenEqualsReturnsFalse_EqualsFalse(int length)
         {
             Span<StructOverridingEqualsToAlwaysReturnFalse> span1 = Enumerable.Range(0, length).Select(i => new StructOverridingEqualsToAlwaysReturnFalse()).ToArray();
             Assert.False(span1.SequenceEqual(span1.ToArray()));
@@ -198,7 +198,7 @@ private struct StructImplementingIEquatableToAlwaysReturnFalse : IEquatable<Stru
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_StructWithOddFieldSize_EqualsAsExpected(int length)
+        public static void SequenceEqual_StructWithOddFieldSize_EqualsAsExpected(int length)
         {
             Span<StructWithOddFieldSize> span1 = new StructWithOddFieldSize[length];
             Span<StructWithOddFieldSize> span2 = new StructWithOddFieldSize[length];
@@ -229,7 +229,7 @@ private struct StructWithOddFieldSize
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_StructWithOddFieldSizeAndIEquatable_EqualsAsExpected(int length)
+        public static void SequenceEqual_StructWithOddFieldSizeAndIEquatable_EqualsAsExpected(int length)
         {
             Span<StructWithOddFieldSizeAndIEquatable> span1 = new StructWithOddFieldSizeAndIEquatable[length];
             Span<StructWithOddFieldSizeAndIEquatable> span2 = new StructWithOddFieldSizeAndIEquatable[length];
@@ -274,7 +274,7 @@ public override int GetHashCode() =>
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_StructWithExplicitFieldSizeAndNoFields_EqualsAsExpected(int length)
+        public static void SequenceEqual_StructWithExplicitFieldSizeAndNoFields_EqualsAsExpected(int length)
         {
             Span<StructWithExplicitFieldSizeAndNoFields> span1 = new StructWithExplicitFieldSizeAndNoFields[length];
             Span<StructWithExplicitFieldSizeAndNoFields> span2 = new StructWithExplicitFieldSizeAndNoFields[length];
@@ -293,7 +293,7 @@ private struct StructWithExplicitFieldSizeAndNoFields
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_StructWithExplicitFieldSizeAndFields_EqualsAsExpected(int length)
+        public static void SequenceEqual_StructWithExplicitFieldSizeAndFields_EqualsAsExpected(int length)
         {
             Span<StructWithExplicitFieldSizeAndFields> span1 = new StructWithExplicitFieldSizeAndFields[length];
             Span<StructWithExplicitFieldSizeAndFields> span2 = new StructWithExplicitFieldSizeAndFields[length];
@@ -323,7 +323,7 @@ private struct StructWithExplicitFieldSizeAndFields
 
         [Theory]
         [InlineData(100)]
-        public static void SequenceEquals_StructWithDoubleField_EqualsAsExpected(int length)
+        public static void SequenceEqual_StructWithDoubleField_EqualsAsExpected(int length)
         {
             Span<StructWithDoubleField> span1 = new StructWithDoubleField[length];
             Span<StructWithDoubleField> span2 = new StructWithDoubleField[length];
diff --git a/src/libraries/System.Memory/tests/TestHelpers.cs b/src/libraries/System.Memory/tests/TestHelpers.cs
@@ -431,7 +431,7 @@ public static ReadOnlyMemory<T> DangerousCreateReadOnlyMemory<T>(object obj, int
             { new string[] { null, null, "9", null, "9", "9", null, "9"}, 3},
         };
 
-        public static TheoryData<string[], string[],  bool> SequenceEqualsNullData => new TheoryData<string[], string[], bool>()
+        public static TheoryData<string[], string[],  bool> SequenceEqualNullData => new TheoryData<string[], string[], bool>()
         {
             { new string[] { "1", null, "2" }, new string[] { "1", null, "2" } , true},
             { new string[] { "1", null, "2" }, new string[] { "1", "3", "2" } , false},
diff --git a/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Byte.cs b/src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Byte.cs
@@ -754,7 +754,7 @@ internal static unsafe int IndexOfNullByte(byte* searchSpace)
             return (int)(offset + 7);
         }
 
-        // Optimized byte-based SequenceEquals. The "length" parameter for this one is declared a nuint rather than int as we also use it for types other than byte
+        // Optimized byte-based SequenceEqual. The "length" parameter for this one is declared a nuint rather than int as we also use it for types other than byte
         // where the length can exceed 2Gb once scaled by sizeof(T).
         [Intrinsic] // Unrolled for constant length
         public static unsafe bool SequenceEqual(ref byte first, ref byte second, nuint length)
diff --git a/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/Legacy/EqualityExtensions.cs b/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/Legacy/EqualityExtensions.cs
diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/EqualityExtensions.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/EqualityExtensions.cs
diff --git a/src/libraries/System.Runtime/tests/System.Threading.Tasks.Tests/Task/TaskFromAsyncTest.cs b/src/libraries/System.Runtime/tests/System.Threading.Tasks.Tests/Task/TaskFromAsyncTest.cs

Original file line number	Diff line number	Diff line change
`@@ -982,7 +982,7 @@ public static string FlagsToString(this SignatureCallingConvention value)`
`982`	`982`	`}`
`983`	`983`	`}`
`984`	`984`
`985`		`- // SequenceEquals on IEnumerable is painfully slow and allocates memory.`
	`985`	`+ // SequenceEqual on IEnumerable is painfully slow and allocates memory.`
`986`	`986`	`public static class SequenceExtensions`
`987`	`987`	`{`
`988`	`988`	`public static bool SequenceEqual<T>(this List<T> first, List<T> second)`
Original file line number	Diff line number	Diff line change
`@@ -543,7 +543,7 @@ public void OnChanging(object sender, ComposablePartCatalogChangeEventArgs args)`
`543`	`543`	`}`
`544`	`544`	`else`
`545`	`545`	`{`
`546`		`- EqualityExtensions.CheckSequenceEquals(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));`
	`546`	`+ EqualityExtensions.CheckSequenceEqual(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`if (this._expectedRemoves == null)`
`@@ -552,7 +552,7 @@ public void OnChanging(object sender, ComposablePartCatalogChangeEventArgs args)`
`552`	`552`	`}`
`553`	`553`	`else`
`554`	`554`	`{`
`555`		`- EqualityExtensions.CheckSequenceEquals(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));`
	`555`	`+ EqualityExtensions.CheckSequenceEqual(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));`
`556`	`556`	`}`
`557`	`557`
`558`	`558`	`Assert.False(ContainsChanges(), "The catalog should NOT contain the changes yet");`
`@@ -570,7 +570,7 @@ public void OnChanged(object sender, ComposablePartCatalogChangeEventArgs args)`
`570`	`570`	`}`
`571`	`571`	`else`
`572`	`572`	`{`
`573`		`- EqualityExtensions.CheckSequenceEquals(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));`
	`573`	`+ EqualityExtensions.CheckSequenceEqual(this._expectedAdds, GetDisplayNames(args.AddedDefinitions));`
`574`	`574`	`}`
`575`	`575`
`576`	`576`	`if (this._expectedRemoves == null)`
`@@ -579,7 +579,7 @@ public void OnChanged(object sender, ComposablePartCatalogChangeEventArgs args)`
`579`	`579`	`}`
`580`	`580`	`else`
`581`	`581`	`{`
`582`		`- EqualityExtensions.CheckSequenceEquals(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));`
	`582`	`+ EqualityExtensions.CheckSequenceEqual(this._expectedRemoves, GetDisplayNames(args.RemovedDefinitions));`
`583`	`583`	`}`
`584`	`584`
`585`	`585`	`Assert.Null(args.AtomicComposition);`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public void Constructor_ValueAsCatalogArgument_ShouldSetPartsProperty()`
`31`	`31`
`32`	`32`	`var proxy = new AssemblyCatalogDebuggerProxy(catalog);`
`33`	`33`
`34`		`- EqualityExtensions.CheckSequenceEquals(catalog.Parts, proxy.Parts);`
	`34`	`+ EqualityExtensions.CheckSequenceEqual(catalog.Parts, proxy.Parts);`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -91,13 +91,13 @@ public static bool CheckEquals(object objA, object objB)`
`91`	`91`
`92`	`92`	`if (objA is IEnumerable objAEnumerable && objB is IEnumerable objBEnumerable)`
`93`	`93`	`{`
`94`		`- return CheckSequenceEquals(objAEnumerable, objBEnumerable);`
	`94`	`+ return CheckSequenceEqual(objAEnumerable, objBEnumerable);`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`return objA.Equals(objB);`
`98`	`98`	`}`
`99`	`99`
`100`		`- public static bool CheckSequenceEquals(this IEnumerable @this, IEnumerable other)`
	`100`	`+ public static bool CheckSequenceEqual(this IEnumerable @this, IEnumerable other)`
`101`	`101`	`{`
`102`	`102`	`if (@this == null \|\| other == null)`
`103`	`103`	`return @this == other;`
Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,8 @@ public static void MakeSureNoSequenceEqualChecksGoOutOfRange()`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`[Theory]`
`160`		`- [MemberData(nameof(TestHelpers.SequenceEqualsNullData), MemberType = typeof(TestHelpers))]`
`161`		`- public static void SequenceEqualsNullData_String(string[] firstInput, string[] secondInput, bool expected)`
	`160`	`+ [MemberData(nameof(TestHelpers.SequenceEqualNullData), MemberType = typeof(TestHelpers))]`
	`161`	`+ public static void SequenceEqual_NullData_String(string[] firstInput, string[] secondInput, bool expected)`
`162`	`162`	`{`
`163`	`163`	`ReadOnlySpan<string> theStrings = firstInput;`
`164`	`164`
Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ public static ReadOnlyMemory<T> DangerousCreateReadOnlyMemory<T>(object obj, int`
`431`	`431`	`{ new string[] { null, null, "9", null, "9", "9", null, "9"}, 3},`
`432`	`432`	`};`
`433`	`433`
`434`		`- public static TheoryData<string[], string[], bool> SequenceEqualsNullData => new TheoryData<string[], string[], bool>()`
	`434`	`+ public static TheoryData<string[], string[], bool> SequenceEqualNullData => new TheoryData<string[], string[], bool>()`
`435`	`435`	`{`
`436`	`436`	`{ new string[] { "1", null, "2" }, new string[] { "1", null, "2" } , true},`
`437`	`437`	`{ new string[] { "1", null, "2" }, new string[] { "1", "3", "2" } , false},`
Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,7 @@ internal static unsafe int IndexOfNullByte(byte* searchSpace)`
`754`	`754`	`return (int)(offset + 7);`
`755`	`755`	`}`
`756`	`756`
`757`		`- // Optimized byte-based SequenceEquals. The "length" parameter for this one is declared a nuint rather than int as we also use it for types other than byte`
	`757`	`+ // Optimized byte-based SequenceEqual. The "length" parameter for this one is declared a nuint rather than int as we also use it for types other than byte`
`758`	`758`	`// where the length can exceed 2Gb once scaled by sizeof(T).`
`759`	`759`	`[Intrinsic] // Unrolled for constant length`
`760`	`760`	`public static unsafe bool SequenceEqual(ref byte first, ref byte second, nuint length)`