Skip to content

Commit 8170c06

Browse files
authored
Stop building extra installer bundles during PGO build (#49779)
* Select only the runtime-internal package and turn off installers * Remove R2R modifications
1 parent 8ec3ae2 commit 8170c06

File tree

2 files changed

+25
-17
lines changed

2 files changed

+25
-17
lines changed

eng/Subsets.props

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -283,25 +283,31 @@
283283

284284
<!-- Packs sets -->
285285

286-
<ItemGroup Condition="$(_subset.Contains('+packs.product+'))">
287-
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Ref.sfxproj" />
288-
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj" />
289-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Host.sfxproj" />
290-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj" />
291-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-host.proj" />
292-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-hostfxr.proj" />
293-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-runtime-deps\*.proj" />
294-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\bundle\Microsoft.NETCore.App.Bundle.bundleproj" />
295-
<SharedFrameworkProjectToBuild Condition="'$(MonoCrossAOTTargetOS)' != ''" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\monocrossaot.sfxproj" />
296-
<ProjectToBuild Include="@(SharedFrameworkProjectToBuild)" Category="packs" />
297-
</ItemGroup>
298-
299-
<ItemGroup Condition="$(_subset.Contains('+packs.installers+'))">
286+
<Choose>
287+
<When Condition="$(_subset.Contains('+packs.product+'))">
288+
<ItemGroup Condition="'$(PgoInstrument)' != 'true'">
289+
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Ref.sfxproj" />
290+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Host.sfxproj" />
291+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj" />
292+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-host.proj" />
293+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-hostfxr.proj" />
294+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-runtime-deps\*.proj" />
295+
<SharedFrameworkProjectToBuild Condition="'$(MonoCrossAOTTargetOS)' != ''" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\monocrossaot.sfxproj" />
296+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\bundle\Microsoft.NETCore.App.Bundle.bundleproj" />
297+
</ItemGroup>
298+
<ItemGroup>
299+
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj" />
300+
<ProjectToBuild Include="@(SharedFrameworkProjectToBuild)" Category="packs" />
301+
</ItemGroup>
302+
</When>
303+
</Choose>
304+
305+
<ItemGroup Condition="$(_subset.Contains('+packs.installers+')) AND '$(PgoInstrument)' != 'true'">
300306
<InstallerProjectToBuild Include="$(InstallerProjectRoot)pkg\sfx\installers.proj" />
301307
<ProjectToBuild Include="@(InstallerProjectToBuild)" Category="packs" />
302308
</ItemGroup>
303309

304-
<ItemGroup Condition="$(_subset.Contains('+packs.tests+'))">
310+
<ItemGroup Condition="$(_subset.Contains('+packs.tests+')) AND '$(PgoInstrument)' != 'true'">
305311
<TestProjectToBuild Include="$(InstallerProjectRoot)tests\Microsoft.DotNet.CoreSetup.Packaging.Tests\Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj" />
306312
<ProjectToBuild Include="@(TestProjectToBuild)" BuildInParallel="true" Test="true" Category="packs" />
307313
</ItemGroup>

src/installer/pkg/sfx/Directory.Build.props

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
<PropertyGroup>
99
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
1010
<ProductBrandPrefix>Microsoft .NET</ProductBrandPrefix>
11-
<GenerateInstallers>true</GenerateInstallers>
12-
<GenerateVSInsertionPackages>true</GenerateVSInsertionPackages>
1311
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
1412
<UseRuntimePackageDisclaimer>true</UseRuntimePackageDisclaimer>
1513
</PropertyGroup>
14+
<PropertyGroup Condition="'$(PgoInstrument)' != 'true'">
15+
<GenerateInstallers>true</GenerateInstallers>
16+
<GenerateVSInsertionPackages>true</GenerateVSInsertionPackages>
17+
</PropertyGroup>
1618
</Project>

0 commit comments

Comments
 (0)