From a4a81abe3f6b0adf293401a4a6bc623279011071 Mon Sep 17 00:00:00 2001 From: Tarek Mahmoud Sayed Date: Wed, 5 Jun 2024 09:31:00 -0700 Subject: [PATCH] Change tags parameter in Activity.AddException to be `in` paramater. (#103009) --- .../ref/System.Diagnostics.DiagnosticSourceActivity.cs | 2 +- .../src/System/Diagnostics/Activity.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs b/src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs index a55884d21ada74..5fcfa8f27ae443 100644 --- a/src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs +++ b/src/libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSourceActivity.cs @@ -50,7 +50,7 @@ public string? Id public string? TraceStateString { get { throw null; } set { } } public System.Diagnostics.Activity AddBaggage(string key, string? value) { throw null; } public System.Diagnostics.Activity AddEvent(System.Diagnostics.ActivityEvent e) { throw null; } - public System.Diagnostics.Activity AddException(System.Exception exception, System.Diagnostics.TagList tags = default, System.DateTimeOffset timestamp = default) { throw null; } + public System.Diagnostics.Activity AddException(System.Exception exception, in System.Diagnostics.TagList tags = default, System.DateTimeOffset timestamp = default) { throw null; } public System.Diagnostics.Activity AddLink(System.Diagnostics.ActivityLink link) { throw null; } public System.Diagnostics.Activity AddTag(string key, string? value) { throw null; } public System.Diagnostics.Activity AddTag(string key, object? value) { throw null; } diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs b/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs index d581df203bb69c..baae3c2aa0e120 100644 --- a/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs +++ b/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs @@ -532,7 +532,7 @@ public Activity AddEvent(ActivityEvent e) /// - Any registered with the callback that adds "exception.message", "exception.stacktrace", or "exception.type" tags /// will not have these tags overwritten, except by any subsequent that explicitly overwrites them. /// - public Activity AddException(Exception exception, TagList tags = default, DateTimeOffset timestamp = default) + public Activity AddException(Exception exception, in TagList tags = default, DateTimeOffset timestamp = default) { if (exception == null) {