Skip to content

Commit a8c2d1e

Browse files
authored
Disable more SendPacketsElement tests on Win11 (#59359)
1 parent bfaa457 commit a8c2d1e

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,10 @@ public void SendPacketsElement_FileStreamMultiPart_Success()
527527
}
528528
}
529529

530-
[Fact]
530+
public static bool IsNotWindows11 = !PlatformDetection.IsWindows10Version22000OrGreater;
531+
532+
[ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
533+
[ConditionalFact(nameof(IsNotWindows11))]
531534
public void SendPacketsElement_FileStreamLargeOffset_Throws()
532535
{
533536
using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, useAsync: true))
@@ -550,7 +553,8 @@ public void SendPacketsElement_FileStreamLargeCount_Throws()
550553
}
551554
}
552555

553-
[Fact]
556+
[ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
557+
[ConditionalFact(nameof(IsNotWindows11))]
554558
public void SendPacketsElement_FileStreamWithOptions_Success() {
555559
using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, 4096, FileOptions.Asynchronous | FileOptions.SequentialScan)) {
556560
var element = new SendPacketsElement(stream, 0, s_testFileSize);
@@ -581,15 +585,9 @@ public void SendPacketsElement_FileStreamMultiPartMixed_Success() {
581585
}
582586
}
583587

584-
[ConditionalFact]
588+
[ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
589+
[ConditionalFact(nameof(IsNotWindows11))]
585590
public void SendPacketsElement_FileStreamMultiPartMixed_MultipleFileStreams_Success() {
586-
587-
if (PlatformDetection.IsWindows10Version22000OrGreater)
588-
{
589-
// [ActiveIssue("https://github.com/dotnet/runtime/issues/58898")]
590-
throw new SkipTestException("Unstable on Windows 11");
591-
}
592-
593591
using (var stream = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, FileOptions.Asynchronous))
594592
using (var stream2 = new FileStream(TestFileName, FileMode.Open, FileAccess.Read, FileShare.Read, 4096, FileOptions.Asynchronous)) {
595593
var elements = new[]

0 commit comments

Comments
 (0)