Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving target framework parsing to runtime #39885

Open
wli3 opened this issue Jul 24, 2020 · 3 comments
Open

Moving target framework parsing to runtime #39885

wli3 opened this issue Jul 24, 2020 · 3 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-HostModel Microsoft.NET.HostModel issues
Milestone
Future

Comments

@wli3
Copy link

wli3 commented Jul 24, 2020

Background and Motivation

During development of optional workload. We find many part of the system need to parse target framework. "net5.0-windows10.0.18362" means TargetFrameworkIdentifier = .NETCoreApp, TargetFrameworkVersion = 5.0, target platform identifier = windows, target platform version = 10.0.18362. Currently we have msbuild intrinsic already. And we are wondering if it should also be in the runtime.

The C# API is in NuGet.Frameworks today. However, due to DLL hell, we sometimes hesitated to depend on it

Proposed API

Files under https://github.com/NuGet/NuGet.Client/tree/1f1213960012d6452b63a267607d1e237318025e/src/NuGet.Core/NuGet.Frameworks
@wli3 wli3 added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Jul 24, 2020
@jeffschwMSFT jeffschwMSFT added area-System.Runtime untriaged New issue has not been triaged by the area owner labels Jul 24, 2020
@jkotas
Copy link
Member

jkotas commented Jul 24, 2020

Files under https://github.com/NuGet/NuGet.Client/tree/1f1213960012d6452b63a267607d1e237318025e/src/NuGet.Core/NuGet.Frameworks

That is a lot of code that seems to be doing lot more than just parsing target framework string. Is this proposal really about all of this code?

@wli3
Copy link
Author

wli3 commented Jul 25, 2020

Created this issue so we have something to point to. We would need a meeting later

@jkotas jkotas added the area-HostModel Microsoft.NET.HostModel issues label Jul 25, 2020
@ghost
Copy link

ghost commented Jul 25, 2020

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar, @agocke
See info in area-owners.md if you want to be subscribed.

@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Sep 14, 2020
@agocke agocke added this to the Future milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@agocke @jkotas @wli3 @jeffschwMSFT