Skip to content

Commit 2cc7a92

Browse files
author
Jason Zhai
committed
Merge branch 'release/9.0.1xx' of https://github.com/dotnet/sdk into darc-release/9.0.1xx-22b7913c-0028-4167-b1a4-86cdac5fa544
2 parents 5c7eb8f + 9bdfba1 commit 2cc7a92

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

build/RunTestsOnHelix.cmd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ set DOTNET_ROOT=%HELIX_CORRELATION_PAYLOAD%\d
99
set PATH=%DOTNET_ROOT%;%PATH%
1010
set DOTNET_MULTILEVEL_LOOKUP=0
1111
set TestFullMSBuild=%1
12+
set BuildWithNetFrameworkHostedCompiler=false
1213

1314
set TestExecutionDirectory=%CD%\testExecutionDirectory
1415
mkdir %TestExecutionDirectory%
@@ -48,4 +49,4 @@ dotnet nuget remove source dotnet-libraries-transport --configfile %TestExecutio
4849
dotnet nuget remove source dotnet-tools-transport --configfile %TestExecutionDirectory%\nuget.config
4950
dotnet nuget remove source dotnet-libraries --configfile %TestExecutionDirectory%\nuget.config
5051
dotnet nuget remove source dotnet-eng --configfile %TestExecutionDirectory%\nuget.config
51-
dotnet nuget list source --configfile %TestExecutionDirectory%\nuget.config
52+
dotnet nuget list source --configfile %TestExecutionDirectory%\nuget.config

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"tools": {
3-
"dotnet": "9.0.100-preview.5.24307.3",
3+
"dotnet": "9.0.100-preview.7.24407.12",
44
"runtimes": {
55
"dotnet": [
66
"$(VSRedistCommonNetCoreSharedFrameworkx6490PackageVersion)"

test/Microsoft.NET.Build.Tests/GivenFrameworkReferences.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,7 @@ public void WindowsFormsFrameworkReference(bool selfContained)
887887
TestFrameworkReferenceProfiles(
888888
frameworkReferences: new[] { "Microsoft.WindowsDesktop.App.WindowsForms" },
889889
expectedReferenceNames: new[] { "Microsoft.Win32.Registry", "System.Windows.Forms" },
890-
notExpectedReferenceNames: new[] { "WindowsFormsIntegration" },
890+
notExpectedReferenceNames: Enumerable.Empty<string>(),
891891
selfContained);
892892
}
893893

@@ -899,7 +899,7 @@ public void WPFFrameworkReference(bool selfContained)
899899
TestFrameworkReferenceProfiles(
900900
frameworkReferences: new[] { "Microsoft.WindowsDesktop.App.WPF" },
901901
expectedReferenceNames: new[] { "Microsoft.Win32.Registry", "System.Windows.Presentation" },
902-
notExpectedReferenceNames: new[] { "WindowsFormsIntegration" },
902+
notExpectedReferenceNames: Enumerable.Empty<string>(),
903903
selfContained);
904904
}
905905

@@ -911,7 +911,7 @@ public void WindowsFormAndWPFFrameworkReference(bool selfContained)
911911
TestFrameworkReferenceProfiles(
912912
frameworkReferences: new[] { "Microsoft.WindowsDesktop.App.WindowsForms", "Microsoft.WindowsDesktop.App.WPF" },
913913
expectedReferenceNames: new[] { "Microsoft.Win32.Registry", "System.Windows.Forms", "System.Windows.Presentation" },
914-
notExpectedReferenceNames: new[] { "WindowsFormsIntegration" },
914+
notExpectedReferenceNames: Enumerable.Empty<string>(),
915915
selfContained);
916916
}
917917

test/Microsoft.NET.Restore.Tests/GivenThatWeWantToUseFrameworkRoslyn.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void It_downloads_Microsoft_Net_Compilers_Toolset_Framework_when_requeste
4444
.HaveStdOutContaining(Path.Combine(toolsetPackageDir, toolsetPackageVersion, "csc.exe") + " /noconfig");
4545
}
4646

47-
[FullMSBuildOnlyFact]
47+
[FullMSBuildOnlyFact(Skip = "Skip until we can figure out how to fix the test with the package off globally")]
4848
public void It_downloads_Microsoft_Net_Compilers_Toolset_Framework_when_MSBuild_is_torn()
4949
{
5050
const string testProjectName = "NetCoreApp";
@@ -66,6 +66,7 @@ public void It_downloads_Microsoft_Net_Compilers_Toolset_Framework_when_MSBuild_
6666

6767
testAsset.GetRestoreCommand(Log, relativePath: testProjectName)
6868
.WithEnvironmentVariable("NUGET_PACKAGES", customPackagesDir)
69+
.WithEnvironmentVariable("BuildWithNetFrameworkHostedCompiler", "")
6970
.Execute().Should().Pass();
7071

7172
var toolsetPackageDir = Path.Combine(customPackagesDir, "microsoft.net.sdk.compilers.toolset");
@@ -76,6 +77,7 @@ public void It_downloads_Microsoft_Net_Compilers_Toolset_Framework_when_MSBuild_
7677

7778
new BuildCommand(testAsset)
7879
.WithEnvironmentVariable("NUGET_PACKAGES", customPackagesDir)
80+
.WithEnvironmentVariable("BuildWithNetFrameworkHostedCompiler", "")
7981
.Execute().Should().Pass().And
8082
.HaveStdOutContaining(Path.Combine(toolsetPackageDir, toolsetPackageVersion, "csc.exe") + " /noconfig");
8183
}

0 commit comments

Comments
 (0)