Back to normal booleans on config models, pushing knowledge into the config providers

Author: baronfel

src/Microsoft.Extensions.Configuration.DotnetCli/Models/BuildConfiguration.cs

@@ -12,13 +12,13 @@ public sealed class BuildConfiguration
     /// Gets or sets whether to run MSBuild out of process.
     /// Mapped from DOTNET_CLI_RUN_MSBUILD_OUTOFPROC environment variable.
     /// </summary>
-    public FlexibleBool RunMSBuildOutOfProc { get; set; } = false;
+    public bool RunMSBuildOutOfProc { get; set; } = false;
 
     /// <summary>
     /// Gets or sets whether to use the MSBuild server for builds.
     /// Mapped from DOTNET_CLI_USE_MSBUILD_SERVER environment variable.
     /// </summary>
-    public FlexibleBool UseMSBuildServer { get; set; } = false;
+    public bool UseMSBuildServer { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the configuration for the MSBuild terminal logger.
@@ -30,11 +30,11 @@ public sealed class BuildConfiguration
     /// Gets or sets whether to disable publish and pack release configuration.
     /// Mapped from DOTNET_CLI_DISABLE_PUBLISH_AND_PACK_RELEASE environment variable.
     /// </summary>
-    public FlexibleBool DisablePublishAndPackRelease { get; set; } = false;
+    public bool DisablePublishAndPackRelease { get; set; } = false;
 
     /// <summary>
     /// Gets or sets whether to enable lazy publish and pack release for solutions.
     /// Mapped from DOTNET_CLI_LAZY_PUBLISH_AND_PACK_RELEASE_FOR_SOLUTIONS environment variable.
     /// </summary>
-    public FlexibleBool LazyPublishAndPackReleaseForSolutions { get; set; } = false;
+    public bool LazyPublishAndPackReleaseForSolutions { get; set; } = false;
 }

src/Microsoft.Extensions.Configuration.DotnetCli/Models/CliUserExperienceConfiguration.cs

@@ -14,19 +14,19 @@ public sealed class CliUserExperienceConfiguration
     /// Gets or sets whether telemetry collection is disabled.
     /// Mapped from DOTNET_CLI_TELEMETRY_OPTOUT environment variable.
     /// </summary>
-    public FlexibleBool TelemetryOptOut { get; set; } = CompileOptions.TelemetryOptOutDefault;
+    public bool TelemetryOptOut { get; set; } = CompileOptions.TelemetryOptOutDefault;
 
     /// <summary>
     /// Gets or sets whether to suppress the .NET logo on startup.
     /// Mapped from DOTNET_NOLOGO environment variable.
     /// </summary>
-    public FlexibleBool NoLogo { get; set; } = false;
+    public bool NoLogo { get; set; } = false;
 
     /// <summary>
     /// Gets or sets whether to force UTF-8 encoding for console output.
     /// Mapped from DOTNET_CLI_FORCE_UTF8_ENCODING environment variable.
     /// </summary>
-    public FlexibleBool ForceUtf8Encoding { get; set; } = false;
+    public bool ForceUtf8Encoding { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the UI language for the CLI.

src/Microsoft.Extensions.Configuration.DotnetCli/Models/DevelopmentConfiguration.cs

@@ -12,7 +12,7 @@ public sealed class DevelopmentConfiguration
     /// Gets or sets whether performance logging is enabled.
     /// Mapped from DOTNET_CLI_PERF_LOG environment variable.
     /// </summary>
-    public FlexibleBool PerfLogEnabled { get; set; } = false;
+    public bool PerfLogEnabled { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the number of performance log entries to collect.
@@ -30,11 +30,11 @@ public sealed class DevelopmentConfiguration
     /// Gets or sets whether to enable verbose context logging.
     /// Mapped from DOTNET_CLI_CONTEXT_VERBOSE environment variable.
     /// </summary>
-    public FlexibleBool ContextVerbose { get; set; } = false;
+    public bool ContextVerbose { get; set; } = false;
 
     /// <summary>
     /// Gets or sets whether to allow targeting pack caching.
     /// Mapped from DOTNETSDK_ALLOW_TARGETING_PACK_CACHING environment variable.
     /// </summary>
-    public FlexibleBool AllowTargetingPackCaching { get; set; } = false;
+    public bool AllowTargetingPackCaching { get; set; } = false;
 }

src/Microsoft.Extensions.Configuration.DotnetCli/Models/FirstTimeUseConfiguration.cs

@@ -12,17 +12,17 @@ public sealed class FirstTimeUseConfiguration
     /// Gets or sets whether to generate ASP.NET Core HTTPS development certificates.
     /// Mapped from DOTNET_GENERATE_ASPNET_CERTIFICATE environment variable.
     /// </summary>
-    public FlexibleBool GenerateAspNetCertificate { get; set; } = true;
+    public bool GenerateAspNetCertificate { get; set; } = true;
 
     /// <summary>
     /// Gets or sets whether to add global tools to the PATH.
     /// Mapped from DOTNET_ADD_GLOBAL_TOOLS_TO_PATH environment variable.
     /// </summary>
-    public FlexibleBool AddGlobalToolsToPath { get; set; } = true;
+    public bool AddGlobalToolsToPath { get; set; } = true;
 
     /// <summary>
     /// Gets or sets whether to skip the first-time experience setup.
     /// Mapped from DOTNET_SKIP_FIRST_TIME_EXPERIENCE environment variable.
     /// </summary>
-    public FlexibleBool SkipFirstTimeExperience { get; set; } = false;
+    public bool SkipFirstTimeExperience { get; set; } = false;
 }

src/Microsoft.Extensions.Configuration.DotnetCli/Models/FlexibleBool.cs

@@ -13,5 +13,5 @@ public sealed class NuGetConfiguration
     /// Mapped from DOTNET_NUGET_SIGNATURE_VERIFICATION environment variable.
     /// Defaults to true on Windows and Linux, false elsewhere.
     /// </summary>
-    public FlexibleBool SignatureVerificationEnabled { get; set; } = OperatingSystem.IsWindows() || OperatingSystem.IsLinux();
+    public bool SignatureVerificationEnabled { get; set; } = OperatingSystem.IsWindows() || OperatingSystem.IsLinux();
 }

src/Microsoft.Extensions.Configuration.DotnetCli/Models/NuGetConfiguration.cs

@@ -18,7 +18,7 @@ public sealed class RuntimeHostConfiguration
     /// Gets or sets whether to enable multilevel lookup for shared frameworks.
     /// Mapped from DOTNET_MULTILEVEL_LOOKUP environment variable.
     /// </summary>
-    public FlexibleBool MultilevelLookup { get; set; } = false;
+    public bool MultilevelLookup { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the roll-forward policy for framework version selection.

src/Microsoft.Extensions.Configuration.DotnetCli/Models/RuntimeHostConfiguration.cs

@@ -12,7 +12,7 @@ public sealed class SdkResolverConfiguration
     /// Gets or sets whether to enable SDK resolver logging.
     /// Mapped from DOTNET_MSBUILD_SDK_RESOLVER_ENABLE_LOG environment variable.
     /// </summary>
-    public FlexibleBool EnableLog { get; set; } = false;
+    public bool EnableLog { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the directory containing SDKs.

src/Microsoft.Extensions.Configuration.DotnetCli/Models/SdkResolverConfiguration.cs

@@ -12,5 +12,5 @@ public sealed class ToolConfiguration
     /// Gets or sets whether to allow tool manifests in the repository root.
     /// Mapped from DOTNET_TOOLS_ALLOW_MANIFEST_IN_ROOT environment variable.
     /// </summary>
-    public FlexibleBool AllowManifestInRoot { get; set; } = false;
+    public bool AllowManifestInRoot { get; set; } = false;
 }

src/Microsoft.Extensions.Configuration.DotnetCli/Models/ToolConfiguration.cs

@@ -12,7 +12,7 @@ public sealed class WorkloadConfiguration
     /// Gets or sets whether to disable workload update notifications.
     /// Mapped from DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_DISABLE environment variable.
     /// </summary>
-    public FlexibleBool UpdateNotifyDisable { get; set; } = false;
+    public bool UpdateNotifyDisable { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the interval in hours between workload update notifications.
@@ -24,13 +24,13 @@ public sealed class WorkloadConfiguration
     /// Gets or sets whether to disable workload pack groups.
     /// Mapped from DOTNET_CLI_WORKLOAD_DISABLE_PACK_GROUPS environment variable.
     /// </summary>
-    public FlexibleBool DisablePackGroups { get; set; } = false;
+    public bool DisablePackGroups { get; set; } = false;
 
     /// <summary>
     /// Gets or sets whether to skip workload integrity checks.
     /// Mapped from DOTNET_SKIP_WORKLOAD_INTEGRITY_CHECK environment variable.
     /// </summary>
-    public FlexibleBool SkipIntegrityCheck { get; set; } = false;
+    public bool SkipIntegrityCheck { get; set; } = false;
 
     /// <summary>
     /// Gets or sets the manifest root directories for workloads.
@@ -48,5 +48,5 @@ public sealed class WorkloadConfiguration
     /// Gets or sets whether to ignore default manifest roots.
     /// Mapped from DOTNETSDK_WORKLOAD_MANIFEST_IGNORE_DEFAULT_ROOTS environment variable.
     /// </summary>
-    public FlexibleBool ManifestIgnoreDefaultRoots { get; set; } = false;
+    public bool ManifestIgnoreDefaultRoots { get; set; } = false;
 }