dotnet package list command should restore first (#47873)

Author: Nigusu-Allehu

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -486,6 +486,13 @@ This is equivalent to deleting project.assets.json.</value>
   <data name="CmdOutputVersionDescription" xml:space="preserve">
     <value>Specifies the version of machine-readable output. Requires the '--format json' option.</value>
   </data>
+  <data name="Error_restore" xml:space="preserve">
+    <value>Restore failed. Run `dotnet restore` for more details on the issue.</value>
+    <comment>{Locked="dotnet restore"}</comment>
+  </data>
+  <data name="CmdNoRestoreDescription" xml:space="preserve">
+    <value>Do not restore before running the command.</value>
+  </data>
   <data name="CmdPackage" xml:space="preserve">
     <value>PACKAGE_NAME</value>
   </data>

src/Cli/dotnet/Commands/Hidden/List/Package/ListPackageCommandParser.cs

@@ -33,6 +33,7 @@ private static CliCommand ConstructCommand()
         command.Options.Add(PackageListCommandParser.InteractiveOption);
         command.Options.Add(PackageListCommandParser.FormatOption);
         command.Options.Add(PackageListCommandParser.OutputVersionOption);
+        command.Options.Add(PackageListCommandParser.NoRestore);
 
         command.SetAction((parseResult) => new PackageListCommand(parseResult).Execute());
 

src/Cli/dotnet/Commands/Package/List/PackageListCommand.cs

@@ -6,6 +6,8 @@
 using Microsoft.DotNet.Cli.Commands.NuGet;
 using Microsoft.DotNet.Cli.Extensions;
 using Microsoft.DotNet.Cli.Utils;
+using System.Globalization;
+using Microsoft.DotNet.Cli.Commands.MSBuild;
 
 namespace Microsoft.DotNet.Cli.Commands.Package.List;
 
@@ -25,7 +27,71 @@ private static string GetAbsolutePath(string currentDirectory, string relativePa
 
     public override int Execute()
     {
-        return NuGetCommand.Run(TransformArgs());
+        string projectFile = GetProjectOrSolution();
+        bool noRestore = _parseResult.HasOption(PackageListCommandParser.NoRestore);
+        int restoreExitCode = 0;
+
+        if (!noRestore)
+        {
+            ReportOutputFormat formatOption = _parseResult.GetValue((CliOption<ReportOutputFormat>)PackageListCommandParser.FormatOption);
+            bool interactive = _parseResult.GetValue((CliOption<bool>)PackageListCommandParser.InteractiveOption);
+            restoreExitCode = RunRestore(projectFile, formatOption, interactive);
+        }
+
+        return restoreExitCode == 0
+            ? NuGetCommand.Run(TransformArgs(projectFile))
+            : restoreExitCode;
+    }
+
+    private int RunRestore(string projectOrSolution, ReportOutputFormat formatOption, bool interactive)
+    {
+        List<string> args = ["-target:Restore", projectOrSolution];
+
+        if (formatOption == ReportOutputFormat.json)
+        {
+            args.Add("-noConsoleLogger");
+        }
+        else
+        {
+            args.Add("-consoleLoggerParameters:NoSummary");
+            args.Add("-verbosity:minimal");
+        }
+
+        args.Add($"-interactive:{interactive.ToString().ToLower()}");
+
+        MSBuildForwardingApp restoringCommand = new MSBuildForwardingApp(argsToForward: args);
+
+        int exitCode = 0;
+
+        try
+        {
+            exitCode = restoringCommand.Execute();
+        }
+        catch (Exception)
+        {
+            exitCode = 1;
+        }
+
+        if (exitCode != 0)
+        {
+            if (formatOption == ReportOutputFormat.json)
+            {
+                string jsonError = $$"""
+{
+   "version": 1,
+   "problems": [
+      {
+         "text": "{{String.Format(CultureInfo.CurrentCulture, CliCommandStrings.Error_restore)}}",
+         "level": "error"
+      }
+   ]
+}
+""";
+                Console.WriteLine(jsonError);
+            }
+        }
+
+        return exitCode;
     }
 
     internal static void EnforceOptionRules(ParseResult parseResult)
@@ -40,13 +106,13 @@ internal static void EnforceOptionRules(ParseResult parseResult)
         }
     }
 
-    private string[] TransformArgs()
+    private string[] TransformArgs(string projectOrSolution)
     {
         var args = new List<string>
         {
             "package",
             "list",
-            GetProjectOrSolution()
+            projectOrSolution
         };
 
         args.AddRange(_parseResult.OptionValuesToBeForwarded(PackageListCommandParser.GetCommand()));

src/Cli/dotnet/Commands/Package/List/PackageListCommandParser.cs

@@ -72,6 +72,12 @@ internal static class PackageListCommandParser
 
     public static readonly CliOption InteractiveOption = CommonOptions.InteractiveOption().ForwardIfEnabled("--interactive");
 
+    public static readonly CliOption NoRestore = new CliOption<bool>("--no-restore")
+    {
+        Description = CliCommandStrings.CmdNoRestoreDescription,
+        Arity = ArgumentArity.Zero
+    };
+
     public static readonly CliOption VerbosityOption = new ForwardedOption<VerbosityOptions>("--verbosity", "-v")
     {
         Description = CliStrings.VerbosityOptionDescription,
@@ -113,6 +119,7 @@ private static CliCommand ConstructCommand()
         command.Options.Add(InteractiveOption);
         command.Options.Add(FormatOption);
         command.Options.Add(OutputVersionOption);
+        command.Options.Add(NoRestore);
         command.Options.Add(PackageCommandParser.ProjectOption);
 
         command.SetAction((parseResult) => new PackageListCommand(parseResult).Execute());