Merge pull request #3723 from sfoslund/InferredTypeVariableName

Confirm DisableImplicitNamespaceImports solves inferred type variable name issue

Author: sfoslund

.vsts-ci.yml

@@ -83,29 +83,12 @@ stages:
               _PublishType: none
               _SignType: test
 
-    - template: /eng/build.yml
-      parameters:
-        agentOs: Ubuntu_14_04
-        pool:
-          name: Hosted Ubuntu 1604
-        strategy:
-          matrix:
-            Build_Debug:
-              _BuildConfig: Debug
-              _PublishType: none
-              _SignType: test
-            Build_Release:
-              _BuildConfig: Release
-              _PublishType: none
-              _SignType: test
-        variables:
-          _PREVIEW_VSTS_DOCKER_IMAGE: microsoft/dotnet-buildtools-prereqs:ubuntu-14.04-cross-0cd4667-20170319080304
-
     - template: /eng/build.yml
       parameters:
         agentOs: Ubuntu_16_04
         pool:
-          name: Hosted Ubuntu 1604
+          name: NetCorePublic-Pool
+          queue: BuildPool.Ubuntu.1604.Amd64.Open
         strategy:
           matrix:
             Build_Debug:
@@ -116,8 +99,6 @@ stages:
               _BuildConfig: Release
               _PublishType: none
               _SignType: test
-        variables:
-          _PREVIEW_VSTS_DOCKER_IMAGE: microsoft/dotnet-buildtools-prereqs:ubuntu-16.04-cross-e435274-20180628134544
 
     - template: /eng/build.yml
       parameters:
@@ -165,7 +146,8 @@ stages:
       parameters:
         agentOs: Linux_Perf_CI
         pool:
-          name: Hosted Ubuntu 1604
+          name: NetCorePublic-Pool
+          queue: BuildPool.Ubuntu.1604.Amd64.Open
         strategy:
           matrix:
             Build_Release:
@@ -184,4 +166,4 @@ stages:
 - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
   - template: /eng/common/templates/post-build/post-build.yml
     parameters:
-      enableSymbolValidation: false
+      enableSymbolValidation: false

src/Assets/TestProjects/InferredTypeVariableName/InferredTypeVaraibleName.vbproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <RootNamespace>InferredTypeVaraibleName</RootNamespace>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
+  </PropertyGroup>
+
+</Project>

src/Assets/TestProjects/InferredTypeVariableName/Program.vb

@@ -0,0 +1,14 @@
+Imports System
+
+Module Program
+    Sub Main(args As String())
+        Console.WriteLine("Hello World!")
+    End Sub
+
+    Sub Foo()
+        Dim dataObject As Object
+        For Each format In dataObject.GetFormats()
+
+        Next
+    End Sub
+End Module

src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantImplicitNamespaceImportsDisabled.cs

@@ -0,0 +1,41 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System.IO;
+using FluentAssertions;
+using Microsoft.NET.TestFramework;
+using Microsoft.NET.TestFramework.Assertions;
+using Microsoft.NET.TestFramework.Commands;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace Microsoft.NET.Build.Tests
+{
+    public class GivenThatWeWantImplicitNamespaceImportsDisabled : SdkTest
+    {
+        public GivenThatWeWantImplicitNamespaceImportsDisabled(ITestOutputHelper log) : base(log)
+        {
+        }
+
+        [Fact]
+        public void It_builds_with_implicit_namespace_imports_disabled()
+        {
+            var asset = _testAssetsManager
+                .CopyTestAsset("InferredTypeVariableName")
+                .WithSource();
+
+            var buildCommand = new BuildCommand(Log, Path.Combine(asset.TestRoot));
+
+            buildCommand
+                .Execute()
+                .Should()
+                .Fail()
+                .And.HaveStdOutContaining("BC30455");
+
+            buildCommand
+                .Execute("/p:DisableImplicitNamespaceImports=true")
+                .Should()
+                .Pass();
+        }
+    }
+}