use typed config in program.cs

Author: baronfel

src/Cli/dotnet/Program.cs

@@ -182,13 +182,14 @@ internal static int ProcessArgs(string[] args, TimeSpan startupTime)
                 var configurationService = DotNetConfigurationFactory.Create();
                 var environmentProvider = new ConfigurationBasedEnvironmentProvider(configurationService);
 
-                bool generateAspNetCertificate = environmentProvider.GetEnvironmentVariableAsBool(EnvironmentVariableNames.DOTNET_GENERATE_ASPNET_CERTIFICATE, defaultValue: true);
-                bool telemetryOptout = environmentProvider.GetEnvironmentVariableAsBool(EnvironmentVariableNames.TELEMETRY_OPTOUT, defaultValue: CompileOptions.TelemetryOptOutDefault);
-                bool addGlobalToolsToPath = environmentProvider.GetEnvironmentVariableAsBool(EnvironmentVariableNames.DOTNET_ADD_GLOBAL_TOOLS_TO_PATH, defaultValue: true);
-                bool nologo = environmentProvider.GetEnvironmentVariableAsBool(EnvironmentVariableNames.DOTNET_NOLOGO, defaultValue: false);
-                bool skipWorkloadIntegrityCheck = environmentProvider.GetEnvironmentVariableAsBool(EnvironmentVariableNames.DOTNET_SKIP_WORKLOAD_INTEGRITY_CHECK,
+                // Use typed configuration directly instead of environment variable calls
+                bool generateAspNetCertificate = configurationService.FirstTimeUse.GenerateAspNetCertificate;
+                bool telemetryOptout = configurationService.CliUserExperience.TelemetryOptOut;
+                bool addGlobalToolsToPath = configurationService.FirstTimeUse.AddGlobalToolsToPath;
+                bool nologo = configurationService.CliUserExperience.NoLogo;
+                bool skipWorkloadIntegrityCheck = configurationService.Workload.SkipIntegrityCheck || 
                     // Default the workload integrity check skip to true if the command is being ran in CI. Otherwise, false.
-                    defaultValue: new CIEnvironmentDetectorForTelemetry().IsCIEnvironment());
+                    new CIEnvironmentDetectorForTelemetry().IsCIEnvironment();
 
                 ReportDotnetHomeUsage(environmentProvider);
 

src/Microsoft.Extensions.Configuration.DotnetCli/Microsoft.Extensions.Configuration.DotnetCli.csproj

@@ -7,6 +7,10 @@
     <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
   </PropertyGroup>
 
+  <ItemGroup>
+    <Compile Include="$(RepoRoot)src\Common\CompileOptions.cs" LinkBase="Common" />
+  </ItemGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.Extensions.Configuration" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" />

src/Microsoft.Extensions.Configuration.DotnetCli/Models/CliUserExperienceConfiguration.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using Microsoft.DotNet.Cli;
+
 namespace Microsoft.Extensions.Configuration.DotnetCli.Models;
 
 /// <summary>
@@ -12,7 +14,7 @@ public sealed class CliUserExperienceConfiguration
     /// Gets or sets whether telemetry collection is disabled.
     /// Mapped from DOTNET_CLI_TELEMETRY_OPTOUT environment variable.
     /// </summary>
-    public bool TelemetryOptOut { get; set; } = false;
+    public bool TelemetryOptOut { get; set; } = CompileOptions.TelemetryOptOutDefault;
 
     /// <summary>
     /// Gets or sets whether to suppress the .NET logo on startup.

src/Microsoft.Extensions.Configuration.DotnetCli/Models/WorkloadConfiguration.cs

@@ -18,7 +18,7 @@ public sealed class WorkloadConfiguration
     /// Gets or sets the interval in hours between workload update notifications.
     /// Mapped from DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_INTERVAL_HOURS environment variable.
     /// </summary>
-    public int UpdateNotifyIntervalHours { get; set; } = 24;
+    public int UpdateNotifyIntervalHours { get; set; } = 24; // Default to check once per day
 
     /// <summary>
     /// Gets or sets whether to disable workload pack groups.