Use better name for package references to add

Author: dsplaisted

src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs

@@ -49,7 +49,7 @@ public class ResolveFrameworkReferences : TaskBase
         public ITaskItem[] PackagesToDownload { get; set; }
 
         [Output]
-        public ITaskItem[] PackagesToReference { get; set; }
+        public ITaskItem[] LegacyFrameworkPackages { get; set; }
 
         [Output]
         public ITaskItem[] RuntimeFrameworks { get; set; }
@@ -83,7 +83,7 @@ protected override void ExecuteCore()
             var frameworkReferenceMap = FrameworkReferences.ToDictionary(fr => fr.ItemSpec);
 
             List<ITaskItem> packagesToDownload = new List<ITaskItem>();
-            List<ITaskItem> packagesToReference = new List<ITaskItem>();
+            List<ITaskItem> legacyFrameworkPackages = new List<ITaskItem>();
             List<ITaskItem> runtimeFrameworks = new List<ITaskItem>();
             List<ITaskItem> targetingPacks = new List<ITaskItem>();
             List<ITaskItem> runtimePacks = new List<ITaskItem>();
@@ -97,15 +97,15 @@ protected override void ExecuteCore()
 
                 if (frameworkReference != null)
                 {
-                    if (!string.IsNullOrEmpty(knownFrameworkReference.PackagesToReference))
+                    if (!string.IsNullOrEmpty(knownFrameworkReference.LegacyFrameworkPackages))
                     {
-                        foreach (var packageAndVersion in knownFrameworkReference.PackagesToReference.Split(';'))
+                        foreach (var packageAndVersion in knownFrameworkReference.LegacyFrameworkPackages.Split(';'))
                         {
                             var items = packageAndVersion.Split('/');
                             TaskItem packageToReference = new TaskItem(items[0]);
                             packageToReference.SetMetadata(MetadataKeys.Version, items[1]);
 
-                            packagesToReference.Add(packageToReference);
+                            legacyFrameworkPackages.Add(packageToReference);
                         }
                     }
                 }
@@ -201,9 +201,9 @@ protected override void ExecuteCore()
                 PackagesToDownload = packagesToDownload.ToArray();
             }
 
-            if (packagesToReference.Any())
+            if (legacyFrameworkPackages.Any())
             {
-                PackagesToReference = packagesToReference.ToArray();
+                LegacyFrameworkPackages = legacyFrameworkPackages.ToArray();
             }
 
             if (runtimeFrameworks.Any())
@@ -376,7 +376,18 @@ public KnownFrameworkReference(ITaskItem item)
 
             public string RuntimePackRuntimeIdentifiers => _item.GetMetadata("RuntimePackRuntimeIdentifiers");
 
-            public string PackagesToReference => _item.GetMetadata("PackagesToReference");
+            public string LegacyFrameworkPackages
+            {
+                get
+                {
+                    var packages = _item.GetMetadata("LegacyFrameworkPackages");
+                    if (string.IsNullOrEmpty(packages))
+                    {
+                        packages = _item.GetMetadata("PackagesToReference");
+                    }
+                    return packages;
+                }
+            }
 
             public NuGetFramework TargetFramework { get; }
         }

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.TargetingPackResolution.targets

@@ -91,7 +91,7 @@ Copyright (c) .NET Foundation. All rights reserved.
                                 EnableTargetingPackDownload="$(EnableTargetingPackDownload)">
 
       <Output TaskParameter="PackagesToDownload" ItemName="_PackageToDownload" />
-      <Output TaskParameter="PackagesToReference" ItemName="_PackageToReference" />
+      <Output TaskParameter="LegacyFrameworkPackages" ItemName="_LegacyFrameworkPackage" />
       <Output TaskParameter="RuntimeFrameworks" ItemName="RuntimeFramework" />
       <Output TaskParameter="TargetingPacks" ItemName="TargetingPack" />
       <Output TaskParameter="RuntimePacks" ItemName="RuntimePack" />
@@ -142,11 +142,11 @@ Copyright (c) .NET Foundation. All rights reserved.
                         ExcludeAssets="all" />
     </ItemGroup>
 
-    <!-- Only add these package references if there are already existing package references,
+    <!-- Only add these "legacy" package references if there are already existing package references,
          as they are only needed in those scenarios (for example supplying the RID graph to
          NuGet, or preventing older versions of Framework packages from being used). -->
     <ItemGroup Condition="'@(PackageReference)' != '' and '$(DisableImplicitFrameworkReferences)' != 'true'">
-      <PackageReference Include="@(_PackageToReference)"
+      <PackageReference Include="@(_LegacyFrameworkPackage)"
                         IsImplicitlyDefined="true"
                         PrivateAssets="all"
                         ExcludeAssets="all" />