Skip to content

Commit adc655f

Browse files
committed
Reran IDE0028 tool on Utils. Adjusted style accordingly.
1 parent 1798411 commit adc655f

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

src/Cli/Microsoft.DotNet.Cli.Utils/ForwardingAppImplementation.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,9 @@ public ForwardingAppImplementation(
3636
_depsFile = depsFile;
3737
_runtimeConfig = runtimeConfig;
3838
_additionalProbingPath = additionalProbingPath;
39-
_environmentVariables = environmentVariables ?? new Dictionary<string, string>();
39+
_environmentVariables = environmentVariables ?? [];
4040

41-
var allArgs = new List<string>();
42-
allArgs.Add("exec");
41+
List<string> allArgs = ["exec"];
4342

4443
if (_depsFile != null)
4544
{

src/Cli/Microsoft.DotNet.Cli.Utils/FrameworkDependencyFile.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ internal static bool TryGetMostFitRuntimeIdentifier(
8787

8888
RuntimeFallbacks runtimeFallbacks = runtimeFallbacksCandidates[0];
8989

90-
var runtimeFallbacksIncludesRuntime = new List<string?>();
91-
runtimeFallbacksIncludesRuntime.Add(runtimeFallbacks.Runtime);
90+
List<string?> runtimeFallbacksIncludesRuntime = [runtimeFallbacks.Runtime];
9291
runtimeFallbacksIncludesRuntime.AddRange(runtimeFallbacks.Fallbacks);
9392

9493
var candidateMap = candidateRuntimeIdentifiers

src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ public static string MSBuildVersion
3838

3939
private readonly Dictionary<string, string> _msbuildRequiredEnvironmentVariables = GetMSBuildRequiredEnvironmentVariables();
4040

41-
private readonly List<string> _msbuildRequiredParameters =
42-
[ "-maxcpucount", "-verbosity:m" ];
41+
private readonly List<string> _msbuildRequiredParameters = [ "-maxcpucount", "-verbosity:m" ];
4342

4443
public MSBuildForwardingAppWithoutLogging(IEnumerable<string> argsToForward, string? msbuildPath = null, bool includeLogo = false)
4544
{
@@ -126,7 +125,7 @@ public int Execute()
126125
public int ExecuteInProc(string[] arguments)
127126
{
128127
// Save current environment variables before overwriting them.
129-
Dictionary<string, string?> savedEnvironmentVariables = new();
128+
Dictionary<string, string?> savedEnvironmentVariables = [];
130129
try
131130
{
132131
foreach (KeyValuePair<string, string> kvp in _msbuildRequiredEnvironmentVariables)
@@ -162,11 +161,8 @@ public int ExecuteInProc(string[] arguments)
162161
}
163162

164163
private static string Escape(string arg) =>
165-
// this is a workaround for https://github.com/Microsoft/msbuild/issues/1622
166-
IsRestoreSources(arg) ?
167-
arg.Replace(";", "%3B")
168-
.Replace("://", ":%2F%2F") :
169-
arg;
164+
// this is a workaround for https://github.com/Microsoft/msbuild/issues/1622
165+
IsRestoreSources(arg) ? arg.Replace(";", "%3B").Replace("://", ":%2F%2F") : arg;
170166

171167
private static string GetMSBuildExePath()
172168
{

src/Cli/Microsoft.DotNet.Cli.Utils/TelemetryEventEntry.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public class BlockFilter : ITelemetryFilter
7575
{
7676
public IEnumerable<ApplicationInsightsEntryFormat> Filter(object o)
7777
{
78-
return new List<ApplicationInsightsEntryFormat>();
78+
return [];
7979
}
8080
}
8181

0 commit comments

Comments
 (0)