Use terminal logger when building file-based apps (#49385)

Author: jjonescz

src/Cli/dotnet/Commands/Build/BuildCommand.cs

@@ -45,9 +45,7 @@ public static CommandBase FromParseResult(ParseResult parseResult, string msbuil
         {
             command = new VirtualProjectBuildingCommand(
                 entryPointFileFullPath: Path.GetFullPath(arg),
-                msbuildArgs: [.. forwardedOptions, .. binLogArgs],
-                verbosity: parseResult.GetValue(CommonOptions.VerbosityOption),
-                interactive: parseResult.GetValue(CommonOptions.InteractiveMsBuildForwardOption))
+                msbuildArgs: [.. forwardedOptions, .. binLogArgs])
             {
                 NoRestore = noRestore,
                 NoCache = true,

src/Cli/dotnet/Commands/Publish/PublishCommand.cs

@@ -59,9 +59,7 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
 
             return new VirtualProjectBuildingCommand(
                 entryPointFileFullPath: Path.GetFullPath(arg),
-                msbuildArgs: msbuildArgs,
-                verbosity: parseResult.GetValue(CommonOptions.VerbosityOption),
-                interactive: parseResult.GetValue(CommonOptions.InteractiveMsBuildForwardOption))
+                msbuildArgs: [.. msbuildArgs])
             {
                 NoBuild = noBuild,
                 NoRestore = noRestore,

src/Cli/dotnet/Commands/Restore/RestoreCommand.cs

@@ -33,10 +33,8 @@ public static CommandBase FromParseResult(ParseResult result, string? msbuildPat
         if (nonBinLogArgs is [{ } arg] && VirtualProjectBuildingCommand.IsValidEntryPointPath(arg))
         {
             return new VirtualProjectBuildingCommand(
-                    entryPointFileFullPath: Path.GetFullPath(arg),
-                    msbuildArgs: [.. forwardedOptions, ..binLogArgs],
-                    verbosity: result.GetValue(CommonOptions.VerbosityOption),
-                    interactive: result.GetValue(CommonOptions.InteractiveMsBuildForwardOption))
+                entryPointFileFullPath: Path.GetFullPath(arg),
+                msbuildArgs: [.. forwardedOptions, ..binLogArgs])
             {
                 NoCache = true,
                 NoBuild = true,

src/Cli/dotnet/Commands/Run/Api/RunApiCommand.cs

@@ -86,9 +86,7 @@ public override RunApiOutput Execute()
         {
             var buildCommand = new VirtualProjectBuildingCommand(
                 entryPointFileFullPath: EntryPointFileFullPath,
-                msbuildArgs: [],
-                verbosity: VerbosityOptions.quiet,
-                interactive: false)
+                msbuildArgs: ["-verbosity:quiet"])
             {
                 CustomArtifactsPath = ArtifactsPath,
             };

src/Cli/dotnet/Commands/Run/RunCommand.cs

@@ -280,9 +280,7 @@ private VirtualProjectBuildingCommand CreateVirtualCommand()
 
         return new(
             entryPointFileFullPath: EntryPointFileFullPath,
-            msbuildArgs: RestoreArgs,
-            verbosity: Verbosity,
-            interactive: Interactive)
+            msbuildArgs: RestoreArgs)
         {
             NoRestore = NoRestore,
             NoCache = NoCache,
@@ -394,7 +392,7 @@ static void InvokeRunArgumentsTarget(ProjectInstance project, string[] restoreAr
         }
     }
 
-    internal static ILogger MakeTerminalLogger(VerbosityOptions? verbosity)
+    private static ILogger MakeTerminalLogger(VerbosityOptions? verbosity)
     {
         var msbuildVerbosity = ToLoggerVerbosity(verbosity);
 

src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs

@@ -112,23 +112,19 @@ Override targets which don't work with project files that are not present on dis
 
     public VirtualProjectBuildingCommand(
         string entryPointFileFullPath,
-        IReadOnlyList<string> msbuildArgs,
-        VerbosityOptions? verbosity,
-        bool interactive)
+        string[] msbuildArgs)
     {
         Debug.Assert(Path.IsPathFullyQualified(entryPointFileFullPath));
 
         EntryPointFileFullPath = entryPointFileFullPath;
         GlobalProperties = new(StringComparer.OrdinalIgnoreCase);
         CommonRunHelpers.AddUserPassedProperties(GlobalProperties, msbuildArgs);
-        BinaryLoggerArgs = msbuildArgs;
-        Verbosity = verbosity ?? RunCommand.GetDefaultVerbosity(interactive: interactive);
+        LoggerArgs = msbuildArgs;
     }
 
     public string EntryPointFileFullPath { get; }
     public Dictionary<string, string> GlobalProperties { get; }
-    public IReadOnlyList<string> BinaryLoggerArgs { get; }
-    public VerbosityOptions Verbosity { get; }
+    public string[] LoggerArgs { get; }
     public string? CustomArtifactsPath { get; init; }
     public bool NoRestore { get; init; }
     public bool NoCache { get; init; }
@@ -138,8 +134,8 @@ public VirtualProjectBuildingCommand(
     public override int Execute()
     {
         Debug.Assert(!(NoRestore && NoBuild));
-        var consoleLogger = RunCommand.MakeTerminalLogger(Verbosity);
-        var binaryLogger = GetBinaryLogger(BinaryLoggerArgs);
+        var consoleLogger = TerminalLogger.CreateTerminalOrConsoleLogger(LoggerArgs);
+        var binaryLogger = GetBinaryLogger(LoggerArgs);
 
         RunFileBuildCacheEntry? cacheEntry = null;