Use LangVersion=Preview #48747
Merged
Use LangVersion=Preview #48747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
commented
Apr 28, 2025
| #if NET10_0_OR_GREATER | ||
| public static IEnumerable<T> Reverse<T>(T[] array) => Enumerable.Reverse(array); | ||
| #else | ||
| public static IEnumerable<T> Reverse<T>(this T[] array) => Enumerable.Reverse(array); |
There was a problem hiding this comment.
Note: This is needed to work around a C# breaking change on non-net10.0 TFMs.
(This would be needed anyway when C# 14 becomes the Latest version.)
jaredpar
approved these changes
Apr 30, 2025
|
Not sure if I need more sign offs on this simple change. If anyone has concerns, let me know, we can always revert. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's useful to dogfood C# in this repo. This also allows us to use new C# features earlier in this repo.