Skip to content

Conversation

@jaredpar
Copy link
Member

@jaredpar jaredpar commented May 7, 2025

Putting the actual package name in the documentation for quicker reference.

Putting the actual package name in the documentation for quicker reference.
@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 16:51
@jaredpar
Copy link
Member Author

jaredpar commented May 7, 2025

@baronfel PTAL

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation to display the correct package name for the .NET Framework compiler in SDK projects.

  • Updated the package name in the "FrameworkPackage" section for clarity.

> - `Core`: use the compiler that comes with the .NET SDK
> - `Framework`: use the compiler that comes with .NET Framework MSBuild
> - `FrameworkPackage`: download package with .NET Framework compiler corresponding to the .NET SDK version
> - `FrameworkPackage`: download the Microsoft.Net.Sdk.Compilers.Toolse package which contains the .NET Framework compiler corresponding to the .NET SDK version
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name 'Microsoft.Net.Sdk.Compilers.Toolse' appears to include a typo. Verify that the intended name is correct, such as 'Microsoft.Net.Sdk.Compilers.Tools'.

Suggested change
> - `FrameworkPackage`: download the Microsoft.Net.Sdk.Compilers.Toolse package which contains the .NET Framework compiler corresponding to the .NET SDK version
> - `FrameworkPackage`: download the Microsoft.Net.Sdk.Compilers.Tools package which contains the .NET Framework compiler corresponding to the .NET SDK version

Copilot uses AI. Check for mistakes.
@jaredpar
Copy link
Member Author

jaredpar commented May 8, 2025

@baronfel this PR is stuck and it's just a doc change. Can you Yoda the PR?

@baronfel
Copy link
Member

baronfel commented May 8, 2025

/ba-g

@baronfel baronfel enabled auto-merge (squash) May 8, 2025 16:10
@baronfel
Copy link
Member

baronfel commented May 8, 2025

/ba-g helix is stuck?

@baronfel baronfel merged commit d8b7dc5 into main May 8, 2025
6 of 7 checks passed
@baronfel baronfel deleted the dev/jaredpar/doc branch May 8, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants