-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HtmlTextWriter and required support #397
Conversation
95bc740
to
a59ce12
Compare
This is a port of HtmlTextWriter with the following changes: - `HtmlTextWriter.[Enter|Exit]Style(...)` methods (4 total) are not supported. The `Style` class brings in a lot of additional stuff we probably don't want to support - HashTable usage has been switched to Dictionary<,> - Manual array management has been switched to lists - Helper structs have been made into readonly records to simplify definition and usage - Annotated for nullability
a59ce12
to
676e543
Compare
Inspired by the tests in this repo https://github.com/mfeingol/htmltextwriter, I think you could add the test like below. The render code is from https://learn.microsoft.com/en-us/dotnet/api/system.web.ui.htmltextwriter.addattribute?view=netframework-4.8.1, and the expected string is result I get from .NetFramework project with same render code.
|
@Clounea you interested in adding that test? The |
Yes, but how? I tried pushing changes to this branch but I don't have access. Do you know how to add the test? |
Oh! I'll go ahead and add it - must be a permissions issue |
@twsouthwick Is there any plan to merge this PR? |
This is a port of HtmlTextWriter with the following changes:
HtmlTextWriter.[Enter|Exit]Style(...)
methods (4 total) are not supported. TheStyle
class brings in a lot of additional stuff we probably don't want to supportTODO:
Fixes #378