From f4dcda32cf8d31f6633d9bdc4b4e87311dc46c3c Mon Sep 17 00:00:00 2001
From: Noah Gilson <noahgilson@microsoft.com>
Date: Wed, 23 Oct 2024 15:55:04 -0700
Subject: [PATCH 1/3] Don't add -signed

This appears to cause some issues with loading external libraries due to new signature checks (?) added in October
---
 pipeline-templates/package-vsix.yaml | 3 ++-
 pipeline-templates/publish.yaml      | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/pipeline-templates/package-vsix.yaml b/pipeline-templates/package-vsix.yaml
index a446459f82..e85e59064d 100644
--- a/pipeline-templates/package-vsix.yaml
+++ b/pipeline-templates/package-vsix.yaml
@@ -62,7 +62,8 @@ jobs:
   - task: CmdLine@2
     displayName: 🤌 Rename Signed VSIX
     inputs:
-      script: rename ".\packages\$(package-name)-$(GetVersion.version).vsix" $(package-name)-$(GetVersion.version)-signed.vsix
+      script: rename "$(package-name)-$(GetVersion.version).vsix" $(package-name)-$(GetVersion.version)-unsigned.vsix
+    workingDirectory: $(dir-name)
   - task: CopyFiles@2
     displayName: '📩 Copy Artifact'
     inputs:
diff --git a/pipeline-templates/publish.yaml b/pipeline-templates/publish.yaml
index 6404ed9224..2d74b1bee8 100644
--- a/pipeline-templates/publish.yaml
+++ b/pipeline-templates/publish.yaml
@@ -49,7 +49,7 @@ jobs:
           $basePublishArgs = , "publish"
           $basePublishArgs += '--azure-credential'
           $basePublishArgs += '--packagePath'
-          $publishArgs = $basePublishArgs + 'vscode-dotnet-runtime-$(GetVersion.version)-signed.vsix'
+          $publishArgs = $basePublishArgs + 'vscode-dotnet-runtime-$(GetVersion.version).vsix'
           If ("${{ parameters.SignType }}" -ne "Real") {
             Write-Host "With a test-signed build, the command to publish is printed instead of run."
             Write-Host "##[command]vsce $publishArgs"

From bf419eb2117841adf544090bba59af81bc4bdc92 Mon Sep 17 00:00:00 2001
From: Noah Gilson <noahgilson@microsoft.com>
Date: Thu, 24 Oct 2024 09:32:09 -0700
Subject: [PATCH 2/3] move the line up bc yay yaml

---
 pipeline-templates/package-vsix.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pipeline-templates/package-vsix.yaml b/pipeline-templates/package-vsix.yaml
index e85e59064d..e1eea86ef6 100644
--- a/pipeline-templates/package-vsix.yaml
+++ b/pipeline-templates/package-vsix.yaml
@@ -61,9 +61,9 @@ jobs:
       SignType: ${{ parameters.SignType }}
   - task: CmdLine@2
     displayName: 🤌 Rename Signed VSIX
+    workingDirectory: $(dir-name)
     inputs:
       script: rename "$(package-name)-$(GetVersion.version).vsix" $(package-name)-$(GetVersion.version)-unsigned.vsix
-    workingDirectory: $(dir-name)
   - task: CopyFiles@2
     displayName: '📩 Copy Artifact'
     inputs:

From a9b26b9604eb0c4dba5525007b0982a0d9983950 Mon Sep 17 00:00:00 2001
From: Noah Gilson <noahgilson@microsoft.com>
Date: Thu, 24 Oct 2024 09:33:47 -0700
Subject: [PATCH 3/3] the documentation seems wrong for cmdline@2 or whitespace
 is bad idk

---
 pipeline-templates/package-vsix.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pipeline-templates/package-vsix.yaml b/pipeline-templates/package-vsix.yaml
index e1eea86ef6..4eb75f8117 100644
--- a/pipeline-templates/package-vsix.yaml
+++ b/pipeline-templates/package-vsix.yaml
@@ -61,9 +61,8 @@ jobs:
       SignType: ${{ parameters.SignType }}
   - task: CmdLine@2
     displayName: 🤌 Rename Signed VSIX
-    workingDirectory: $(dir-name)
     inputs:
-      script: rename "$(package-name)-$(GetVersion.version).vsix" $(package-name)-$(GetVersion.version)-unsigned.vsix
+      script: rename "$(dir-name)/$(package-name)-$(GetVersion.version).vsix" $(dir-name)/$(package-name)-$(GetVersion.version)-unsigned.vsix
   - task: CopyFiles@2
     displayName: '📩 Copy Artifact'
     inputs: