Null Reference Exception: System.Windows.Forms.TabControl.<WmSelChange>

[StuB-85]

.NET version

.NET 8.0
SDK: 8.0.403
RUNTIME: 8.0.10

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

TabControl crashes due to null reference exception. This can occur after all tabs are removed while TabControl.AccessibilityObject is not null.

 	System.Windows.Forms.dll!System.Windows.Forms.TabControl.WmSelChange.AnonymousMethod__214_0()	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(object obj)	Unknown
 	System.Private.CoreLib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Control.InvokeMarshaledCallbacks()	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Control.WndProc(ref System.Windows.Forms.Message m)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.TabControl.WndProc(ref System.Windows.Forms.Message m)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.NativeWindow.Callback(Windows.Win32.Foundation.HWND hWnd, Windows.Win32.MessageId msg, Windows.Win32.Foundation.WPARAM wparam, Windows.Win32.Foundation.LPARAM lparam)	Unknown
 	[Native to Managed Transition]	
 	[Managed to Native Transition]	
 	System.Windows.Forms.Primitives.dll!Windows.Win32.PInvoke.DispatchMessage(Windows.Win32.UI.WindowsAndMessaging.MSG* lpMsg)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Application.ComponentManager.Microsoft.Office.IMsoComponentManager.FPushMessageLoop(nuint dwComponentID, Microsoft.Office.msoloop uReason, void* pvLoopData)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Microsoft.Office.msoloop reason, System.Windows.Forms.ApplicationContext context)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Microsoft.Office.msoloop reason, System.Windows.Forms.ApplicationContext context)	Unknown
>	WmSelIssue.dll!WmSelIssue.Program.Main() Line 14	C#

Steps to reproduce

1. Unzip solution and open in visual studio.
2. Build and Run.
3. Click either of the repro buttons.
4. Observe the crash.

WmSelIssue.zip

[elachlan]

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/TabControl/TabControl.cs

Lines 1948 to 1971 in 8d96e56

	private bool WmSelChange()
	{
	TabControlCancelEventArgs tcc = new(SelectedTab, SelectedIndex, false, TabControlAction.Selecting);
	OnSelecting(tcc);
	if (!tcc.Cancel)
	{
	OnSelected(new TabControlEventArgs(SelectedTab, SelectedIndex, TabControlAction.Selected));
	OnSelectedIndexChanged(EventArgs.Empty);
	if (IsAccessibilityObjectCreated && SelectedTab?.ParentInternal is TabControl)
	{
	SelectedTab.TabAccessibilityObject.RaiseAutomationEvent(UIA_EVENT_ID.UIA_SelectionItem_ElementSelectedEventId);
	BeginInvoke((MethodInvoker)(() => SelectedTab.TabAccessibilityObject.RaiseAutomationEvent(UIA_EVENT_ID.UIA_AutomationFocusChangedEventId)));
	}
	}
	else
	{
	// user Cancelled the Selection of the new Tab.
	PInvokeCore.SendMessage(this, PInvoke.TCM_SETCURSEL, (WPARAM)_lastSelection);
	UpdateTabSelection(true);
	}
	return tcc.Cancel;
	}

Maybe we need to change the code to do a null check on the SelectedTab?

SelectedTab?.TabAccessibilityObject

@Olina-Zhang can your team test the issue please?

[John-Qiao]

@elachlan I tried your suggestion to do a null check on the SelectedTab? in 1959 and 1960 lines, it can fix the crash issue in demo project.

testresult.mp4

[Tanya-Solyanik]

@StuB-85 - thank you for reporting this issue! Do you require this fix in NET8?

@elachlan - thank you for jumping on this bug!

@John-Qiao - thank you, please go ahead with the PR, and add a unit test based on the customer project. Also please add to the bug description what versions this repros on, if this is a regression and what change had introduced it, this info will help with the servicing decision.
This code is not present on .NET Framework, so this is a regression in .NET - https://referencesource.microsoft.com/#System.Windows.Forms/winforms/Managed/System/WinForms/TabControl.cs,2070

Please work with @LeafShi1's team while the Redmond team is on the holidays.
Only line 1960 needs a ? - this function is executed asynchronously and by the time it is executed, we might have nulled-out the SelectedTab. Line 1959 is executed right after we check that SelectedTab is not null and controls are not accessed from other threads because cross-thread access to windows handles throws on windows level, so we know the tab is still not null.
We should additionally test the following conditions inside the delegate to guard against the case that the tab have been unparented, or accessibility objects were disposed (we don't want to recreate them or they would leak):
if (IsAccessibilityObjectCreated && SelectedTab?.ParentInternal is TabControl)

[John-Qiao]

@Tanya-Solyanik this issue occurs in .NET 6.0, 7.0, 8.0, 9.0 and latest .NET 10.0 SDK, created a PR:12683 to fix it.

[StuB-85]

@Tanya-Solyanik Yes I do require the fix in .Net 8. Thanks!

[Zheng-Li01]

Verified the issue with 8.0.11 + private dlls built from release/8.0 branch, the issue has been fixed as below screenshot.

[Olina-Zhang]

Verified the issue with 9.0.0 + private dlls built from release/9.0 branch, the issue has been fixed as above same testing result.

[Zheng-Li01]

Verified the issue with latest .NET SDK 10.0.100-alpha.1.25065.19 build, the issue has been fixed as above same testing result.