diff --git a/.editorconfig b/.editorconfig index 8223f71c590..0184b2ddfb4 100644 --- a/.editorconfig +++ b/.editorconfig @@ -1,24 +1,2056 @@ # editorconfig.org -# This file should be kept in sync across https://www.github.com/dotnet/wpf and dotnet-wpf-int repos. # top-most EditorConfig file root = true +# General guidelines +# ------------------ +# +# Prefer errors over warnings. If an error will make iteration in VS difficult, then use a warning. Warnings +# only fail the command line build. +# +# When disabling a rule, add a comment explaining why. +# +# When common settings differ between languages, use C# rules as the default in the C#/VB and override in the VB +# section. This seems to work better with the editor tooling. + # Default settings: # A newline ending every file # Use 4 spaces as indentation [*] -trim_trailing_whitespace = true -insert_final_newline = true +guidelines = 120 1px dotted 504CFF00, 150 1px dotted 50FF6A00 indent_style = space indent_size = 4 -[*.json] -indent_size = 2 +[*.json] +indent_size = 2 + +# Bvc.dll crashed in the CI build when this rule is enabled for VB. +# C# files +[src/**/*.cs] +file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license. + +# C# and VB files +[*.{cs,vb}] +charset = utf-8-bom +insert_final_newline = true +trim_trailing_whitespace = true + +# avoid this. unless absolutely necessary +dotnet_style_qualification_for_field = false:error +dotnet_style_qualification_for_property = false:error +dotnet_style_qualification_for_method = false:error +dotnet_style_qualification_for_event = false:error + +# use language keywords instead of BCL types +dotnet_style_predefined_type_for_locals_parameters_members = true:warning +dotnet_style_predefined_type_for_member_access = true:warning + +# name all constant fields using PascalCase +dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion +dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields +dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style + +dotnet_naming_symbols.constant_fields.applicable_kinds = field +dotnet_naming_symbols.constant_fields.required_modifiers = const + +dotnet_naming_style.pascal_case_style.capitalization = pascal_case + +# static fields should have s_ prefix +dotnet_naming_rule.static_fields_should_have_prefix.severity = suggestion +dotnet_naming_rule.static_fields_should_have_prefix.symbols = static_fields +dotnet_naming_rule.static_fields_should_have_prefix.style = static_prefix_style + +dotnet_naming_symbols.static_fields.applicable_kinds = field +dotnet_naming_symbols.static_fields.required_modifiers = static + +dotnet_naming_style.static_prefix_style.required_prefix = s_ +dotnet_naming_style.static_prefix_style.capitalization = camel_case + +# internal and private fields should be _camelCase +dotnet_naming_rule.camel_case_for_private_internal_fields.severity = suggestion +dotnet_naming_rule.camel_case_for_private_internal_fields.symbols = private_internal_fields +dotnet_naming_rule.camel_case_for_private_internal_fields.style = camel_case_underscore_style + +dotnet_naming_symbols.private_internal_fields.applicable_kinds = field +dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal + +dotnet_naming_style.camel_case_underscore_style.required_prefix = _ +dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case + +# Code style defaults +dotnet_sort_system_directives_first = true + +# Expression-level preferences +dotnet_style_object_initializer = true:warning +dotnet_style_collection_initializer = true:suggestion +dotnet_style_explicit_tuple_names = true:suggestion +dotnet_style_null_propagation = true:warning +dotnet_style_prefer_is_null_check_over_reference_equality_method = true:error +dotnet_style_prefer_auto_properties = true:silent +dotnet_style_prefer_simplified_boolean_expressions = true:warning +dotnet_style_prefer_inferred_tuple_names = true:suggestion +dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion +dotnet_style_prefer_compound_assignment = true:suggestion +dotnet_style_prefer_simplified_interpolation = true:suggestion +dotnet_style_namespace_match_folder = true:suggestion +dotnet_style_operator_placement_when_wrapping = beginning_of_line +tab_width = 4 +end_of_line = crlf +dotnet_style_allow_multiple_blank_lines_experimental = true:silent +dotnet_style_allow_statement_immediately_after_block_experimental = true:silent +dotnet_style_prefer_collection_expression = when_types_exactly_match:warning +dotnet_style_coalesce_expression = true:warning +dotnet_style_prefer_conditional_expression_over_assignment = true:silent +dotnet_style_prefer_conditional_expression_over_return = true:silent + +# AD0001: Analyzer threw an exception +dotnet_diagnostic.AD0001.severity = suggestion + +# IDE0001: Simplify name +dotnet_diagnostic.IDE0001.severity = suggestion + +# IDE0002: Simplify member access +dotnet_diagnostic.IDE0002.severity = suggestion + +# IDE0003: Remove this or Me qualification +dotnet_diagnostic.IDE0003.severity = suggestion + +# IDE0004: Remove Unnecessary Cast +dotnet_diagnostic.IDE0004.severity = suggestion + +# IDE0005: Using directive is unnecessary. +dotnet_diagnostic.IDE0005.severity = suggestion + +# IDE0007: Use implicit type +dotnet_diagnostic.IDE0007.severity = silent + +# IDE0008: Use explicit type +dotnet_diagnostic.IDE0008.severity = suggestion + +# IDE0009: Add this or Me qualification +dotnet_diagnostic.IDE0009.severity = silent + +# IDE0010: Add missing cases +dotnet_diagnostic.IDE0010.severity = silent + +# IDE0011: Add braces +dotnet_diagnostic.IDE0011.severity = silent + +# IDE0016: Use 'throw' expression +dotnet_diagnostic.IDE0016.severity = silent + +# IDE0017: Simplify object initialization +dotnet_diagnostic.IDE0017.severity = warning + +# IDE0018: Inline variable declaration +dotnet_diagnostic.IDE0018.severity = suggestion + +# IDE0019: Use pattern matching to avoid as followed by a null check +dotnet_diagnostic.IDE0019.severity = warning + +# IDE0020: Use pattern matching to avoid is check followed by a cast (with variable) +dotnet_diagnostic.IDE0020.severity = warning + +# IDE0021: Use expression body for constructors +dotnet_diagnostic.IDE0021.severity = silent + +# IDE0022: Use expression body for methods +dotnet_diagnostic.IDE0022.severity = silent + +# IDE0023: Use expression body for operators +dotnet_diagnostic.IDE0023.severity = silent + +# IDE0024: Use expression body for operators +dotnet_diagnostic.IDE0024.severity = silent + +# IDE0025: Use expression body for properties +dotnet_diagnostic.IDE0025.severity = silent + +# IDE0026: Use expression body for indexers +dotnet_diagnostic.IDE0026.severity = silent + +# IDE0027: Use expression body for accessors +dotnet_diagnostic.IDE0027.severity = silent + +# IDE0028: Simplify collection initialization +dotnet_diagnostic.IDE0028.severity = suggestion + +# IDE0029: Use coalesce expression +dotnet_diagnostic.IDE0029.severity = warning + +# IDE0030: Use coalesce expression +dotnet_diagnostic.IDE0030.severity = warning + +# IDE0031: Use null propagation +dotnet_diagnostic.IDE0031.severity = warning + +# IDE0032: Use auto property +dotnet_diagnostic.IDE0032.severity = silent + +# IDE0033: Use explicitly provided tuple name +dotnet_diagnostic.IDE0033.severity = suggestion + +# IDE0034: Simplify 'default' expression +dotnet_diagnostic.IDE0034.severity = warning + +# IDE0035: Remove unreachable code +dotnet_diagnostic.IDE0035.severity = suggestion + +# IDE0036: Order modifiers +dotnet_diagnostic.IDE0036.severity = warning + +# IDE0037: Use inferred member name +dotnet_diagnostic.IDE0037.severity = silent + +# IDE0038: Use pattern matching to avoid is check followed by a cast (without variable) +dotnet_diagnostic.IDE0038.severity = warning + +# IDE0039: Use local function +dotnet_diagnostic.IDE0039.severity = suggestion + +# IDE0040: Add accessibility modifiers +dotnet_diagnostic.IDE0040.severity = error + +# IDE0041: Use 'is null' check +dotnet_diagnostic.IDE0041.severity = warning + +# IDE0042: Deconstruct variable declaration +dotnet_diagnostic.IDE0042.severity = silent + +# IDE0043: Invalid format string +dotnet_diagnostic.IDE0043.severity = warning + +# IDE0044: Add readonly modifier +dotnet_diagnostic.IDE0044.severity = suggestion + +# IDE0045: Use conditional expression for assignment +dotnet_diagnostic.IDE0045.severity = suggestion + +# IDE0046: Use conditional expression for return +dotnet_diagnostic.IDE0046.severity = suggestion + +# IDE0047: Remove unnecessary parentheses +dotnet_diagnostic.IDE0047.severity = silent + +# IDE0048: Add parentheses for clarity +dotnet_diagnostic.IDE0048.severity = silent + +# IDE0049: Use language keywords instead of framework type names for type references +dotnet_diagnostic.IDE0049.severity = warning + +# IDE0051: Remove unused private members +dotnet_diagnostic.IDE0051.severity = suggestion + +# IDE0052: Remove unread private members +dotnet_diagnostic.IDE0052.severity = suggestion + +# IDE0053: Use expression body for lambdas +dotnet_diagnostic.IDE0053.severity = silent + +# IDE0054: Use compound assignment +dotnet_diagnostic.IDE0054.severity = warning + +# IDE0055: Fix formatting +dotnet_diagnostic.IDE0055.severity = suggestion + +# IDE0056: Use index operator +dotnet_diagnostic.IDE0056.severity = suggestion + +# IDE0057: Use range operator +dotnet_diagnostic.IDE0057.severity = suggestion + +# IDE0058: Expression value is never used +dotnet_diagnostic.IDE0058.severity = silent + +# IDE0059: Unnecessary assignment of a value +dotnet_diagnostic.IDE0059.severity = none # TODO: warning + +# IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = silent +dotnet_code_quality_unused_parameters = non_public + +# IDE0061: Use expression body for local functions +dotnet_diagnostic.IDE0061.severity = silent + +# IDE0062: Make local function 'static' +dotnet_diagnostic.IDE0062.severity = warning + +# IDE0063: Use simple 'using' statement +dotnet_diagnostic.IDE0063.severity = silent + +# IDE0064: Make readonly fields writable +dotnet_diagnostic.IDE0064.severity = silent + +# IDE0065: Misplaced using directive +dotnet_diagnostic.IDE0065.severity = warning + +# IDE0066: Convert switch statement to expression +dotnet_diagnostic.IDE0066.severity = suggestion + +# IDE0070: Use 'System.HashCode' +dotnet_diagnostic.IDE0070.severity = suggestion + +# IDE0071: Simplify interpolation +dotnet_diagnostic.IDE0071.severity = warning + +# IDE0072: Add missing cases +dotnet_diagnostic.IDE0072.severity = silent + +# IDE0073: The file header is missing or not located at the top of the file +dotnet_diagnostic.IDE0073.severity = warning + +# IDE0074: Use compound assignment +dotnet_diagnostic.IDE0074.severity = warning + +# IDE0075: Simplify conditional expression +dotnet_diagnostic.IDE0075.severity = silent + +# IDE0076: Invalid global 'SuppressMessageAttribute' +dotnet_diagnostic.IDE0076.severity = warning + +# IDE0077: Avoid legacy format target in 'SuppressMessageAttribute' +dotnet_diagnostic.IDE0077.severity = silent + +# IDE0078: Use pattern matching +dotnet_diagnostic.IDE0078.severity = suggestion + +# This one never seems to be right in the IDE. +# IDE0079: Remove unnecessary suppression +dotnet_diagnostic.IDE0079.severity = silent + +# IDE0080: Remove unnecessary suppression operator +dotnet_diagnostic.IDE0080.severity = warning + +# IDE0081: Remove unnecessary suppression operator +dotnet_diagnostic.IDE0081.severity = none + +# IDE0082: 'typeof' can be converted to 'nameof' +dotnet_diagnostic.IDE0082.severity = warning + +# IDE0083: Use pattern matching +dotnet_diagnostic.IDE0083.severity = silent + +# IDE0084: Use pattern matching (IsNot operator) +dotnet_diagnostic.IDE0084.severity = none + +# IDE0090: Use 'new(...)' +dotnet_diagnostic.IDE0090.severity = silent + +# IDE0100: Remove redundant equality +dotnet_diagnostic.IDE0100.severity = warning + +# IDE0110: Remove unnecessary discard +dotnet_diagnostic.IDE0110.severity = warning + +# IDE0120: Simplify LINQ expression +dotnet_diagnostic.IDE0120.severity = none + +# IDE0130: Namespace does not match folder structure +dotnet_diagnostic.IDE0130.severity = silent + +# IDE0140: Simplify object creation +dotnet_diagnostic.IDE0140.severity = none + +# IDE0150: Prefer 'null' check over type check +dotnet_diagnostic.IDE0150.severity = error + +# IDE0160: Convert to block scoped namespace +dotnet_diagnostic.IDE0160.severity = silent + +# IDE0161: Convert to file-scoped namespace +dotnet_diagnostic.IDE0161.severity = silent + +# IDE0170: Simplify property pattern +dotnet_diagnostic.IDE0170.severity = warning + +# IDE0180: Use tuple swap +dotnet_diagnostic.IDE0180.severity = suggestion + +# IDE0200: Remove unnecessary lambda expression +dotnet_diagnostic.IDE0200.severity = warning + +# IDE0210: Use top-level statements +dotnet_diagnostic.IDE0210.severity = silent + +# IDE0211: Use program main +dotnet_diagnostic.IDE0211.severity = silent + +# IDE0220: foreach cast +dotnet_diagnostic.IDE0220.severity = silent + +# IDE0230: Use UTF8 string literal +dotnet_diagnostic.IDE0230.severity = suggestion + +# IDE1005: Delegate invocation can be simplified. +dotnet_diagnostic.IDE1005.severity = warning + +# IDE1006: Naming styles +dotnet_diagnostic.IDE1006.severity = error + +# IDE2000: Allow multiple blank lines +dotnet_diagnostic.IDE2000.severity = silent + +# IDE2001: Embedded statements must be on their own line +dotnet_diagnostic.IDE2001.severity = silent + +# IDE2002: Consecutive braces must not have blank line between them +dotnet_diagnostic.IDE2002.severity = silent + +# IDE2003: Allow statement immediately after block +dotnet_diagnostic.IDE2003.severity = silent + +# IDE2004: Blank line not allowed after constructor initializer colon +dotnet_diagnostic.IDE2004.severity = silent + +# CA1000: Do not declare static members on generic types +dotnet_diagnostic.CA1000.severity = none + +# CA1001: Types that own disposable fields should be disposable +dotnet_diagnostic.CA1001.severity = none + +# CA1002: Do not expose generic lists +dotnet_diagnostic.CA1002.severity = none + +# CA1003: Use generic event handler instances +dotnet_diagnostic.CA1003.severity = none + +# CA1005: Avoid excessive parameters on generic types +dotnet_diagnostic.CA1005.severity = none + +# CA1008: Enums should have zero value +dotnet_diagnostic.CA1008.severity = none + +# CA1010: Generic interface should also be implemented +dotnet_diagnostic.CA1010.severity = none + +# CA1012: Abstract types should not have public constructors +dotnet_diagnostic.CA1012.severity = none + +# CA1014: Mark assemblies with CLSCompliant +dotnet_diagnostic.CA1014.severity = none + +# CA1016: Mark assemblies with assembly version +dotnet_diagnostic.CA1016.severity = none + +# CA1017: Mark assemblies with ComVisible +dotnet_diagnostic.CA1017.severity = none + +# CA1018: Mark attributes with AttributeUsageAttribute +dotnet_diagnostic.CA1018.severity = warning + +# CA1019: Define accessors for attribute arguments +dotnet_diagnostic.CA1019.severity = none + +# CA1021: Avoid out parameters +dotnet_diagnostic.CA1021.severity = none + +# CA1024: Use properties where appropriate +dotnet_diagnostic.CA1024.severity = none + +# CA1027: Mark enums with FlagsAttribute +dotnet_diagnostic.CA1027.severity = none + +# CA1028: Enum Storage should be Int32 +dotnet_diagnostic.CA1028.severity = none + +# CA1030: Use events where appropriate +dotnet_diagnostic.CA1030.severity = none + +# CA1031: Do not catch general exception types +dotnet_diagnostic.CA1031.severity = none + +# CA1032: Implement standard exception constructors +dotnet_diagnostic.CA1032.severity = none + +# CA1033: Interface methods should be callable by child types +dotnet_diagnostic.CA1033.severity = none + +# CA1034: Nested types should not be visible +dotnet_diagnostic.CA1034.severity = none + +# CA1036: Override methods on comparable types +dotnet_diagnostic.CA1036.severity = warning + +# CA1040: Avoid empty interfaces +dotnet_diagnostic.CA1040.severity = none + +# CA1041: Provide ObsoleteAttribute message +dotnet_diagnostic.CA1041.severity = none + +# CA1043: Use Integral Or String Argument For Indexers +dotnet_diagnostic.CA1043.severity = none + +# CA1044: Properties should not be write only +dotnet_diagnostic.CA1044.severity = none + +# CA1045: Do not pass types by reference +dotnet_diagnostic.CA1045.severity = none + +# CA1046: Do not overload equality operator on reference types +dotnet_diagnostic.CA1046.severity = none + +# CA1047: Do not declare protected member in sealed type +dotnet_diagnostic.CA1047.severity = warning + +# CA1050: Declare types in namespaces +dotnet_diagnostic.CA1050.severity = warning + +# CA1051: Do not declare visible instance fields +dotnet_diagnostic.CA1051.severity = error + +# CA1052: Static holder types should be Static or NotInheritable +dotnet_diagnostic.CA1052.severity = warning +dotnet_code_quality.CA1052.api_surface = private, internal + +# CA1054: URI-like parameters should not be strings +dotnet_diagnostic.CA1054.severity = none + +# CA1055: URI-like return values should not be strings +dotnet_diagnostic.CA1055.severity = none + +# CA1056: URI-like properties should not be strings +dotnet_diagnostic.CA1056.severity = none + +# CA1058: Types should not extend certain base types +dotnet_diagnostic.CA1058.severity = none + +# CA1060: Move pinvokes to native methods class +dotnet_diagnostic.CA1060.severity = none + +# CA1061: Do not hide base class methods +dotnet_diagnostic.CA1061.severity = none + +# CA1062: Validate arguments of public methods +dotnet_diagnostic.CA1062.severity = none + +# CA1063: Implement IDisposable Correctly +dotnet_diagnostic.CA1063.severity = none + +# CA1064: Exceptions should be public +dotnet_diagnostic.CA1064.severity = none + +# CA1065: Do not raise exceptions in unexpected locations +dotnet_diagnostic.CA1065.severity = none + +# CA1066: Implement IEquatable when overriding Object.Equals +dotnet_diagnostic.CA1066.severity = warning + +# CA1067: Override Object.Equals(object) when implementing IEquatable +dotnet_diagnostic.CA1067.severity = warning + +# CA1068: CancellationToken parameters must come last +dotnet_diagnostic.CA1068.severity = none + +# CA1069: Enums values should not be duplicated +dotnet_diagnostic.CA1069.severity = none + +# CA1070: Do not declare event fields as virtual +dotnet_diagnostic.CA1070.severity = suggestion + +# CA1200: Avoid using cref tags with a prefix +dotnet_diagnostic.CA1200.severity = suggestion + +# CA1303: Do not pass literals as localized parameters +dotnet_diagnostic.CA1303.severity = none + +# CA1304: Specify CultureInfo +dotnet_diagnostic.CA1304.severity = none + +# CA1305: Specify IFormatProvider +dotnet_diagnostic.CA1305.severity = none + +# CA1307: Specify StringComparison for clarity +dotnet_diagnostic.CA1307.severity = none + +# CA1308: Normalize strings to uppercase +dotnet_diagnostic.CA1308.severity = none + +# CA1309: Use ordinal string comparison +dotnet_diagnostic.CA1309.severity = none + +# CA1310: Specify StringComparison for correctness +dotnet_diagnostic.CA1310.severity = suggestion + +# CA1311: Specify a culture or use an invariant version +dotnet_diagnostic.CA1311.severity = warning + +# CA1401: P/Invokes should not be visible +dotnet_diagnostic.CA1401.severity = warning + +# CA1416: Validate platform compatibility +dotnet_diagnostic.CA1416.severity = warning + +# CA1417: Do not use 'OutAttribute' on string parameters for P/Invokes +dotnet_diagnostic.CA1417.severity = warning + +# CA1418: Use valid platform string +dotnet_diagnostic.CA1418.severity = warning + +# CA1419: Provide a parameterless constructor that is as visible as the containing type for concrete types derived from 'System.Runtime.InteropServices.SafeHandle' +dotnet_diagnostic.CA1419.severity = warning + +# CA1420: Property, type, or attribute requires runtime marshalling +dotnet_diagnostic.CA1420.severity = warning + +# CA1421: This method uses runtime marshalling even when the 'DisableRuntimeMarshallingAttribute' is applied +dotnet_diagnostic.CA1421.severity = suggestion + +# CA1501: Avoid excessive inheritance +dotnet_diagnostic.CA1501.severity = none + +# We fail 1502/05 in a number of places. Some are unavoidable, some could be fixed. + +# CA1502: Avoid excessive complexity +dotnet_diagnostic.CA1502.severity = none + +# CA1505: Avoid unmaintainable code +dotnet_diagnostic.CA1505.severity = none + +# CA1506: Avoid excessive class coupling +dotnet_diagnostic.CA1506.severity = none + +# CA1507: Use nameof in place of string +dotnet_diagnostic.CA1507.severity = error + +# This does not understand Debug.Assert or native code, but often finds mistakes. +# This also is very costly to run. Should turn on and occasionally and investigate. +# CA1508: Avoid dead conditional code +dotnet_diagnostic.CA1508.severity = none + +# CA1509: Invalid entry in code metrics rule specification file +dotnet_diagnostic.CA1509.severity = none + +# CA1511: Use ArgumentException throw helper +dotnet_diagnostic.CA1511.severity = error + +# CA1512: Use ArgumentOutOfRangeException throw helper +dotnet_diagnostic.CA1512.severity = error + +# CA1513: Use ObjectDisposedException throw helper +dotnet_diagnostic.CA1513.severity = error + +# CA1700: Do not name enum values 'Reserved' +dotnet_diagnostic.CA1700.severity = none + +# CA1707: Identifiers should not contain underscores +dotnet_diagnostic.CA1707.severity = none + +# CA1708: Identifiers should differ by more than case +dotnet_diagnostic.CA1708.severity = none + +# CA1710: Identifiers should have correct suffix +dotnet_diagnostic.CA1710.severity = none + +# CA1711: Identifiers should not have incorrect suffix +dotnet_diagnostic.CA1711.severity = none + +# CA1712: Do not prefix enum values with type name +dotnet_diagnostic.CA1712.severity = none + +# CA1713: Events should not have 'Before' or 'After' prefix +dotnet_diagnostic.CA1713.severity = none + +# CA1715: Identifiers should have correct prefix +dotnet_diagnostic.CA1715.severity = none + +# CA1716: Identifiers should not match keywords +dotnet_diagnostic.CA1716.severity = none + +# CA1720: Identifier contains type name +dotnet_diagnostic.CA1720.severity = none + +# CA1721: Property names should not match get methods +dotnet_diagnostic.CA1721.severity = none + +# CA1724: Type names should not match namespaces +dotnet_diagnostic.CA1724.severity = none + +# CA1725: Parameter names should match base declaration +dotnet_diagnostic.CA1725.severity = suggestion + +# CA1727: Use PascalCase for named placeholders +dotnet_diagnostic.CA1727.severity = warning + +# CA1802: Use literals where appropriate +dotnet_diagnostic.CA1802.severity = warning +dotnet_code_quality.CA1802.api_surface = private, internal + +# CA1805: Do not initialize unnecessarily +dotnet_diagnostic.CA1805.severity = warning + +# CA1806: Do not ignore method results +dotnet_diagnostic.CA1806.severity = none + +# CA1810: Initialize reference type static fields inline +dotnet_diagnostic.CA1810.severity = warning + +# CA1812: Remove empty finalizers +dotnet_diagnostic.CA1821.severity = error + +# CA1813: Avoid unsealed attributes +dotnet_diagnostic.CA1813.severity = none + +# CA1814: Prefer jagged arrays over multidimensional +dotnet_diagnostic.CA1814.severity = none + +# CA1815: Override equals and operator equals on value types +dotnet_diagnostic.CA1815.severity = warning + +# CA1816: Dispose methods should call SuppressFinalize +dotnet_diagnostic.CA1816.severity = none + +# CA1819: Properties should not return arrays +dotnet_diagnostic.CA1819.severity = none + +# CA1820: Test for empty strings using string length +dotnet_diagnostic.CA1820.severity = none + +# CA1821: Remove empty Finalizers +dotnet_diagnostic.CA1821.severity = none # TODO: warning + +# CA1822: Mark members as static +dotnet_diagnostic.CA1822.severity = warning +dotnet_code_quality.CA1822.api_surface = private, internal + +# CA1823: Avoid unused private fields +dotnet_diagnostic.CA1823.severity = warning + +# CA1824: Mark assemblies with NeutralResourcesLanguageAttribute +dotnet_diagnostic.CA1824.severity = warning + +# CA1825: Avoid zero-length array allocations +dotnet_diagnostic.CA1825.severity = warning + +# CA1825: Avoid zero-length array allocations +dotnet_diagnostic.CA1825.severity = error + +# CA1826: Use property instead of Linq Enumerable method +dotnet_diagnostic.CA1826.severity = error + +# CA1827: Do not use Count()/LongCount() when Any() can be used +dotnet_diagnostic.CA1827.severity = error + +# CA1828: Do not use CountAsync/LongCountAsync when AnyAsync can be used +dotnet_diagnostic.CA1828.severity = error + +# CA1829: Use Length/Count property instead of Enumerable.Count method +dotnet_diagnostic.CA1829.severity = error + +# CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder +dotnet_diagnostic.CA1830.severity = error + +# CA1831: Use AsSpan instead of Range-based indexers for string when appropriate +dotnet_diagnostic.CA1831.severity = error + +# CA1832: Use AsSpan or AsMemory instead of Range-based indexers for getting ReadOnlySpan or ReadOnlyMemory portion of an array +dotnet_diagnostic.CA1832.severity = error + +# CA1833: Use AsSpan or AsMemory instead of Range-based indexers for getting Span or Memory portion of an array +dotnet_diagnostic.CA1833.severity = error + +# CA1834: Use StringBuilder.Append(char) for single character strings +dotnet_diagnostic.CA1834.severity = error + +# CA1835: Prefer the memory-based overloads of ReadAsync/WriteAsync methods in stream-based classes +dotnet_diagnostic.CA1835.severity = error + +# CA1836: Prefer IsEmpty over Count when available +dotnet_diagnostic.CA1836.severity = error + +# CA1837: Use Environment.ProcessId instead of Process.GetCurrentProcess().Id +dotnet_diagnostic.CA1837.severity = error + +# CA1838: Avoid StringBuilder parameters for P/Invokes +dotnet_diagnostic.CA1838.severity = error + +# CA1839: Use Environment.ProcessPath instead of Process.GetCurrentProcess().MainModule.FileName +dotnet_diagnostic.CA1839.severity = error + +# CA1840: Use Environment.CurrentManagedThreadId instead of Thread.CurrentThread.ManagedThreadId +dotnet_diagnostic.CA1840.severity = error + +# CA1841: Prefer Dictionary Contains methods +dotnet_diagnostic.CA1841.severity = error + +# CA1842: Do not use 'WhenAll' with a single task +dotnet_diagnostic.CA1842.severity = error + +# CA1843: Do not use 'WaitAll' with a single task +dotnet_diagnostic.CA1843.severity = error + +# CA1844: Provide memory-based overrides of async methods when subclassing 'Stream' +dotnet_diagnostic.CA1844.severity = error + +# CA1845: Use span-based 'string.Concat' +dotnet_diagnostic.CA1845.severity = warning + +# CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters +dotnet_diagnostic.CA1847.severity = error + +# CA1848: Use the LoggerMessage delegates +dotnet_diagnostic.CA1848.severity = error + +# CA1849: Call async methods when in an async method +dotnet_diagnostic.CA1849.severity = suggestion + +# CA1850: Prefer static HashData method over ComputeHash +dotnet_diagnostic.CA1850.severity = error + +# CA1851: Possible multiple enumerations of IEnumerable collection +dotnet_diagnostic.CA1851.severity = error + +# CA1852: Seal internal types +dotnet_diagnostic.CA1852.severity = error + +# CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)' +dotnet_diagnostic.CA1853.severity = error + +# CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method +dotnet_diagnostic.CA1854.severity = error + +# CA1858: Use StartsWith instead of IndexOf +dotnet_diagnostic.CA1858.severity = error + +# CA1860: Avoid using 'Enumerable.Any()' extension method +dotnet_diagnostic.CA1860.severity = error + +# CA2000: Dispose objects before losing scope +dotnet_diagnostic.CA2000.severity = none + +# CA2002: Do not lock on objects with weak identity +dotnet_diagnostic.CA2002.severity = none + +# CA2007: Consider calling ConfigureAwait on the awaited task +dotnet_diagnostic.CA2007.severity = warning + +# CA2008: Do not create tasks without passing a TaskScheduler +dotnet_diagnostic.CA2008.severity = warning + +# CA2009: Do not call ToImmutableCollection on an ImmutableCollection value +dotnet_diagnostic.CA2009.severity = warning + +# CA2011: Do not assign property within its setter +dotnet_diagnostic.CA2011.severity = warning + +# CA2012: Use ValueTasks correctly +dotnet_diagnostic.CA2012.severity = warning + +# CA2013: Do not use ReferenceEquals with value types +dotnet_diagnostic.CA2013.severity = warning + +# CA2014: Do not use stackalloc in loops +dotnet_diagnostic.CA2014.severity = warning + +# CA2015: Do not define finalizers for types derived from MemoryManager +dotnet_diagnostic.CA2015.severity = warning + +# CA2016: Forward the 'CancellationToken' parameter to methods +dotnet_diagnostic.CA2016.severity = warning + +# CA2017: Parameter count mismatch +dotnet_diagnostic.CA2017.severity = warning + +# CA2018: 'Buffer.BlockCopy' expects the number of bytes to be copied for the 'count' argument +dotnet_diagnostic.CA2018.severity = warning + +# CA2019: ThreadStatic fields should not use inline initialization +dotnet_diagnostic.CA2019.severity = warning + +# CA2100: Review SQL queries for security vulnerabilities +dotnet_diagnostic.CA2100.severity = none + +# CA2101: Specify marshaling for P/Invoke string arguments +dotnet_diagnostic.CA2101.severity = none + +# CA2109: Review visible event handlers +dotnet_diagnostic.CA2109.severity = none + +# CA2119: Seal methods that satisfy private interfaces +dotnet_diagnostic.CA2119.severity = none + +# CA2153: Do Not Catch Corrupted State Exceptions +dotnet_diagnostic.CA2153.severity = none + + +# CA2200: Rethrow to preserve stack details +dotnet_diagnostic.CA2200.severity = warning + +# CA2201: Do not raise reserved exception types +dotnet_diagnostic.CA2201.severity = none + +# CA2207: Initialize value type static fields inline +dotnet_diagnostic.CA2207.severity = warning + +# CA2208: Instantiate argument exceptions correctly +dotnet_diagnostic.CA2208.severity = error + +# CA2211: Non-constant fields should not be visible +dotnet_diagnostic.CA2211.severity = error + +# CA2213: Disposable fields should be disposed +dotnet_diagnostic.CA2213.severity = none + +# CA2214: Do not call overridable methods in constructors +dotnet_diagnostic.CA2214.severity = none + +# CA2215: Dispose methods should call base class dispose +dotnet_diagnostic.CA2215.severity = none + +# CA2216: Disposable types should declare finalizer +dotnet_diagnostic.CA2216.severity = none + +# CA2217: Do not mark enums with FlagsAttribute +dotnet_diagnostic.CA2217.severity = none + +# CA2218: Override GetHashCode on overriding Equals +dotnet_diagnostic.CA2218.severity = none + +# CA2219: Do not raise exceptions in finally clauses +dotnet_diagnostic.CA2219.severity = none + +# CA2224: Override Equals on overloading operator equals +dotnet_diagnostic.CA2224.severity = none + +# CA2225: Operator overloads have named alternates +dotnet_diagnostic.CA2225.severity = none + +# CA2226: Operators should have symmetrical overloads +dotnet_diagnostic.CA2226.severity = none + +# CA2227: Collection properties should be read only +dotnet_diagnostic.CA2227.severity = none + +# CA2229: Implement serialization constructors +dotnet_diagnostic.CA2229.severity = warning + +# CA2231: Overload operator equals on overriding value type Equals +dotnet_diagnostic.CA2231.severity = none + +# CA2234: Pass system uri objects instead of strings +dotnet_diagnostic.CA2234.severity = none + +# CA2235: Mark all non-serializable fields +dotnet_diagnostic.CA2235.severity = none + +# CA2237: Mark ISerializable types with serializable +dotnet_diagnostic.CA2237.severity = none + +# CA2241: Provide correct arguments to formatting methods +dotnet_diagnostic.CA2241.severity = error + +# CA2242: Test for NaN correctly +dotnet_diagnostic.CA2242.severity = error + +# CA2243: Attribute string literals should parse correctly +dotnet_diagnostic.CA2243.severity = warning + +# CA2244: Do not duplicate indexed element initializations +dotnet_diagnostic.CA2244.severity = warning + +# CA2245: Do not assign a property to itself +dotnet_diagnostic.CA2245.severity = error + +# CA2246: Assigning symbol and its member in the same statement +dotnet_diagnostic.CA2246.severity = warning + +# CA2247: Argument passed to TaskCompletionSource constructor should be TaskCreationOptions enum instead of TaskContinuationOptions enum +dotnet_diagnostic.CA2247.severity = warning + +# CA2248: Provide correct 'enum' argument to 'Enum.HasFlag' +dotnet_diagnostic.CA2248.severity = error + +# CA2249: Consider using 'string.Contains' instead of 'string.IndexOf' +dotnet_diagnostic.CA2249.severity = error + +# CA2250: Use 'ThrowIfCancellationRequested' +dotnet_diagnostic.CA2250.severity = warning + +# CA2251: Use String.Equals over String.Compare +dotnet_diagnostic.CA2251.severity = error + +# CA2252: This API requires opting into preview features +dotnet_diagnostic.CA2252.severity = error + +# CA2253: Named placeholders should not be numeric values +dotnet_diagnostic.CA2253.severity = warning + +# CA2254: Template should be a static expression +dotnet_diagnostic.CA2254.severity = none + +# CA2255: The 'ModuleInitializer' attribute should not be used in libraries +dotnet_diagnostic.CA2255.severity = warning + +# CA2256: All members declared in parent interfaces must have an implementation in a DynamicInterfaceCastableImplementation-attributed interface +dotnet_diagnostic.CA2256.severity = warning + +# CA2257: Members defined on an interface with the 'DynamicInterfaceCastableImplementationAttribute' should be 'static' +dotnet_diagnostic.CA2257.severity = warning + +# CA2258: Providing a 'DynamicInterfaceCastableImplementation' interface in Visual Basic is unsupported +dotnet_diagnostic.CA2258.severity = warning + +# CA2259: 'ThreadStatic' only affects static fields +dotnet_diagnostic.CA2259.severity = warning + +# CA2201: Do not raise reserved exception types +dotnet_diagnostic.CA2201.severity = error + +# CA2219: Do not raise exceptions in exception clauses +dotnet_diagnostic.CA2219.severity = error + +# CA2300: Do not use insecure deserializer BinaryFormatter +dotnet_diagnostic.CA2300.severity = error + +# CA2301: Do not call BinaryFormatter.Deserialize without first setting BinaryFormatter.Binder +dotnet_diagnostic.CA2301.severity = error + +# CA2302: Ensure BinaryFormatter.Binder is set before calling BinaryFormatter.Deserialize +dotnet_diagnostic.CA2302.severity = error + +# CA2305: Do not use insecure deserializer LosFormatter +dotnet_diagnostic.CA2305.severity = error + +# CA2310: Do not use insecure deserializer NetDataContractSerializer +dotnet_diagnostic.CA2310.severity = error + +# CA2311: Do not deserialize without first setting NetDataContractSerializer.Binder +dotnet_diagnostic.CA2311.severity = error + +# CA2312: Ensure NetDataContractSerializer.Binder is set before deserializing +dotnet_diagnostic.CA2312.severity = error + +# CA2315: Do not use insecure deserializer ObjectStateFormatter +dotnet_diagnostic.CA2315.severity = error + +# CA2321: Do not deserialize with JavaScriptSerializer using a SimpleTypeResolver +dotnet_diagnostic.CA2321.severity = error + +# CA2322: Ensure JavaScriptSerializer is not initialized with SimpleTypeResolver before deserializing +dotnet_diagnostic.CA2322.severity = error + +# CA2326: Do not use TypeNameHandling values other than None +dotnet_diagnostic.CA2326.severity = error + +# CA2327: Do not use insecure JsonSerializerSettings +dotnet_diagnostic.CA2327.severity = error + +# CA2328: Ensure that JsonSerializerSettings are secure +dotnet_diagnostic.CA2328.severity = error + +# CA2329: Do not deserialize with JsonSerializer using an insecure configuration +dotnet_diagnostic.CA2329.severity = error + +# CA2330: Ensure that JsonSerializer has a secure configuration when deserializing +dotnet_diagnostic.CA2330.severity = error + +# CA2350: Do not use DataTable.ReadXml() with untrusted data +dotnet_diagnostic.CA2350.severity = error + +# CA2351: Do not use DataSet.ReadXml() with untrusted data +dotnet_diagnostic.CA2351.severity = error + +# CA2352: Unsafe DataSet or DataTable in serializable type can be vulnerable to remote code execution attacks +dotnet_diagnostic.CA2352.severity = error + +# CA2353: Unsafe DataSet or DataTable in serializable type +dotnet_diagnostic.CA2353.severity = error + +# CA2354: Unsafe DataSet or DataTable in deserialized object graph can be vulnerable to remote code execution attacks +dotnet_diagnostic.CA2354.severity = error + +# CA2355: Unsafe DataSet or DataTable type found in deserializable object graph +dotnet_diagnostic.CA2355.severity = error + +# CA2356: Unsafe DataSet or DataTable type in web deserializable object graph +dotnet_diagnostic.CA2356.severity = error + +# CA2361: Ensure auto-generated class containing DataSet.ReadXml() is not used with untrusted data +dotnet_diagnostic.CA2361.severity = error + +# CA2362: Unsafe DataSet or DataTable in auto-generated serializable type can be vulnerable to remote code execution attacks +dotnet_diagnostic.CA2362.severity = error + +# CA3001: Review code for SQL injection vulnerabilities +dotnet_diagnostic.CA3001.severity = error + +# CA3002: Review code for XSS vulnerabilities +dotnet_diagnostic.CA3002.severity = error + +# CA3003: Review code for file path injection vulnerabilities +dotnet_diagnostic.CA3003.severity = error + +# CA3004: Review code for information disclosure vulnerabilities +dotnet_diagnostic.CA3004.severity = error + +# CA3005: Review code for LDAP injection vulnerabilities +dotnet_diagnostic.CA3005.severity = error + +# CA3006: Review code for process command injection vulnerabilities +dotnet_diagnostic.CA3006.severity = error + +# CA3007: Review code for open redirect vulnerabilities +dotnet_diagnostic.CA3007.severity = error + +# CA3008: Review code for XPath injection vulnerabilities +dotnet_diagnostic.CA3008.severity = error + +# CA3009: Review code for XML injection vulnerabilities +dotnet_diagnostic.CA3009.severity = error + +# CA3010: Review code for XAML injection vulnerabilities +dotnet_diagnostic.CA3010.severity = error + +# CA3011: Review code for DLL injection vulnerabilities +dotnet_diagnostic.CA3011.severity = error + +# CA3012: Review code for regex injection vulnerabilities +dotnet_diagnostic.CA3012.severity = error + +# CA3061: Do not add schema by URL +dotnet_diagnostic.CA3061.severity = warning + +# CA3075: Insecure DTD Processing +dotnet_diagnostic.CA3075.severity = warning + +# CA3076: Insecure XSLT Script Execution +dotnet_diagnostic.CA3076.severity = warning + +# CA3077: Insecure Processing in API Design, XML Document and XML Text Reader +dotnet_diagnostic.CA3077.severity = warning + +# CA3147: Mark verb handlers with ValidateAntiForgeryToken +dotnet_diagnostic.CA3147.severity = warning + +# CA5350: Do Not Use Weak Cryptographic Algorithms +dotnet_diagnostic.CA5350.severity = warning + +# CA5351: Do Not Use Broken Cryptographic Algorithms +dotnet_diagnostic.CA5351.severity = warning + +# CA5358: Review cipher mode usage with cryptography experts +dotnet_diagnostic.CA5358.severity = warning + +# CA5359: Do not disable certificate validation +dotnet_diagnostic.CA5359.severity = warning + +# CA5360: Do not call dangerous methods in deserialization +dotnet_diagnostic.CA5360.severity = warning + +# CA5361: Do Not Disable SChannel Use of Strong Crypto +dotnet_diagnostic.CA5361.severity = warning + +# CA5362: Potential reference cycle in deserialized object graph +dotnet_diagnostic.CA5362.severity = error + +# CA5363: Do not disable request validation +dotnet_diagnostic.CA5363.severity = warning + +# CA5364: Do not use deprecated security protocols +dotnet_diagnostic.CA5364.severity = warning + +# CA5365: Do Not Disable HTTP Header Checking +dotnet_diagnostic.CA5365.severity = warning + +# CA5366: Use XmlReader For DataSet Read XML +dotnet_diagnostic.CA5366.severity = warning + +# CA5367: Do Not Serialize Types With Pointer Fields +dotnet_diagnostic.CA5367.severity = error + +# CA5368: Set ViewStateUserKey For Classes Derived From Page +dotnet_diagnostic.CA5368.severity = warning + +# CA5369: Use XmlReader for Deserialize +dotnet_diagnostic.CA5369.severity = warning + +# CA5370: Use XmlReader for validating reader +dotnet_diagnostic.CA5370.severity = warning + +# CA5371: Use XmlReader for schema read +dotnet_diagnostic.CA5371.severity = warning + +# CA5372: Use XmlReader for XPathDocument +dotnet_diagnostic.CA5372.severity = warning + +# CA5373: Do not use obsolete key derivation function +dotnet_diagnostic.CA5373.severity = warning + +# CA5374: Do not use XslTransform +dotnet_diagnostic.CA5374.severity = warning + +# CA5375: Do not use account shared access signature +dotnet_diagnostic.CA5379.severity = warning + +# CA5376: Use SharedAccessProtocol HttpsOnly +dotnet_diagnostic.CA5376.severity = warning + +# CA5377: Use Container Level Access Policy +dotnet_diagnostic.CA5377.severity = warning + +# CA5378: Do not disable ServicePointManagerSecurityProtocols +dotnet_diagnostic.CA5378.severity = warning + +# CA5379: Ensure Key Derivation Function algorithm is sufficiently strong +dotnet_diagnostic.CA5379.severity = warning + +# CA5380: Do Not Add Certificates To Root Store +dotnet_diagnostic.CA5380.severity = warning + +# CA5381: Ensure Certificates Are Not Added To Root Store +dotnet_diagnostic.CA5381.severity = warning + +# CA5382: Use Secure Cookies In ASP.NET Core +dotnet_diagnostic.CA5382.severity = error + +# CA5383: Ensure Use Secure Cookies In ASP.NET Core +dotnet_diagnostic.CA5383.severity = error + +# CA5384: Do not use digital signature algorithm (DSA) +dotnet_diagnostic.CA5384.severity = warning + +# CA5385: Use Rivest-Shamir-Adleman (RSA) algorithm with sufficient key size +dotnet_diagnostic.CA5385.severity = warning + +# CA5386: Avoid hardcoding SecurityProtocolType value +dotnet_diagnostic.CA5386.severity = error + +# CA5387: Do not use weak key derivation function with insufficient iteration count +dotnet_diagnostic.CA5397.severity = warning + +# CA5388: Ensure Sufficient Iteration Count When Using Weak Key Derivation Function +dotnet_diagnostic.CA5388.severity = error + +# CA5389: Do Not Add Archive Item's Path To The Target File System Path +dotnet_diagnostic.CA5389.severity = error + +# CA5390: Do not hard-code encryption key +dotnet_diagnostic.CA5390.severity = error + +# CA5391: Use antiforgery tokens in ASP.NET Core MVC controllers +dotnet_diagnostic.CA5391.severity = error + +# CA5392: Use DefaultDllImportSearchPaths attribute for P/Invokes +dotnet_diagnostic.CA5392.severity = none + +# CA5393: Do not use unsafe DllImportSearchPath value +dotnet_diagnostic.CA5393.severity = none + +# CA5394: Do not use insecure randomness +dotnet_diagnostic.CA5394.severity = error + +# CA5395: Miss HttpVerb attribute for action methods +dotnet_diagnostic.CA5395.severity = error + +# CA5396: Set HttpOnly to true for HttpCookie +dotnet_diagnostic.CA5396.severity = error + +# CA5397: Do not use deprecated SslProtocols values +dotnet_diagnostic.CA5397.severity = error + +# CA5398: Avoid hardcoded SslProtocols values +dotnet_diagnostic.CA5398.severity = error + +# CA5399: HttpClients should enable certificate revocation list checks +dotnet_diagnostic.CA5399.severity = error + +# CA5400: Ensure HttpClient certificate revocation list check is not disabled +dotnet_diagnostic.CA5400.severity = error + +# CA5401: Do not use CreateEncryptor with non-default IV +dotnet_diagnostic.CA5401.severity = error + +# CA5402: Use CreateEncryptor with the default IV +dotnet_diagnostic.CA5402.severity = error + +# CA5403: Do not hard-code certificate +dotnet_diagnostic.CA5403.severity = error + +# CA5404: Do not disable token validation checks +dotnet_diagnostic.CA5404.severity = error + +# CA5405: Do not always skip token validation in delegates +dotnet_diagnostic.CA5405.severity = error + +# CS1573: Parameter has no matching param tag in the XML comment (but other parameters do) +dotnet_diagnostic.CS1573.severity = none + +# IL3000: Avoid using accessing Assembly file path when publishing as a single-file +dotnet_diagnostic.IL3000.severity = none # TODO: warning + +# IL3001: Avoid using accessing Assembly file path when publishing as a single-file +dotnet_diagnostic.IL3001.severity = warning + +# IL3002: Using member with RequiresAssemblyFilesAttribute can break functionality when embedded in a single-file app +dotnet_diagnostic.IL3002.severity = warning + +# RS0041: Public members should not use oblivious types +dotnet_diagnostic.RS0041.severity = warning + +# SA0001: XML comments +dotnet_diagnostic.SA0001.severity = none + +# SA0002: Invalid settings file +dotnet_diagnostic.SA0002.severity = none + +# SA1000: Spacing around keywords +# suggestion until https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3478 is resolved +dotnet_diagnostic.SA1000.severity = suggestion + +# SA1001: Commas should not be preceded by whitespace +dotnet_diagnostic.SA1001.severity = warning + +# SA1002: Semicolons should not be preceded by a space +dotnet_diagnostic.SA1002.severity = none + +# SA1003: Operator should not appear at the end of a line +dotnet_diagnostic.SA1003.severity = none + +# SA1004: Documentation line should begin with a space +dotnet_diagnostic.SA1004.severity = none + +# SA1005: Single line comment should begin with a space +dotnet_diagnostic.SA1005.severity = warning + +# SA1006: Preprocessor keywords should not be preceded by space +dotnet_diagnostic.SA1006.severity = none + +# SA1007: Operator keyword should be followed by space +dotnet_diagnostic.SA1007.severity = none + +# SA1008: Opening parenthesis should not be preceded by a space +dotnet_diagnostic.SA1008.severity = none + +# SA1009: Closing parenthesis should not be followed by a space +dotnet_diagnostic.SA1009.severity = none + +# SA1010: Opening square brackets should not be preceded by a space +dotnet_diagnostic.SA1010.severity = none + +# SA1011: Closing square bracket should be followed by a space +dotnet_diagnostic.SA1011.severity = none + +# SA1012: Opening brace should be followed by a space +dotnet_diagnostic.SA1012.severity = none + +# SA1013: Closing brace should be preceded by a space +dotnet_diagnostic.SA1013.severity = none + +# SA1014: Opening generic brackets should not be preceded by a space +dotnet_diagnostic.SA1014.severity = warning + +# SA1015: Closing generic bracket should not be followed by a space +dotnet_diagnostic.SA1015.severity = none + +# SA1016: Opening attribute brackets should be spaced correctly +dotnet_diagnostic.SA1016.severity = none + +# SA1017: Closing attribute brackets should be spaced correctly +dotnet_diagnostic.SA1017.severity = none + +# SA1018: Nullable type symbol should not be preceded by a space +dotnet_diagnostic.SA1018.severity = warning + +# SA1019: Member access symbols should be spaced correctly +dotnet_diagnostic.SA1019.severity = none + +# SA1020: Increment symbol should not be preceded by a space +dotnet_diagnostic.SA1020.severity = warning + +# SA1021: Negative sign should be preceded by a space +dotnet_diagnostic.SA1021.severity = none + +# SA1022: Positive signs should be spaced correctly +dotnet_diagnostic.SA1022.severity = none + +# SA1023: Dereference symbol '*' should not be preceded by a space." +dotnet_diagnostic.SA1023.severity = none + +# SA1024: Colon should be followed by a space +dotnet_diagnostic.SA1024.severity = none + +# SA1025: Code should not contain multiple whitespace characters in a row +dotnet_diagnostic.SA1025.severity = none + +# SA1026: Keyword followed by span or blank line +dotnet_diagnostic.SA1026.severity = warning + +# SA1027: Tabs and spaces should be used correctly +dotnet_diagnostic.SA1027.severity = warning + +# SA1028: Code should not contain trailing whitespace +dotnet_diagnostic.SA1028.severity = warning + +# SA1100: Do not prefix calls with base unless local implementation exists +dotnet_diagnostic.SA1100.severity = none + +# SA1101: Prefix local calls with this +dotnet_diagnostic.SA1101.severity = none + +# SA1102: Query clause should follow previous clause +dotnet_diagnostic.SA1102.severity = warning + +# SA1105: Query clauses spanning multiple lines should begin on own line +dotnet_diagnostic.SA1105.severity = warning + +# SA1104: Query clause should begin on new line when previous clause spans multiple lines +dotnet_diagnostic.SA1104.severity = none + +# SA1105: Query clauses spanning multiple lines should begin on own line +dotnet_diagnostic.SA1105.severity = none + +# SA1106: Code should not contain empty statements +dotnet_diagnostic.SA1106.severity = none + +# SA1107: Code should not contain multiple statements on one line +dotnet_diagnostic.SA1107.severity = none + +# SA1108: Block statements should not contain embedded comments +dotnet_diagnostic.SA1108.severity = none + +# SA1109: Block statements should not contain embedded regions +dotnet_diagnostic.SA1109.severity = none + +# SA1110: Opening parenthesis or bracket should be on declaration line +dotnet_diagnostic.SA1110.severity = none + +# SA1111: Closing parenthesis should be on line of last parameter +dotnet_diagnostic.SA1111.severity = none + +# SA1112: Closing parenthesis should be on line of opening parenthesis +dotnet_diagnostic.SA1112.severity = none + +# SA1113: Comma should be on the same line as previous parameter +dotnet_diagnostic.SA1113.severity = warning + +# SA1114: Parameter list should follow declaration +dotnet_diagnostic.SA1114.severity = none + +# SA1115: Parameter should begin on the line after the previous parameter +dotnet_diagnostic.SA1115.severity = warning + +# SA1116: Split parameters should start on line after declaration +dotnet_diagnostic.SA1116.severity = none + +# SA1117: Parameters should be on same line or separate lines +dotnet_diagnostic.SA1117.severity = none + +# SA1118: Parameter should not span multiple lines +dotnet_diagnostic.SA1118.severity = none + +# SA1119: Statement should not use unnecessary parenthesis +dotnet_diagnostic.SA1119.severity = none + +# SA1120: Comments should contain text +dotnet_diagnostic.SA1120.severity = none + +# SA1121: Use built-in type alias +dotnet_diagnostic.SA1121.severity = warning + +# SA1122: Use string.Empty for empty strings +dotnet_diagnostic.SA1122.severity = none + +# SA1123: Region should not be located within a code element +dotnet_diagnostic.SA1123.severity = none + +# SA1124: Do not use regions +dotnet_diagnostic.SA1124.severity = none + +# SA1125: Use shorthand for nullable types +dotnet_diagnostic.SA1125.severity = error + +# SA1126: Prefix calls correctly +dotnet_diagnostic.SA1126.severity = none + +# SA1127: Generic type constraints should be on their own line +dotnet_diagnostic.SA1127.severity = none + +# SA1128: Put constructor initializers on their own line +dotnet_diagnostic.SA1128.severity = none + +# SA1129: Do not use default value type constructor +dotnet_diagnostic.SA1129.severity = warning + +# SA1130: Use lambda syntax +dotnet_diagnostic.SA1130.severity = none + +# SA1131: Constant values should appear on the right-hand side of comparisons +dotnet_diagnostic.SA1131.severity = warning + +# SA1132: Do not combine fields +dotnet_diagnostic.SA1132.severity = none + +# SA1133: Do not combine attributes +dotnet_diagnostic.SA1133.severity = none + +# SA1134: Each attribute should be placed on its own line of code +dotnet_diagnostic.SA1134.severity = none + +# SA1135: Using directive should be qualified +dotnet_diagnostic.SA1135.severity = none + +# SA1136: Enum values should be on separate lines +dotnet_diagnostic.SA1136.severity = none + +# SA1137: Elements should have the same indentation +dotnet_diagnostic.SA1137.severity = none + +# SA1139: Use literal suffix notation instead of casting +dotnet_diagnostic.SA1139.severity = none + +# SA1141: Use tuple syntax +dotnet_diagnostic.SA1141.severity = warning + +# SA1142: Refer to tuple elements by name +dotnet_diagnostic.SA1142.severity = warning + +# SA1200: Using directive should appear within a namespace declaration +dotnet_diagnostic.SA1200.severity = none + +# SA1201: Elements should appear in the correct order +dotnet_diagnostic.SA1201.severity = none + +# SA1202: Elements should be ordered by access +dotnet_diagnostic.SA1202.severity = none + +# SA1203: Constants should appear before fields +dotnet_diagnostic.SA1203.severity = none + +# SA1204: Static elements should appear before instance elements +dotnet_diagnostic.SA1204.severity = none + +# SA1205: Partial elements should declare an access modifier +dotnet_diagnostic.SA1205.severity = warning + +# SA1206: Keyword ordering - TODO Re-enable as warning after https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3527 +dotnet_diagnostic.SA1206.severity = suggestion + +# SA1207: Protected should come before internal +dotnet_diagnostic.SA1207.severity = none + +# SA1208: Using directive ordering +dotnet_diagnostic.SA1208.severity = none + +# SA1209: Using alias directives should be placed after all using namespace directives +dotnet_diagnostic.SA1209.severity = none + +# SA1210: Using directives should be ordered alphabetically by the namespaces +dotnet_diagnostic.SA1210.severity = none + +# SA1211: Using alias directive ordering +dotnet_diagnostic.SA1211.severity = none + +# SA1212: A get accessor appears after a set accessor within a property or indexer +dotnet_diagnostic.SA1212.severity = warning + +# SA1213: Event accessors should follow order +dotnet_diagnostic.SA1213.severity = none + +# SA1214: Readonly fields should appear before non-readonly fields +dotnet_diagnostic.SA1214.severity = none + +# SA1216: Using static directives should be placed at the correct location +dotnet_diagnostic.SA1216.severity = none + +# SA1217: Using static directives should be ordered alphabetically +dotnet_diagnostic.SA1217.severity = none + +# SA1300: Element should begin with an uppercase letter +dotnet_diagnostic.SA1300.severity = none + +# SA1301: Element should begin with lower-case letter +dotnet_diagnostic.SA1301.severity = none + +# SA1302: Interface names should begin with I +dotnet_diagnostic.SA1302.severity = none # TODO: warning + +# SA1303: Const field names should begin with upper-case letter +dotnet_diagnostic.SA1303.severity = none + +# SA1304: Non-private readonly fields should begin with upper-case letter +dotnet_diagnostic.SA1304.severity = none + +# SA1305: Field names should not use Hungarian notation +dotnet_diagnostic.SA1305.severity = none + +# SA1306: Field should begin with lower-case letter +dotnet_diagnostic.SA1306.severity = none + +# SA1307: Field should begin with upper-case letter +dotnet_diagnostic.SA1307.severity = none + +# SA1308: Field should not begin with the prefix 's_' +dotnet_diagnostic.SA1308.severity = none + +# SA1309: Field names should not begin with underscore +dotnet_diagnostic.SA1309.severity = none + +# SA1310: Field should not contain an underscore +dotnet_diagnostic.SA1310.severity = none + +# SA1311: Static readonly fields should begin with upper-case letter +dotnet_diagnostic.SA1311.severity = none + +# SA1312: Variable should begin with lower-case letter +dotnet_diagnostic.SA1312.severity = none + +# SA1313: Parameter should begin with lower-case letter +dotnet_diagnostic.SA1313.severity = none + +# SA1314: Type parameter names should begin with T +dotnet_diagnostic.SA1314.severity = none + +# SA1316: Tuple element names should use correct casing +dotnet_diagnostic.SA1316.severity = none + +# SA1400: Member should declare an access modifier +dotnet_diagnostic.SA1400.severity = warning + +# SA1401: Fields should be private +dotnet_diagnostic.SA1401.severity = none + +# SA1402: File may only contain a single type +dotnet_diagnostic.SA1402.severity = none + +# SA1403: File may only contain a single namespace +dotnet_diagnostic.SA1403.severity = none + +# SA1404: Code analysis suppression should have justification +dotnet_diagnostic.SA1404.severity = none # TODO: warning + +# SA1405: Debug.Assert should provide message text +dotnet_diagnostic.SA1405.severity = none + +# SA1406: Debug.Fail should provide message text +dotnet_diagnostic.SA1406.severity = none + +# SA1407: Arithmetic expressions should declare precedence +dotnet_diagnostic.SA1407.severity = none + +# SA1408: Conditional expressions should declare precedence +dotnet_diagnostic.SA1408.severity = warning + +# SA1409: Remove unnecessary code +dotnet_diagnostic.SA1409.severity = none + +# SA1410: Remove delegate parens when possible +dotnet_diagnostic.SA1410.severity = warning + +# SA1411: Attribute constructor shouldn't use unnecessary parenthesis +dotnet_diagnostic.SA1411.severity = warning + +# SA1412: Store files as UTF-8 with byte order mark +dotnet_diagnostic.SA1412.severity = none + +# SA1413: Use trailing comma in multi-line initializers +dotnet_diagnostic.SA1413.severity = none + +# SA1414: Tuple types in signatures should have element names +dotnet_diagnostic.SA1414.severity = none + +# SA1500: Braces for multi-line statements should not share line +dotnet_diagnostic.SA1500.severity = error + +# SA1501: Statement should not be on a single line +dotnet_diagnostic.SA1501.severity = none + +# SA1502: Element should not be on a single line +dotnet_diagnostic.SA1502.severity = none + +# SA1503: Braces should not be omitted +dotnet_diagnostic.SA1503.severity = none + +# SA1504: All accessors should be single-line or multi-line +dotnet_diagnostic.SA1504.severity = none + +# SA1505: An opening brace should not be followed by a blank line +dotnet_diagnostic.SA1505.severity = warning + +# SA1506: Element documentation headers should not be followed by blank line +dotnet_diagnostic.SA1506.severity = none + +# SA1507: Code should not contain multiple blank lines in a row +dotnet_diagnostic.SA1507.severity = warning + +# SA1508: A closing brace should not be preceded by a blank line +dotnet_diagnostic.SA1508.severity = warning + +# SA1509: Opening braces should not be preceded by blank line +dotnet_diagnostic.SA1509.severity = warning + +# SA1510: 'else' statement should not be preceded by a blank line +dotnet_diagnostic.SA1510.severity = none + +# SA1511: While-do footer should not be preceded by blank line +dotnet_diagnostic.SA1511.severity = none + +# SA1512: Single-line comments should not be followed by blank line +dotnet_diagnostic.SA1512.severity = none + +# SA1513: Closing brace should be followed by blank line +dotnet_diagnostic.SA1513.severity = error + +# SA1514: Element documentation header should be preceded by blank line +dotnet_diagnostic.SA1514.severity = none + +# SA1515: Single-line comment should be preceded by blank line +dotnet_diagnostic.SA1515.severity = none + +# SA1516: Elements should be separated by blank line +dotnet_diagnostic.SA1516.severity = none + +# SA1517: Code should not contain blank lines at start of file +dotnet_diagnostic.SA1517.severity = warning + +# SA1518: Code should not contain blank lines at the end of the file +dotnet_diagnostic.SA1518.severity = warning + +# SA1519: Braces should not be omitted from multi-line child statement +dotnet_diagnostic.SA1519.severity = none + +# SA1520: Use braces consistently +dotnet_diagnostic.SA1520.severity = none + +# SA1600: Elements should be documented +dotnet_diagnostic.SA1600.severity = none + +# SA1601: Partial elements should be documented +dotnet_diagnostic.SA1601.severity = none + +# SA1602: Enumeration items should be documented +dotnet_diagnostic.SA1602.severity = none +# SA1603: Documentation should contain valid XML +dotnet_diagnostic.SA1603.severity = none + +# SA1604: Element documentation should have summary +dotnet_diagnostic.SA1604.severity = none + +# SA1605: Partial element documentation should have summary +dotnet_diagnostic.SA1605.severity = none + +# SA1606: Element documentation should have summary text +dotnet_diagnostic.SA1606.severity = none + +# SA1607: Partial element documentation should have summary text +dotnet_diagnostic.SA1607.severity = none + +# SA1608: Element documentation should not have default summary +dotnet_diagnostic.SA1608.severity = none + +# SA1609: Property documentation should have value +dotnet_diagnostic.SA1609.severity = none + +# SA1610: Property documentation should have value text +dotnet_diagnostic.SA1610.severity = none + +# SA1611: The documentation for parameter 'message' is missing +dotnet_diagnostic.SA1611.severity = none + +# SA1612: The parameter documentation is at incorrect position +dotnet_diagnostic.SA1612.severity = none + +# SA1613: Element parameter documentation should declare parameter name +dotnet_diagnostic.SA1613.severity = none + +# SA1614: Element parameter documentation should have text +dotnet_diagnostic.SA1614.severity = none + +# SA1615: Element return value should be documented +dotnet_diagnostic.SA1615.severity = none + +# SA1616: Element return value documentation should have text +dotnet_diagnostic.SA1616.severity = none + +# SA1617: Void return value should not be documented +dotnet_diagnostic.SA1617.severity = none + +# SA1618: The documentation for type parameter is missing +dotnet_diagnostic.SA1618.severity = none + +# SA1619: The documentation for type parameter is missing +dotnet_diagnostic.SA1619.severity = none + +# SA1620: Generic type parameter documentation should match type parameters +dotnet_diagnostic.SA1620.severity = none + +# SA1621: Generic type parameter documentation should declare parameter name +dotnet_diagnostic.SA1621.severity = none + +# SA1622: Generic type parameter documentation should have text +dotnet_diagnostic.SA1622.severity = none + +# SA1623: Property documentation text +dotnet_diagnostic.SA1623.severity = none + +# SA1624: Because the property only contains a visible get accessor, the documentation summary text should begin with 'Gets' +dotnet_diagnostic.SA1624.severity = none + +# SA1625: Element documentation should not be copied and pasted +dotnet_diagnostic.SA1625.severity = none + +# SA1626: Single-line comments should not use documentation style slashes +dotnet_diagnostic.SA1626.severity = none + +# SA1627: The documentation text within the \'exception\' tag should not be empty +dotnet_diagnostic.SA1627.severity = none + +# SA1628: Documentation text should begin with a capital letter +dotnet_diagnostic.SA1628.severity = none + +# SA1629: Documentation text should end with a period +dotnet_diagnostic.SA1629.severity = none + +# SA1630: Documentation text should contain whitespace +dotnet_diagnostic.SA1630.severity = none + +# SA1631: Documentation should meet character percentage +dotnet_diagnostic.SA1631.severity = none + +# SA1632: Documentation text should meet minimum character length +dotnet_diagnostic.SA1632.severity = none + +# SA1633: File should have header +dotnet_diagnostic.SA1633.severity = none + +# SA1634: File header should show copyright +dotnet_diagnostic.SA1634.severity = none + +# SA1635: File header should have copyright text +dotnet_diagnostic.SA1635.severity = none + +# SA1636: File header copyright text should match +dotnet_diagnostic.SA1636.severity = none + +# SA1637: File header should contain file name +dotnet_diagnostic.SA1637.severity = none + +# SA1638: File header file name documentation should match file name +dotnet_diagnostic.SA1638.severity = none + +# SA1639: File header should have summary +dotnet_diagnostic.SA1639.severity = none + +# SA1640: File header should have valid company text +dotnet_diagnostic.SA1640.severity = none + +# SA1641: File header company name text should match +dotnet_diagnostic.SA1641.severity = none + +# SA1642: Constructor summary documentation should begin with standard text +dotnet_diagnostic.SA1642.severity = none + +# SA1643: Destructor summary documentation should begin with standard text +dotnet_diagnostic.SA1643.severity = none + +# SA1644: Documentation headers should not contain blank lines +dotnet_diagnostic.SA1644.severity = none + +# SA1645: Included documentation file does not exist +dotnet_diagnostic.SA1645.severity = none + +# SA1646: Included documentation XPath does not exist +dotnet_diagnostic.SA1646.severity = none + +# SA1647: Include node does not contain valid file and path +dotnet_diagnostic.SA1647.severity = none + +# SA1648: Inheritdoc should be used with inheriting class +dotnet_diagnostic.SA1648.severity = none + +# SA1649: File name should match first type name +dotnet_diagnostic.SA1649.severity = none + +# SA1650: Element documentation should be spelled correctly +dotnet_diagnostic.SA1650.severity = none + +# SA1651: Do not use placeholder elements +dotnet_diagnostic.SA1651.severity = none + +# SX1101: Do not prefix local calls with 'this.' +dotnet_diagnostic.SX1101.severity = none + +# SX1309: Field names should begin with underscore +dotnet_diagnostic.SX1309.severity = none + +# -------- # C# files +# -------- + [*.cs] -file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license. + +# CSIsNull001 to catch uses of == null +dotnet_diagnostic.CSIsNull001.severity = warning + +# CSIsNull002 to catch uses of != null +dotnet_diagnostic.CSIsNull002.severity = warning + +# CSIsNull001: Use 'is' pattern check +dotnet_diagnostic.CSIsNull001.severity = error + +# CSIsNull002: Use 'is not' pattern check +dotnet_diagnostic.CSIsNull002.severity = error + +# SYSLIB1045: Convert to 'GeneratedRegexAttribute'. +dotnet_diagnostic.SYSLIB1045.severity = error + +# These two (1054 and 1096) conflict with our usage of CsWin32 + +# SYSLIB1054: Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time +dotnet_diagnostic.SYSLIB1054.severity = none + +# SYSLIB1096: Convert to 'GeneratedComInterface' +dotnet_diagnostic.SYSLIB1096.severity = none + +# CA1047: Do not declare protected members in sealed types +dotnet_diagnostic.CA1047.severity = error + +# CA1310: Specify StringComparison for correctness +dotnet_diagnostic.CA1310.severity = error + +# CA1510: Use ArgumentNullException throw helper +dotnet_diagnostic.CA1510.severity = error + +# CA1514: Avoid redundant length argument +dotnet_diagnostic.CA1514.severity = error + +# CA1725: Parameter names should match base declaration +dotnet_diagnostic.CA1725.severity = error + +# CA1822: Mark members as static +dotnet_diagnostic.CA1822.severity = warning + +# CA2244: Do not duplicate indexed element initializations +dotnet_diagnostic.CA2244.severity = error + +# CA1845: Use span-based 'string.Concat' +dotnet_diagnostic.CA1845.severity = error + +# CA1846: Prefer AsSpan over Substring +dotnet_diagnostic.CA1846.severity = error + +# CA2246: Do not assign a symbol and its member in the same statement +dotnet_diagnostic.CA2246.severity = error + +# CA1855: Use Span.Clear() instead of Span.Fill() +dotnet_diagnostic.CA1855.severity = error + +# CA1857: The parameter expects a constant for optimal performance +dotnet_diagnostic.CA1857.severity = error + +# CA1859: Use concrete types when possible for improved performance +dotnet_diagnostic.CA1859.severity = error + +# DOC100: Place text in paragraphs +dotnet_diagnostic.DOC100.severity = error + +# DOC101: Use child blocks consistently +dotnet_diagnostic.DOC101.severity = warning + +# DOC102: Use child blocks consistently across elements of the same kind +dotnet_diagnostic.DOC102.severity = warning + +# DOC103: Use Unicode characters instead of HTML entities +dotnet_diagnostic.DOC103.severity = error + +# DOC104: Use see langword +dotnet_diagnostic.DOC104.severity = warning + +# DOC105: Use paramref +dotnet_diagnostic.DOC105.severity = warning + +# DOC106: Use typeparamref +dotnet_diagnostic.DOC106.severity = warning + +# DOC107: Use see cref +dotnet_diagnostic.DOC107.severity = warning + +# DOC108: Avoid empty paragraphs +dotnet_diagnostic.DOC108.severity = warning + +# IDE0001: Simplify Names +dotnet_diagnostic.IDE0001.severity = warning + +# IDE0002: Simplify Member Access +dotnet_diagnostic.IDE0002.severity = error + +# IDE0003: Remove qualification +dotnet_diagnostic.IDE0003.severity = error + +# We cannot do this currently as overload resolution is not fully up to date with params span. +# Should be able to change back to a warning once VS releases with .NET 9. +# IDE0004: Remove unnecessary cast +dotnet_diagnostic.IDE0004.severity = silent + +# IDE0008: Use explicit type instead of 'var' +dotnet_diagnostic.IDE0008.severity = silent + +# IDE0043: Invalid format string +dotnet_diagnostic.IDE0043.severity = warning + +# IDE0044: Add readonly modifier +dotnet_diagnostic.IDE0044.severity = warning + +# IDE0049: Simplify Names +dotnet_diagnostic.IDE0049.severity = warning + +# IDE0051: Remove unused private members +dotnet_diagnostic.IDE0051.severity = warning + +# IDE0052: Remove unread private members +dotnet_diagnostic.IDE0052.severity = warning + +# IDE0057: Use range operator +dotnet_diagnostic.IDE0057.severity = error + +# IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = warning + +# IDE0063: Use simple 'using' statement +dotnet_diagnostic.IDE0063.severity = warning + +# IDE0064: Make struct fields writable +dotnet_diagnostic.IDE0064.severity = warning + +# IDE0066: Convert switch statement to expression +dotnet_diagnostic.IDE0066.severity = warning + +# IDE0075: Simplify conditional expression +dotnet_diagnostic.IDE0075.severity = warning + +# IDE0076: Invalid global suppression +dotnet_diagnostic.IDE0076.severity = warning + +# IDE0077: Avoid legacy global suppression format +dotnet_diagnostic.IDE0077.severity = warning + +# IDE0078: Use pattern matching +dotnet_diagnostic.IDE0078.severity = warning + +# IDE0180: Use tuple to swap values +dotnet_diagnostic.IDE0180.severity = warning + +# IDE0251: Make member 'readonly' +dotnet_diagnostic.IDE0251.severity = warning + +# IDE0270: Use coalesce expression +dotnet_diagnostic.IDE0270.severity = warning + +# IDE0300: Simplify collection initialization +dotnet_diagnostic.IDE0300.severity = warning + +# CA1070: Do not declare event fields as virtual +dotnet_diagnostic.CA1070.severity = error + +# CA2016: Forward the CancellationToken parameter to methods that take one +dotnet_diagnostic.CA2016.severity = warning + +# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr +dotnet_diagnostic.CA2020.severity = warning + +# .NET diagnostic +dotnet_diagnostic.RS0041.severity = none +dotnet_diagnostic.IDE0005.severity = error # New line preferences csharp_new_line_before_open_brace = all @@ -36,77 +2068,27 @@ csharp_indent_case_contents = true csharp_indent_switch_labels = true csharp_indent_labels = one_less_than_current -# avoid this. unless absolutely necessary -dotnet_style_qualification_for_field = false:suggestion -dotnet_style_qualification_for_property = false:suggestion -dotnet_style_qualification_for_method = false:suggestion -dotnet_style_qualification_for_event = false:suggestion - # only use var when it's obvious what the variable type is -csharp_style_var_for_built_in_types = false:none -csharp_style_var_when_type_is_apparent = false:none -csharp_style_var_elsewhere = false:suggestion - -# use language keywords instead of BCL types -dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion -dotnet_style_predefined_type_for_member_access = true:suggestion - -# name all constant fields using PascalCase -dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion -dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields -dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style - -dotnet_naming_symbols.constant_fields.applicable_kinds = field -dotnet_naming_symbols.constant_fields.required_modifiers = const - -dotnet_naming_style.pascal_case_style.capitalization = pascal_case - -# static fields should have s_ prefix -dotnet_naming_rule.static_fields_should_have_prefix.severity = suggestion -dotnet_naming_rule.static_fields_should_have_prefix.symbols = static_fields -dotnet_naming_rule.static_fields_should_have_prefix.style = static_prefix_style - -dotnet_naming_symbols.static_fields.applicable_kinds = field -dotnet_naming_symbols.static_fields.required_modifiers = static - -dotnet_naming_style.static_prefix_style.required_prefix = s_ -dotnet_naming_style.static_prefix_style.capitalization = camel_case - -# internal and private fields should be _camelCase -dotnet_naming_rule.camel_case_for_private_internal_fields.severity = suggestion -dotnet_naming_rule.camel_case_for_private_internal_fields.symbols = private_internal_fields -dotnet_naming_rule.camel_case_for_private_internal_fields.style = camel_case_underscore_style - -dotnet_naming_symbols.private_internal_fields.applicable_kinds = field -dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal - -dotnet_naming_style.camel_case_underscore_style.required_prefix = _ -dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case +csharp_style_var_for_built_in_types = false:error +csharp_style_var_when_type_is_apparent = true:silent +csharp_style_var_elsewhere = false:silent # Code style defaults -dotnet_sort_system_directives_first = true csharp_preserve_single_line_blocks = true csharp_preserve_single_line_statements = false -# Expression-level preferences -dotnet_style_object_initializer = true:suggestion -dotnet_style_collection_initializer = true:suggestion -dotnet_style_explicit_tuple_names = true:suggestion -dotnet_style_coalesce_expression = true:suggestion -dotnet_style_null_propagation = true:suggestion - # Expression-bodied members -csharp_style_expression_bodied_methods = false:none -csharp_style_expression_bodied_constructors = false:none -csharp_style_expression_bodied_operators = false:none -csharp_style_expression_bodied_properties = true:none -csharp_style_expression_bodied_indexers = true:none -csharp_style_expression_bodied_accessors = true:none +csharp_style_expression_bodied_methods = true:silent +csharp_style_expression_bodied_constructors = true:silent +csharp_style_expression_bodied_operators = true:silent +csharp_style_expression_bodied_properties = true:silent +csharp_style_expression_bodied_indexers = true:silent +csharp_style_expression_bodied_accessors = true:silent # Pattern matching -csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion -csharp_style_pattern_matching_over_as_with_null_check = true:suggestion -csharp_style_inlined_variable_declaration = true:suggestion +csharp_style_pattern_matching_over_is_with_cast_check = true:warning +csharp_style_pattern_matching_over_as_with_null_check = true:warning +csharp_style_inlined_variable_declaration = true:warning # Null checking preferences csharp_style_throw_expression = true:suggestion @@ -136,17 +2118,54 @@ csharp_space_between_method_declaration_parameter_list_parentheses = false csharp_space_between_parentheses = false csharp_space_between_square_brackets = false +csharp_using_directive_placement = outside_namespace:silent +csharp_prefer_simple_using_statement = true:warning +csharp_prefer_braces = true:silent +csharp_style_namespace_declarations = file_scoped:silent +csharp_style_prefer_method_group_conversion = true:silent +csharp_style_prefer_top_level_statements = true:silent +csharp_style_prefer_primary_constructors = true:silent +csharp_style_expression_bodied_lambdas = true:silent +csharp_style_expression_bodied_local_functions = false:silent +csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent +csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true:silent +csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true:silent +csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true:silent +csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true:silent +csharp_style_deconstructed_variable_declaration = true:suggestion +csharp_prefer_system_threading_lock = true:warning + +# ------------------ +# Visual Basic files +# ------------------ + +[*.vb] +# Modifier preferences +visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion + +dotnet_separate_import_directive_groups = false:warning + +# CA2007: Consider calling ConfigureAwait on the awaited task +dotnet_diagnostic.CA2007.severity = suggestion + +# IDE0001: Simplify Names +dotnet_diagnostic.IDE0001.severity = silent + +# IDE0002: Simplify Member Access +dotnet_diagnostic.IDE0002.severity = silent + +# Expression-level preferences +dotnet_style_coalesce_expression = false:suggestion +dotnet_style_prefer_conditional_expression_over_assignment = false:suggestion +dotnet_style_prefer_conditional_expression_over_return = false:suggestion + # C++ Files [*.{cpp,h,in}] curly_bracket_next_line = true indent_brace_style = Allman -# Visual Studio Solution files -[*.sln] -end_of_line = lf - # Xml project files -[*.{csproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}] +[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}] indent_size = 2 # Xml build files @@ -154,15 +2173,114 @@ indent_size = 2 indent_size = 2 # Xml files -[*.{xml,stylecop,resx,ruleset}] +[*.{xml,stylecop,ruleset}] indent_size = 2 # Xml config files [*.{props,targets,config,nuspec}] indent_size = 2 +# resx Files +[*.{resx,xlf}] +indent_size = 2 +charset = utf-8-bom +insert_final_newline = true + # Shell scripts [*.sh] end_of_line = lf -[*.{cmd, bat}] + +[*.{cmd,bat}] end_of_line = crlf + +# ------------- +# Test specific +# ------------- + +[**/tests/**/*.{cs,vb}] + +# This collides with TheoryData usage +dotnet_style_prefer_collection_expression = true:silent + +# This should be fixed https://github.com/dotnet/winforms/issues/11041 +# xUnit1042: The member referenced by the MemberData attribute returns untyped data rows +dotnet_diagnostic.xUnit1042.severity = none + +# xUnit1044: Avoid using TheoryData type arguments that are not serializable +dotnet_diagnostic.xUnit1044.severity = none + +# xUnit1045: Avoid using TheoryData type arguments that might not be serializable +dotnet_diagnostic.xUnit1045.severity = none + +# CA1416: Validate platform compatibility +dotnet_diagnostic.CA1416.severity = none + +# CA1507: CA1507: Use nameof in place of string - many false positives +dotnet_diagnostic.CA1507.severity = none + +# CA1815: Override equals and operator equals on value types +dotnet_diagnostic.CA1815.severity = none + +# CA1822: Mark members as static +dotnet_diagnostic.CA1822.severity = suggestion + +# CA1852: Seal internal types +dotnet_diagnostic.CA1852.severity = suggestion + +# CA1859: Use concrete types when possible for improved performance +dotnet_diagnostic.CA1859.severity = none + +# CA1861: Avoid constant arrays as arguments - expected to be in-line for test readability (4000 hits) +dotnet_diagnostic.CA1861.severity = silent + +# CA2007: Consider calling ConfigureAwait on the awaited task +dotnet_diagnostic.CA2007.severity = suggestion + +# CA2300: Do not use insecure deserializer BinaryFormatter +dotnet_diagnostic.CA2300.severity = none + +# CA2301: Do not call BinaryFormatter.Deserialize without first setting BinaryFormatter.Binder +dotnet_diagnostic.CA2301.severity = none + +# CA2302: Ensure BinaryFormatter.Binder is set before calling BinaryFormatter.Deserialize +dotnet_diagnostic.CA2302.severity = none + +# CA5394: Do not use insecure randomness +dotnet_diagnostic.CA5394.severity = none + +# SA1115: Parameter should begin on the line after the previous parameter +dotnet_diagnostic.SA1115.severity = none + +# Verify settings +[*.{received,verified}.{txt,xml,json}] +charset = "utf-8-bom" +end_of_line = lf +indent_size = unset +indent_style = unset +insert_final_newline = false +tab_width = unset +trim_trailing_whitespace = false + +# ----------------------------- +# Artifacts directory overloads +# ----------------------------- + +# These need removed. The scripts that build PackageXmlStringTable need updated so that they +# generate code that matches the guidelines + +[PackageXmlStringTable.cs] + +# CA1507: Use nameof in place of string +dotnet_diagnostic.CA1507.severity = suggestion + +# IDE0044: Add readonly modifier +dotnet_diagnostic.IDE0044.severity = suggestion + +# IDE0078: Use pattern matching +dotnet_diagnostic.IDE0078.severity = suggestion + +# IDE0251: Make member 'readonly' +dotnet_diagnostic.IDE0251.severity = suggestion + +# IDE1006: Naming Styles +dotnet_diagnostic.IDE1006.severity = suggestion diff --git a/eng/Versions.props b/eng/Versions.props index 27c6769bc46..9fe15a24b6c 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -52,7 +52,6 @@ 9.0.0-beta.24053.1 - 10.0.0-beta.24564.1 @@ -83,10 +82,6 @@ 0.0.0.1 0.3.106 - - - 7.0.0 - 2.9.0 @@ -111,6 +106,22 @@ 1.9.0 4.0.9 + + + 0.1.495 + 1.0.0-beta.59 + 3.11.0-beta1.24219.2 + 4.10.0-3.final + $(MicrosoftCodeAnalysisCommonPackageVersion) + $(MicrosoftCodeAnalysisCommonPackageVersion) + $(MicrosoftCodeAnalysisCommonPackageVersion) + $(MicrosoftCodeAnalysisCommonPackageVersion) + 1.1.3-beta1.24352.1 + $(MicrosoftCodeAnalysisAnalyzersVersion) + 8.0.0 + 1.2.0-beta.556 + 6.11.0 + System.Reflection.MetadataLoadContext diff --git a/eng/WpfArcadeSdk/tools/CodeAnalysis.props b/eng/WpfArcadeSdk/tools/CodeAnalysis.props index 90dc04fbacb..e3d3719600c 100644 --- a/eng/WpfArcadeSdk/tools/CodeAnalysis.props +++ b/eng/WpfArcadeSdk/tools/CodeAnalysis.props @@ -1,7 +1,14 @@ - + + $(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904 + + true + + <_SkipUpgradeNetAnalyzersNuGetWarning>true diff --git a/eng/WpfArcadeSdk/tools/CodeAnalysis.targets b/eng/WpfArcadeSdk/tools/CodeAnalysis.targets index ed2a1ba0ec5..f0a520e1b64 100644 --- a/eng/WpfArcadeSdk/tools/CodeAnalysis.targets +++ b/eng/WpfArcadeSdk/tools/CodeAnalysis.targets @@ -1,10 +1,17 @@ - - - - + + + + + + + - - + + + + + + diff --git a/eng/WpfArcadeSdk/tools/CodeAnalysis/CodeAnalysis.src.globalconfig b/eng/WpfArcadeSdk/tools/CodeAnalysis/CodeAnalysis.src.globalconfig deleted file mode 100644 index f7aa4d3beb9..00000000000 --- a/eng/WpfArcadeSdk/tools/CodeAnalysis/CodeAnalysis.src.globalconfig +++ /dev/null @@ -1,1750 +0,0 @@ -is_global = true - -# AD0001: Analyzer threw an exception -dotnet_diagnostic.AD0001.severity = suggestion - -# CA1000: Do not declare static members on generic types -dotnet_diagnostic.CA1000.severity = none - -# CA1001: Types that own disposable fields should be disposable -dotnet_diagnostic.CA1001.severity = none - -# CA1002: Do not expose generic lists -dotnet_diagnostic.CA1002.severity = none - -# CA1003: Use generic event handler instances -dotnet_diagnostic.CA1003.severity = none - -# CA1005: Avoid excessive parameters on generic types -dotnet_diagnostic.CA1005.severity = none - -# CA1008: Enums should have zero value -dotnet_diagnostic.CA1008.severity = none - -# CA1010: Generic interface should also be implemented -dotnet_diagnostic.CA1010.severity = none - -# CA1012: Abstract types should not have public constructors -dotnet_diagnostic.CA1012.severity = none - -# CA1014: Mark assemblies with CLSCompliant -dotnet_diagnostic.CA1014.severity = none - -# CA1016: Mark assemblies with assembly version -dotnet_diagnostic.CA1016.severity = none - -# CA1017: Mark assemblies with ComVisible -dotnet_diagnostic.CA1017.severity = none - -# CA1018: Mark attributes with AttributeUsageAttribute -dotnet_diagnostic.CA1018.severity = warning - -# CA1019: Define accessors for attribute arguments -dotnet_diagnostic.CA1019.severity = none - -# CA1021: Avoid out parameters -dotnet_diagnostic.CA1021.severity = none - -# CA1024: Use properties where appropriate -dotnet_diagnostic.CA1024.severity = none - -# CA1027: Mark enums with FlagsAttribute -dotnet_diagnostic.CA1027.severity = none - -# CA1028: Enum Storage should be Int32 -dotnet_diagnostic.CA1028.severity = none - -# CA1030: Use events where appropriate -dotnet_diagnostic.CA1030.severity = none - -# CA1031: Do not catch general exception types -dotnet_diagnostic.CA1031.severity = none - -# CA1032: Implement standard exception constructors -dotnet_diagnostic.CA1032.severity = none - -# CA1033: Interface methods should be callable by child types -dotnet_diagnostic.CA1033.severity = none - -# CA1034: Nested types should not be visible -dotnet_diagnostic.CA1034.severity = none - -# CA1036: Override methods on comparable types -dotnet_diagnostic.CA1036.severity = none - -# CA1040: Avoid empty interfaces -dotnet_diagnostic.CA1040.severity = none - -# CA1041: Provide ObsoleteAttribute message -dotnet_diagnostic.CA1041.severity = none - -# CA1043: Use Integral Or String Argument For Indexers -dotnet_diagnostic.CA1043.severity = none - -# CA1044: Properties should not be write only -dotnet_diagnostic.CA1044.severity = none - -# CA1045: Do not pass types by reference -dotnet_diagnostic.CA1045.severity = none - -# CA1046: Do not overload equality operator on reference types -dotnet_diagnostic.CA1046.severity = none - -# CA1047: Do not declare protected member in sealed type -dotnet_diagnostic.CA1047.severity = warning - -# CA1050: Declare types in namespaces -dotnet_diagnostic.CA1050.severity = warning - -# CA1051: Do not declare visible instance fields -dotnet_diagnostic.CA1051.severity = none - -# CA1052: Static holder types should be Static or NotInheritable -dotnet_diagnostic.CA1052.severity = warning -dotnet_code_quality.CA1052.api_surface = private, internal - -# CA1054: URI-like parameters should not be strings -dotnet_diagnostic.CA1054.severity = none - -# CA1055: URI-like return values should not be strings -dotnet_diagnostic.CA1055.severity = none - -# CA1056: URI-like properties should not be strings -dotnet_diagnostic.CA1056.severity = none - -# CA1058: Types should not extend certain base types -dotnet_diagnostic.CA1058.severity = none - -# CA1060: Move pinvokes to native methods class -dotnet_diagnostic.CA1060.severity = none - -# CA1061: Do not hide base class methods -dotnet_diagnostic.CA1061.severity = none - -# CA1062: Validate arguments of public methods -dotnet_diagnostic.CA1062.severity = none - -# CA1063: Implement IDisposable Correctly -dotnet_diagnostic.CA1063.severity = none - -# CA1064: Exceptions should be public -dotnet_diagnostic.CA1064.severity = none - -# CA1065: Do not raise exceptions in unexpected locations -dotnet_diagnostic.CA1065.severity = none - -# CA1066: Implement IEquatable when overriding Object.Equals -dotnet_diagnostic.CA1066.severity = warning - -# CA1067: Override Object.Equals(object) when implementing IEquatable -dotnet_diagnostic.CA1067.severity = warning - -# CA1068: CancellationToken parameters must come last -dotnet_diagnostic.CA1068.severity = none - -# CA1069: Enums values should not be duplicated -dotnet_diagnostic.CA1069.severity = none - -# CA1070: Do not declare event fields as virtual -dotnet_diagnostic.CA1070.severity = suggestion - -# CA1200: Avoid using cref tags with a prefix -dotnet_diagnostic.CA1200.severity = suggestion - -# CA1303: Do not pass literals as localized parameters -dotnet_diagnostic.CA1303.severity = none - -# CA1304: Specify CultureInfo -dotnet_diagnostic.CA1304.severity = none - -# CA1305: Specify IFormatProvider -dotnet_diagnostic.CA1305.severity = none - -# CA1307: Specify StringComparison for clarity -dotnet_diagnostic.CA1307.severity = none - -# CA1308: Normalize strings to uppercase -dotnet_diagnostic.CA1308.severity = none - -# CA1309: Use ordinal string comparison -dotnet_diagnostic.CA1309.severity = none - -# CA1310: Specify StringComparison for correctness -dotnet_diagnostic.CA1310.severity = suggestion - -# CA1311: Specify a culture or use an invariant version -dotnet_diagnostic.CA1311.severity = warning - -# CA1401: P/Invokes should not be visible -dotnet_diagnostic.CA1401.severity = warning - -# CA1416: Validate platform compatibility -dotnet_diagnostic.CA1416.severity = warning - -# CA1417: Do not use 'OutAttribute' on string parameters for P/Invokes -dotnet_diagnostic.CA1417.severity = warning - -# CA1418: Use valid platform string -dotnet_diagnostic.CA1418.severity = warning - -# CA1419: Provide a parameterless constructor that is as visible as the containing type for concrete types derived from 'System.Runtime.InteropServices.SafeHandle' -dotnet_diagnostic.CA1419.severity = warning - -# CA1420: Property, type, or attribute requires runtime marshalling -dotnet_diagnostic.CA1420.severity = warning - -# CA1421: This method uses runtime marshalling even when the 'DisableRuntimeMarshallingAttribute' is applied -dotnet_diagnostic.CA1421.severity = suggestion - -# CA1501: Avoid excessive inheritance -dotnet_diagnostic.CA1501.severity = none - -# CA1502: Avoid excessive complexity -dotnet_diagnostic.CA1502.severity = none - -# CA1505: Avoid unmaintainable code -dotnet_diagnostic.CA1505.severity = none - -# CA1506: Avoid excessive class coupling -dotnet_diagnostic.CA1506.severity = none - -# CA1507: Use nameof to express symbol names -dotnet_diagnostic.CA1507.severity = warning - -# CA1508: Avoid dead conditional code -dotnet_diagnostic.CA1508.severity = none - -# CA1509: Invalid entry in code metrics rule specification file -dotnet_diagnostic.CA1509.severity = none - -# CA1700: Do not name enum values 'Reserved' -dotnet_diagnostic.CA1700.severity = none - -# CA1707: Identifiers should not contain underscores -dotnet_diagnostic.CA1707.severity = none - -# CA1708: Identifiers should differ by more than case -dotnet_diagnostic.CA1708.severity = none - -# CA1710: Identifiers should have correct suffix -dotnet_diagnostic.CA1710.severity = none - -# CA1711: Identifiers should not have incorrect suffix -dotnet_diagnostic.CA1711.severity = none - -# CA1712: Do not prefix enum values with type name -dotnet_diagnostic.CA1712.severity = none - -# CA1713: Events should not have 'Before' or 'After' prefix -dotnet_diagnostic.CA1713.severity = none - -# CA1715: Identifiers should have correct prefix -dotnet_diagnostic.CA1715.severity = none - -# CA1716: Identifiers should not match keywords -dotnet_diagnostic.CA1716.severity = none - -# CA1720: Identifier contains type name -dotnet_diagnostic.CA1720.severity = none - -# CA1721: Property names should not match get methods -dotnet_diagnostic.CA1721.severity = none - -# CA1724: Type names should not match namespaces -dotnet_diagnostic.CA1724.severity = none - -# CA1725: Parameter names should match base declaration -dotnet_diagnostic.CA1725.severity = suggestion - -# CA1727: Use PascalCase for named placeholders -dotnet_diagnostic.CA1727.severity = warning - -# CA1802: Use literals where appropriate -dotnet_diagnostic.CA1802.severity = warning -dotnet_code_quality.CA1802.api_surface = private, internal - -# CA1805: Do not initialize unnecessarily -dotnet_diagnostic.CA1805.severity = warning - -# CA1806: Do not ignore method results -dotnet_diagnostic.CA1806.severity = none - -# CA1810: Initialize reference type static fields inline -dotnet_diagnostic.CA1810.severity = warning - -# CA1812: Avoid uninstantiated internal classes -dotnet_diagnostic.CA1812.severity = warning - -# CA1813: Avoid unsealed attributes -dotnet_diagnostic.CA1813.severity = none - -# CA1814: Prefer jagged arrays over multidimensional -dotnet_diagnostic.CA1814.severity = none - -# CA1815: Override equals and operator equals on value types -dotnet_diagnostic.CA1815.severity = none - -# CA1816: Dispose methods should call SuppressFinalize -dotnet_diagnostic.CA1816.severity = none - -# CA1819: Properties should not return arrays -dotnet_diagnostic.CA1819.severity = none - -# CA1820: Test for empty strings using string length -dotnet_diagnostic.CA1820.severity = none - -# CA1821: Remove empty Finalizers -dotnet_diagnostic.CA1821.severity = none # TODO: warning - -# CA1822: Mark members as static -dotnet_diagnostic.CA1822.severity = none # TODO: warning -dotnet_code_quality.CA1822.api_surface = private, internal - -# CA1823: Avoid unused private fields -dotnet_diagnostic.CA1823.severity = warning - -# CA1824: Mark assemblies with NeutralResourcesLanguageAttribute -dotnet_diagnostic.CA1824.severity = warning - -# CA1825: Avoid zero-length array allocations -dotnet_diagnostic.CA1825.severity = warning - -# CA1826: Do not use Enumerable methods on indexable collections -dotnet_diagnostic.CA1826.severity = warning - -# CA1827: Do not use Count() or LongCount() when Any() can be used -dotnet_diagnostic.CA1827.severity = warning - -# CA1828: Do not use CountAsync() or LongCountAsync() when AnyAsync() can be used -dotnet_diagnostic.CA1828.severity = warning - -# CA1829: Use Length/Count property instead of Count() when available -dotnet_diagnostic.CA1829.severity = warning - -# CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder -dotnet_diagnostic.CA1830.severity = warning - -# CA1831: Use AsSpan or AsMemory instead of Range-based indexers when appropriate -dotnet_diagnostic.CA1831.severity = warning - -# CA1832: Use AsSpan or AsMemory instead of Range-based indexers when appropriate -dotnet_diagnostic.CA1832.severity = warning - -# CA1833: Use AsSpan or AsMemory instead of Range-based indexers when appropriate -dotnet_diagnostic.CA1833.severity = warning - -# CA1834: Consider using 'StringBuilder.Append(char)' when applicable -dotnet_diagnostic.CA1834.severity = warning - -# CA1835: Prefer the 'Memory'-based overloads for 'ReadAsync' and 'WriteAsync' -dotnet_diagnostic.CA1835.severity = warning - -# CA1836: Prefer IsEmpty over Count -dotnet_diagnostic.CA1836.severity = warning - -# CA1837: Use 'Environment.ProcessId' -dotnet_diagnostic.CA1837.severity = warning - -# CA1838: Avoid 'StringBuilder' parameters for P/Invokes -dotnet_diagnostic.CA1838.severity = warning - -# CA1839: Use 'Environment.ProcessPath' -dotnet_diagnostic.CA1839.severity = warning - -# CA1840: Use 'Environment.CurrentManagedThreadId' -dotnet_diagnostic.CA1840.severity = warning - -# CA1841: Prefer Dictionary.Contains methods -dotnet_diagnostic.CA1841.severity = warning - -# CA1842: Do not use 'WhenAll' with a single task -dotnet_diagnostic.CA1842.severity = warning - -# CA1843: Do not use 'WaitAll' with a single task -dotnet_diagnostic.CA1843.severity = warning - -# CA1844: Provide memory-based overrides of async methods when subclassing 'Stream' -dotnet_diagnostic.CA1844.severity = warning - -# CA1845: Use span-based 'string.Concat' -dotnet_diagnostic.CA1845.severity = warning - -# CA1846: Prefer 'AsSpan' over 'Substring' -dotnet_diagnostic.CA1846.severity = warning - -# CA1847: Use char literal for a single character lookup -dotnet_diagnostic.CA1847.severity = warning - -# CA1848: Use the LoggerMessage delegates -dotnet_diagnostic.CA1848.severity = none - -# CA1849: Call async methods when in an async method -dotnet_diagnostic.CA1849.severity = suggestion - -# CA1850: Prefer static 'HashData' method over 'ComputeHash' -dotnet_diagnostic.CA1850.severity = warning - -# CA1851: Possible multiple enumerations of 'IEnumerable' collection -dotnet_diagnostic.CA1851.severity = suggestion - -# CA1852: Seal internal types -dotnet_diagnostic.CA1852.severity = none # TODO: warning - -# CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)' -dotnet_diagnostic.CA1853.severity = warning - -# CA1854: Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method -dotnet_diagnostic.CA1854.severity = warning - -# CA2000: Dispose objects before losing scope -dotnet_diagnostic.CA2000.severity = none - -# CA2002: Do not lock on objects with weak identity -dotnet_diagnostic.CA2002.severity = none - -# CA2007: Consider calling ConfigureAwait on the awaited task -dotnet_diagnostic.CA2007.severity = warning - -# CA2008: Do not create tasks without passing a TaskScheduler -dotnet_diagnostic.CA2008.severity = warning - -# CA2009: Do not call ToImmutableCollection on an ImmutableCollection value -dotnet_diagnostic.CA2009.severity = warning - -# CA2011: Avoid infinite recursion -dotnet_diagnostic.CA2011.severity = warning - -# CA2012: Use ValueTasks correctly -dotnet_diagnostic.CA2012.severity = warning - -# CA2013: Do not use ReferenceEquals with value types -dotnet_diagnostic.CA2013.severity = warning - -# CA2014: Do not use stackalloc in loops -dotnet_diagnostic.CA2014.severity = warning - -# CA2015: Do not define finalizers for types derived from MemoryManager -dotnet_diagnostic.CA2015.severity = warning - -# CA2016: Forward the 'CancellationToken' parameter to methods -dotnet_diagnostic.CA2016.severity = warning - -# CA2017: Parameter count mismatch -dotnet_diagnostic.CA2017.severity = warning - -# CA2018: 'Buffer.BlockCopy' expects the number of bytes to be copied for the 'count' argument -dotnet_diagnostic.CA2018.severity = warning - -# CA2019: Improper 'ThreadStatic' field initialization -dotnet_diagnostic.CA2019.severity = warning - -# CA2100: Review SQL queries for security vulnerabilities -dotnet_diagnostic.CA2100.severity = none - -# CA2101: Specify marshaling for P/Invoke string arguments -dotnet_diagnostic.CA2101.severity = none - -# CA2109: Review visible event handlers -dotnet_diagnostic.CA2109.severity = none - -# CA2119: Seal methods that satisfy private interfaces -dotnet_diagnostic.CA2119.severity = none - -# CA2153: Do Not Catch Corrupted State Exceptions -dotnet_diagnostic.CA2153.severity = none - -# CA2200: Rethrow to preserve stack details -dotnet_diagnostic.CA2200.severity = warning - -# CA2201: Do not raise reserved exception types -dotnet_diagnostic.CA2201.severity = none - -# CA2207: Initialize value type static fields inline -dotnet_diagnostic.CA2207.severity = warning - -# CA2208: Instantiate argument exceptions correctly -dotnet_diagnostic.CA2208.severity = none # TODO: warning -dotnet_code_quality.CA2208.api_surface = public - -# CA2211: Non-constant fields should not be visible -dotnet_diagnostic.CA2211.severity = none - -# CA2213: Disposable fields should be disposed -dotnet_diagnostic.CA2213.severity = none - -# CA2214: Do not call overridable methods in constructors -dotnet_diagnostic.CA2214.severity = none - -# CA2215: Dispose methods should call base class dispose -dotnet_diagnostic.CA2215.severity = none - -# CA2216: Disposable types should declare finalizer -dotnet_diagnostic.CA2216.severity = none - -# CA2217: Do not mark enums with FlagsAttribute -dotnet_diagnostic.CA2217.severity = none - -# CA2218: Override GetHashCode on overriding Equals -dotnet_diagnostic.CA2218.severity = none - -# CA2219: Do not raise exceptions in finally clauses -dotnet_diagnostic.CA2219.severity = none - -# CA2224: Override Equals on overloading operator equals -dotnet_diagnostic.CA2224.severity = none - -# CA2225: Operator overloads have named alternates -dotnet_diagnostic.CA2225.severity = none - -# CA2226: Operators should have symmetrical overloads -dotnet_diagnostic.CA2226.severity = none - -# CA2227: Collection properties should be read only -dotnet_diagnostic.CA2227.severity = none - -# CA2229: Implement serialization constructors -dotnet_diagnostic.CA2229.severity = warning - -# CA2231: Overload operator equals on overriding value type Equals -dotnet_diagnostic.CA2231.severity = none - -# CA2234: Pass system uri objects instead of strings -dotnet_diagnostic.CA2234.severity = none - -# CA2235: Mark all non-serializable fields -dotnet_diagnostic.CA2235.severity = none - -# CA2237: Mark ISerializable types with serializable -dotnet_diagnostic.CA2237.severity = none - -# CA2241: Provide correct arguments to formatting methods -dotnet_diagnostic.CA2241.severity = warning - -# CA2242: Test for NaN correctly -dotnet_diagnostic.CA2242.severity = warning - -# CA2243: Attribute string literals should parse correctly -dotnet_diagnostic.CA2243.severity = warning - -# CA2244: Do not duplicate indexed element initializations -dotnet_diagnostic.CA2244.severity = warning - -# CA2245: Do not assign a property to itself -dotnet_diagnostic.CA2245.severity = none # TODO: warning - -# CA2246: Assigning symbol and its member in the same statement -dotnet_diagnostic.CA2246.severity = warning - -# CA2247: Argument passed to TaskCompletionSource constructor should be TaskCreationOptions enum instead of TaskContinuationOptions enum -dotnet_diagnostic.CA2247.severity = warning - -# CA2248: Provide correct 'enum' argument to 'Enum.HasFlag' -dotnet_diagnostic.CA2248.severity = warning - -# CA2249: Consider using 'string.Contains' instead of 'string.IndexOf' -dotnet_diagnostic.CA2249.severity = warning - -# CA2250: Use 'ThrowIfCancellationRequested' -dotnet_diagnostic.CA2250.severity = warning - -# CA2251: Use 'string.Equals' -dotnet_diagnostic.CA2251.severity = warning - -# CA2252: This API requires opting into preview features -dotnet_diagnostic.CA2252.severity = error - -# CA2253: Named placeholders should not be numeric values -dotnet_diagnostic.CA2253.severity = warning - -# CA2254: Template should be a static expression -dotnet_diagnostic.CA2254.severity = none - -# CA2255: The 'ModuleInitializer' attribute should not be used in libraries -dotnet_diagnostic.CA2255.severity = warning - -# CA2256: All members declared in parent interfaces must have an implementation in a DynamicInterfaceCastableImplementation-attributed interface -dotnet_diagnostic.CA2256.severity = warning - -# CA2257: Members defined on an interface with the 'DynamicInterfaceCastableImplementationAttribute' should be 'static' -dotnet_diagnostic.CA2257.severity = warning - -# CA2258: Providing a 'DynamicInterfaceCastableImplementation' interface in Visual Basic is unsupported -dotnet_diagnostic.CA2258.severity = warning - -# CA2259: 'ThreadStatic' only affects static fields -dotnet_diagnostic.CA2259.severity = warning - -# CA2300: Do not use insecure deserializer BinaryFormatter -dotnet_diagnostic.CA2300.severity = none - -# CA2301: Do not call BinaryFormatter.Deserialize without first setting BinaryFormatter.Binder -dotnet_diagnostic.CA2301.severity = none - -# CA2302: Ensure BinaryFormatter.Binder is set before calling BinaryFormatter.Deserialize -dotnet_diagnostic.CA2302.severity = none - -# CA2305: Do not use insecure deserializer LosFormatter -dotnet_diagnostic.CA2305.severity = none - -# CA2310: Do not use insecure deserializer NetDataContractSerializer -dotnet_diagnostic.CA2310.severity = none - -# CA2311: Do not deserialize without first setting NetDataContractSerializer.Binder -dotnet_diagnostic.CA2311.severity = none - -# CA2312: Ensure NetDataContractSerializer.Binder is set before deserializing -dotnet_diagnostic.CA2312.severity = none - -# CA2315: Do not use insecure deserializer ObjectStateFormatter -dotnet_diagnostic.CA2315.severity = none - -# CA2321: Do not deserialize with JavaScriptSerializer using a SimpleTypeResolver -dotnet_diagnostic.CA2321.severity = none - -# CA2322: Ensure JavaScriptSerializer is not initialized with SimpleTypeResolver before deserializing -dotnet_diagnostic.CA2322.severity = none - -# CA2326: Do not use TypeNameHandling values other than None -dotnet_diagnostic.CA2326.severity = none - -# CA2327: Do not use insecure JsonSerializerSettings -dotnet_diagnostic.CA2327.severity = none - -# CA2328: Ensure that JsonSerializerSettings are secure -dotnet_diagnostic.CA2328.severity = none - -# CA2329: Do not deserialize with JsonSerializer using an insecure configuration -dotnet_diagnostic.CA2329.severity = none - -# CA2330: Ensure that JsonSerializer has a secure configuration when deserializing -dotnet_diagnostic.CA2330.severity = none - -# CA2350: Do not use DataTable.ReadXml() with untrusted data -dotnet_diagnostic.CA2350.severity = none - -# CA2351: Do not use DataSet.ReadXml() with untrusted data -dotnet_diagnostic.CA2351.severity = none - -# CA2352: Unsafe DataSet or DataTable in serializable type can be vulnerable to remote code execution attacks -dotnet_diagnostic.CA2352.severity = none - -# CA2353: Unsafe DataSet or DataTable in serializable type -dotnet_diagnostic.CA2353.severity = none - -# CA2354: Unsafe DataSet or DataTable in deserialized object graph can be vulnerable to remote code execution attacks -dotnet_diagnostic.CA2354.severity = none - -# CA2355: Unsafe DataSet or DataTable type found in deserializable object graph -dotnet_diagnostic.CA2355.severity = none - -# CA2356: Unsafe DataSet or DataTable type in web deserializable object graph -dotnet_diagnostic.CA2356.severity = none - -# CA2361: Ensure auto-generated class containing DataSet.ReadXml() is not used with untrusted data -dotnet_diagnostic.CA2361.severity = none - -# CA2362: Unsafe DataSet or DataTable in auto-generated serializable type can be vulnerable to remote code execution attacks -dotnet_diagnostic.CA2362.severity = none - -# CA3001: Review code for SQL injection vulnerabilities -dotnet_diagnostic.CA3001.severity = none - -# CA3002: Review code for XSS vulnerabilities -dotnet_diagnostic.CA3002.severity = none - -# CA3003: Review code for file path injection vulnerabilities -dotnet_diagnostic.CA3003.severity = none - -# CA3004: Review code for information disclosure vulnerabilities -dotnet_diagnostic.CA3004.severity = none - -# CA3005: Review code for LDAP injection vulnerabilities -dotnet_diagnostic.CA3005.severity = none - -# CA3006: Review code for process command injection vulnerabilities -dotnet_diagnostic.CA3006.severity = none - -# CA3007: Review code for open redirect vulnerabilities -dotnet_diagnostic.CA3007.severity = none - -# CA3008: Review code for XPath injection vulnerabilities -dotnet_diagnostic.CA3008.severity = none - -# CA3009: Review code for XML injection vulnerabilities -dotnet_diagnostic.CA3009.severity = none - -# CA3010: Review code for XAML injection vulnerabilities -dotnet_diagnostic.CA3010.severity = none - -# CA3011: Review code for DLL injection vulnerabilities -dotnet_diagnostic.CA3011.severity = none - -# CA3012: Review code for regex injection vulnerabilities -dotnet_diagnostic.CA3012.severity = none - -# CA3061: Do Not Add Schema By URL -dotnet_diagnostic.CA3061.severity = warning - -# CA3075: Insecure DTD processing in XML -dotnet_diagnostic.CA3075.severity = warning - -# CA3076: Insecure XSLT script processing. -dotnet_diagnostic.CA3076.severity = warning - -# CA3077: Insecure Processing in API Design, XmlDocument and XmlTextReader -dotnet_diagnostic.CA3077.severity = warning - -# CA3147: Mark Verb Handlers With Validate Antiforgery Token -dotnet_diagnostic.CA3147.severity = warning - -# CA5350: Do Not Use Weak Cryptographic Algorithms -dotnet_diagnostic.CA5350.severity = warning - -# CA5351: Do Not Use Broken Cryptographic Algorithms -dotnet_diagnostic.CA5351.severity = warning - -# CA5358: Review cipher mode usage with cryptography experts -dotnet_diagnostic.CA5358.severity = none - -# CA5359: Do Not Disable Certificate Validation -dotnet_diagnostic.CA5359.severity = warning - -# CA5360: Do Not Call Dangerous Methods In Deserialization -dotnet_diagnostic.CA5360.severity = warning - -# CA5361: Do Not Disable SChannel Use of Strong Crypto -dotnet_diagnostic.CA5361.severity = warning - -# CA5362: Potential reference cycle in deserialized object graph -dotnet_diagnostic.CA5362.severity = none - -# CA5363: Do Not Disable Request Validation -dotnet_diagnostic.CA5363.severity = warning - -# CA5364: Do Not Use Deprecated Security Protocols -dotnet_diagnostic.CA5364.severity = warning - -# CA5365: Do Not Disable HTTP Header Checking -dotnet_diagnostic.CA5365.severity = warning - -# CA5366: Use XmlReader for 'DataSet.ReadXml()' -dotnet_diagnostic.CA5366.severity = none - -# CA5367: Do Not Serialize Types With Pointer Fields -dotnet_diagnostic.CA5367.severity = none - -# CA5368: Set ViewStateUserKey For Classes Derived From Page -dotnet_diagnostic.CA5368.severity = warning - -# CA5369: Use XmlReader for 'XmlSerializer.Deserialize()' -dotnet_diagnostic.CA5369.severity = none - -# CA5370: Use XmlReader for XmlValidatingReader constructor -dotnet_diagnostic.CA5370.severity = warning - -# CA5371: Use XmlReader for 'XmlSchema.Read()' -dotnet_diagnostic.CA5371.severity = none - -# CA5372: Use XmlReader for XPathDocument constructor -dotnet_diagnostic.CA5372.severity = none - -# CA5373: Do not use obsolete key derivation function -dotnet_diagnostic.CA5373.severity = warning - -# CA5374: Do Not Use XslTransform -dotnet_diagnostic.CA5374.severity = warning - -# CA5375: Do Not Use Account Shared Access Signature -dotnet_diagnostic.CA5375.severity = none - -# CA5376: Use SharedAccessProtocol HttpsOnly -dotnet_diagnostic.CA5376.severity = warning - -# CA5377: Use Container Level Access Policy -dotnet_diagnostic.CA5377.severity = warning - -# CA5378: Do not disable ServicePointManagerSecurityProtocols -dotnet_diagnostic.CA5378.severity = warning - -# CA5379: Ensure Key Derivation Function algorithm is sufficiently strong -dotnet_diagnostic.CA5379.severity = warning - -# CA5380: Do Not Add Certificates To Root Store -dotnet_diagnostic.CA5380.severity = warning - -# CA5381: Ensure Certificates Are Not Added To Root Store -dotnet_diagnostic.CA5381.severity = warning - -# CA5382: Use Secure Cookies In ASP.NET Core -dotnet_diagnostic.CA5382.severity = none - -# CA5383: Ensure Use Secure Cookies In ASP.NET Core -dotnet_diagnostic.CA5383.severity = none - -# CA5384: Do Not Use Digital Signature Algorithm (DSA) -dotnet_diagnostic.CA5384.severity = warning - -# CA5385: Use Rivest-Shamir-Adleman (RSA) Algorithm With Sufficient Key Size -dotnet_diagnostic.CA5385.severity = warning - -# CA5386: Avoid hardcoding SecurityProtocolType value -dotnet_diagnostic.CA5386.severity = none - -# CA5387: Do Not Use Weak Key Derivation Function With Insufficient Iteration Count -dotnet_diagnostic.CA5387.severity = none - -# CA5388: Ensure Sufficient Iteration Count When Using Weak Key Derivation Function -dotnet_diagnostic.CA5388.severity = none - -# CA5389: Do Not Add Archive Item's Path To The Target File System Path -dotnet_diagnostic.CA5389.severity = none - -# CA5390: Do not hard-code encryption key -dotnet_diagnostic.CA5390.severity = none - -# CA5391: Use antiforgery tokens in ASP.NET Core MVC controllers -dotnet_diagnostic.CA5391.severity = none - -# CA5392: Use DefaultDllImportSearchPaths attribute for P/Invokes -dotnet_diagnostic.CA5392.severity = none - -# CA5393: Do not use unsafe DllImportSearchPath value -dotnet_diagnostic.CA5393.severity = none - -# CA5394: Do not use insecure randomness -dotnet_diagnostic.CA5394.severity = none - -# CA5395: Miss HttpVerb attribute for action methods -dotnet_diagnostic.CA5395.severity = none - -# CA5396: Set HttpOnly to true for HttpCookie -dotnet_diagnostic.CA5396.severity = none - -# CA5397: Do not use deprecated SslProtocols values -dotnet_diagnostic.CA5397.severity = none - -# CA5398: Avoid hardcoded SslProtocols values -dotnet_diagnostic.CA5398.severity = none - -# CA5399: HttpClients should enable certificate revocation list checks -dotnet_diagnostic.CA5399.severity = none - -# CA5400: Ensure HttpClient certificate revocation list check is not disabled -dotnet_diagnostic.CA5400.severity = none - -# CA5401: Do not use CreateEncryptor with non-default IV -dotnet_diagnostic.CA5401.severity = none - -# CA5402: Use CreateEncryptor with the default IV -dotnet_diagnostic.CA5402.severity = none - -# CA5403: Do not hard-code certificate -dotnet_diagnostic.CA5403.severity = none - -# CA5404: Do not disable token validation checks -dotnet_diagnostic.CA5404.severity = none - -# CA5405: Do not always skip token validation in delegates -dotnet_diagnostic.CA5405.severity = none - -# IL3000: Avoid using accessing Assembly file path when publishing as a single-file -dotnet_diagnostic.IL3000.severity = none # TODO: warning - -# IL3001: Avoid using accessing Assembly file path when publishing as a single-file -dotnet_diagnostic.IL3001.severity = warning - -# IL3002: Using member with RequiresAssemblyFilesAttribute can break functionality when embedded in a single-file app -dotnet_diagnostic.IL3002.severity = warning - -# RS0041: Public members should not use oblivious types -dotnet_diagnostic.RS0041.severity = none - -# SA0001: XML comments -dotnet_diagnostic.SA0001.severity = none - -# SA0002: Invalid settings file -dotnet_diagnostic.SA0002.severity = none - -# SA1000: Spacing around keywords -# suggestion until https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3478 is resolved -dotnet_diagnostic.SA1000.severity = suggestion - -# SA1001: Commas should not be preceded by whitespace -dotnet_diagnostic.SA1001.severity = warning - -# SA1002: Semicolons should not be preceded by a space -dotnet_diagnostic.SA1002.severity = none - -# SA1003: Operator should not appear at the end of a line -dotnet_diagnostic.SA1003.severity = none - -# SA1004: Documentation line should begin with a space -dotnet_diagnostic.SA1004.severity = none - -# SA1005: Single line comment should begin with a space -dotnet_diagnostic.SA1005.severity = none - -# SA1006: Preprocessor keywords should not be preceded by space -dotnet_diagnostic.SA1006.severity = none - -# SA1007: Operator keyword should be followed by space -dotnet_diagnostic.SA1007.severity = none - -# SA1008: Opening parenthesis should not be preceded by a space -dotnet_diagnostic.SA1008.severity = none - -# SA1009: Closing parenthesis should not be followed by a space -dotnet_diagnostic.SA1009.severity = none - -# SA1010: Opening square brackets should not be preceded by a space -dotnet_diagnostic.SA1010.severity = none - -# SA1011: Closing square bracket should be followed by a space -dotnet_diagnostic.SA1011.severity = none - -# SA1012: Opening brace should be followed by a space -dotnet_diagnostic.SA1012.severity = none - -# SA1013: Closing brace should be preceded by a space -dotnet_diagnostic.SA1013.severity = none - -# SA1014: Opening generic brackets should not be preceded by a space -dotnet_diagnostic.SA1014.severity = warning - -# SA1015: Closing generic bracket should not be followed by a space -dotnet_diagnostic.SA1015.severity = none - -# SA1016: Opening attribute brackets should be spaced correctly -dotnet_diagnostic.SA1016.severity = none - -# SA1017: Closing attribute brackets should be spaced correctly -dotnet_diagnostic.SA1017.severity = none - -# SA1018: Nullable type symbol should not be preceded by a space -dotnet_diagnostic.SA1018.severity = warning - -# SA1019: Member access symbols should be spaced correctly -dotnet_diagnostic.SA1019.severity = none - -# SA1020: Increment symbol should not be preceded by a space -dotnet_diagnostic.SA1020.severity = warning - -# SA1021: Negative sign should be preceded by a space -dotnet_diagnostic.SA1021.severity = none - -# SA1022: Positive signs should be spaced correctly -dotnet_diagnostic.SA1022.severity = none - -# SA1023: Dereference symbol '*' should not be preceded by a space." -dotnet_diagnostic.SA1023.severity = none - -# SA1024: Colon should be followed by a space -dotnet_diagnostic.SA1024.severity = none - -# SA1025: Code should not contain multiple whitespace characters in a row -dotnet_diagnostic.SA1025.severity = none - -# SA1026: Keyword followed by span or blank line -dotnet_diagnostic.SA1026.severity = warning - -# SA1027: Tabs and spaces should be used correctly -dotnet_diagnostic.SA1027.severity = warning - -# SA1028: Code should not contain trailing whitespace -dotnet_diagnostic.SA1028.severity = warning - -# SA1100: Do not prefix calls with base unless local implementation exists -dotnet_diagnostic.SA1100.severity = none - -# SA1101: Prefix local calls with this -dotnet_diagnostic.SA1101.severity = none - -# SA1102: Query clause should follow previous clause -dotnet_diagnostic.SA1102.severity = warning - -# SA1105: Query clauses spanning multiple lines should begin on own line -dotnet_diagnostic.SA1105.severity = warning - -# SA1104: Query clause should begin on new line when previous clause spans multiple lines -dotnet_diagnostic.SA1104.severity = none - -# SA1105: Query clauses spanning multiple lines should begin on own line -dotnet_diagnostic.SA1105.severity = none - -# SA1106: Code should not contain empty statements -dotnet_diagnostic.SA1106.severity = none - -# SA1107: Code should not contain multiple statements on one line -dotnet_diagnostic.SA1107.severity = none - -# SA1108: Block statements should not contain embedded comments -dotnet_diagnostic.SA1108.severity = none - -# SA1109: Block statements should not contain embedded regions -dotnet_diagnostic.SA1109.severity = none - -# SA1110: Opening parenthesis or bracket should be on declaration line -dotnet_diagnostic.SA1110.severity = none - -# SA1111: Closing parenthesis should be on line of last parameter -dotnet_diagnostic.SA1111.severity = none - -# SA1112: Closing parenthesis should be on line of opening parenthesis -dotnet_diagnostic.SA1112.severity = none - -# SA1113: Comma should be on the same line as previous parameter -dotnet_diagnostic.SA1113.severity = warning - -# SA1114: Parameter list should follow declaration -dotnet_diagnostic.SA1114.severity = none - -# SA1115: Parameter should begin on the line after the previous parameter -dotnet_diagnostic.SA1115.severity = warning - -# SA1116: Split parameters should start on line after declaration -dotnet_diagnostic.SA1116.severity = none - -# SA1117: Parameters should be on same line or separate lines -dotnet_diagnostic.SA1117.severity = none - -# SA1118: Parameter should not span multiple lines -dotnet_diagnostic.SA1118.severity = none - -# SA1119: Statement should not use unnecessary parenthesis -dotnet_diagnostic.SA1119.severity = none - -# SA1120: Comments should contain text -dotnet_diagnostic.SA1120.severity = none - -# SA1121: Use built-in type alias -dotnet_diagnostic.SA1121.severity = warning - -# SA1122: Use string.Empty for empty strings -dotnet_diagnostic.SA1122.severity = none - -# SA1123: Region should not be located within a code element -dotnet_diagnostic.SA1123.severity = none - -# SA1124: Do not use regions -dotnet_diagnostic.SA1124.severity = none - -# SA1125: Use shorthand for nullable types -dotnet_diagnostic.SA1125.severity = none - -# SA1126: Prefix calls correctly -dotnet_diagnostic.SA1126.severity = none - -# SA1127: Generic type constraints should be on their own line -dotnet_diagnostic.SA1127.severity = none - -# SA1128: Put constructor initializers on their own line -dotnet_diagnostic.SA1128.severity = none - -# SA1129: Do not use default value type constructor -dotnet_diagnostic.SA1129.severity = warning - -# SA1130: Use lambda syntax -dotnet_diagnostic.SA1130.severity = none - -# SA1131: Constant values should appear on the right-hand side of comparisons -dotnet_diagnostic.SA1131.severity = warning - -# SA1132: Do not combine fields -dotnet_diagnostic.SA1132.severity = none - -# SA1133: Do not combine attributes -dotnet_diagnostic.SA1133.severity = none - -# SA1134: Each attribute should be placed on its own line of code -dotnet_diagnostic.SA1134.severity = none - -# SA1135: Using directive should be qualified -dotnet_diagnostic.SA1135.severity = none - -# SA1136: Enum values should be on separate lines -dotnet_diagnostic.SA1136.severity = none - -# SA1137: Elements should have the same indentation -dotnet_diagnostic.SA1137.severity = none - -# SA1139: Use literal suffix notation instead of casting -dotnet_diagnostic.SA1139.severity = none - -# SA1141: Use tuple syntax -dotnet_diagnostic.SA1141.severity = warning - -# SA1142: Refer to tuple elements by name -dotnet_diagnostic.SA1142.severity = warning - -# SA1200: Using directive should appear within a namespace declaration -dotnet_diagnostic.SA1200.severity = none - -# SA1201: Elements should appear in the correct order -dotnet_diagnostic.SA1201.severity = none - -# SA1202: Elements should be ordered by access -dotnet_diagnostic.SA1202.severity = none - -# SA1203: Constants should appear before fields -dotnet_diagnostic.SA1203.severity = none - -# SA1204: Static elements should appear before instance elements -dotnet_diagnostic.SA1204.severity = none - -# SA1205: Partial elements should declare an access modifier -dotnet_diagnostic.SA1205.severity = warning - -# SA1206: Keyword ordering - TODO Re-enable as warning after https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3527 -dotnet_diagnostic.SA1206.severity = suggestion - -# SA1207: Protected should come before internal -dotnet_diagnostic.SA1207.severity = none - -# SA1208: Using directive ordering -dotnet_diagnostic.SA1208.severity = none - -# SA1209: Using alias directives should be placed after all using namespace directives -dotnet_diagnostic.SA1209.severity = none - -# SA1210: Using directives should be ordered alphabetically by the namespaces -dotnet_diagnostic.SA1210.severity = none - -# SA1211: Using alias directive ordering -dotnet_diagnostic.SA1211.severity = none - -# SA1212: A get accessor appears after a set accessor within a property or indexer -dotnet_diagnostic.SA1212.severity = warning - -# SA1213: Event accessors should follow order -dotnet_diagnostic.SA1213.severity = none - -# SA1214: Readonly fields should appear before non-readonly fields -dotnet_diagnostic.SA1214.severity = none - -# SA1216: Using static directives should be placed at the correct location -dotnet_diagnostic.SA1216.severity = none - -# SA1217: Using static directives should be ordered alphabetically -dotnet_diagnostic.SA1217.severity = none - -# SA1300: Element should begin with an uppercase letter -dotnet_diagnostic.SA1300.severity = none - -# SA1301: Element should begin with lower-case letter -dotnet_diagnostic.SA1301.severity = none - -# SA1302: Interface names should begin with I -dotnet_diagnostic.SA1302.severity = none # TODO: warning - -# SA1303: Const field names should begin with upper-case letter -dotnet_diagnostic.SA1303.severity = none - -# SA1304: Non-private readonly fields should begin with upper-case letter -dotnet_diagnostic.SA1304.severity = none - -# SA1305: Field names should not use Hungarian notation -dotnet_diagnostic.SA1305.severity = none - -# SA1306: Field should begin with lower-case letter -dotnet_diagnostic.SA1306.severity = none - -# SA1307: Field should begin with upper-case letter -dotnet_diagnostic.SA1307.severity = none - -# SA1308: Field should not begin with the prefix 's_' -dotnet_diagnostic.SA1308.severity = none - -# SA1309: Field names should not begin with underscore -dotnet_diagnostic.SA1309.severity = none - -# SA1310: Field should not contain an underscore -dotnet_diagnostic.SA1310.severity = none - -# SA1311: Static readonly fields should begin with upper-case letter -dotnet_diagnostic.SA1311.severity = none - -# SA1312: Variable should begin with lower-case letter -dotnet_diagnostic.SA1312.severity = none - -# SA1313: Parameter should begin with lower-case letter -dotnet_diagnostic.SA1313.severity = none - -# SA1314: Type parameter names should begin with T -dotnet_diagnostic.SA1314.severity = none - -# SA1316: Tuple element names should use correct casing -dotnet_diagnostic.SA1316.severity = none - -# SA1400: Member should declare an access modifier -dotnet_diagnostic.SA1400.severity = none # TODO: warning - -# SA1401: Fields should be private -dotnet_diagnostic.SA1401.severity = none - -# SA1402: File may only contain a single type -dotnet_diagnostic.SA1402.severity = none - -# SA1403: File may only contain a single namespace -dotnet_diagnostic.SA1403.severity = none - -# SA1404: Code analysis suppression should have justification -dotnet_diagnostic.SA1404.severity = none # TODO: warning - -# SA1405: Debug.Assert should provide message text -dotnet_diagnostic.SA1405.severity = none - -# SA1406: Debug.Fail should provide message text -dotnet_diagnostic.SA1406.severity = none - -# SA1407: Arithmetic expressions should declare precedence -dotnet_diagnostic.SA1407.severity = none - -# SA1408: Conditional expressions should declare precedence -dotnet_diagnostic.SA1408.severity = warning - -# SA1409: Remove unnecessary code -dotnet_diagnostic.SA1409.severity = none - -# SA1410: Remove delegate parens when possible -dotnet_diagnostic.SA1410.severity = warning - -# SA1411: Attribute constructor shouldn't use unnecessary parenthesis -dotnet_diagnostic.SA1411.severity = warning - -# SA1412: Store files as UTF-8 with byte order mark -dotnet_diagnostic.SA1412.severity = none - -# SA1413: Use trailing comma in multi-line initializers -dotnet_diagnostic.SA1413.severity = none - -# SA1414: Tuple types in signatures should have element names -dotnet_diagnostic.SA1414.severity = none - -# SA1500: Braces for multi-line statements should not share line -dotnet_diagnostic.SA1500.severity = error - -# SA1501: Statement should not be on a single line -dotnet_diagnostic.SA1501.severity = none - -# SA1502: Element should not be on a single line -dotnet_diagnostic.SA1502.severity = none - -# SA1503: Braces should not be omitted -dotnet_diagnostic.SA1503.severity = none - -# SA1504: All accessors should be single-line or multi-line -dotnet_diagnostic.SA1504.severity = none - -# SA1505: An opening brace should not be followed by a blank line -dotnet_diagnostic.SA1505.severity = warning - -# SA1506: Element documentation headers should not be followed by blank line -dotnet_diagnostic.SA1506.severity = none - -# SA1507: Code should not contain multiple blank lines in a row -dotnet_diagnostic.SA1507.severity = warning - -# SA1508: A closing brace should not be preceded by a blank line -dotnet_diagnostic.SA1508.severity = warning - -# SA1509: Opening braces should not be preceded by blank line -dotnet_diagnostic.SA1509.severity = warning - -# SA1510: 'else' statement should not be preceded by a blank line -dotnet_diagnostic.SA1510.severity = none - -# SA1511: While-do footer should not be preceded by blank line -dotnet_diagnostic.SA1511.severity = none - -# SA1512: Single-line comments should not be followed by blank line -dotnet_diagnostic.SA1512.severity = none - -# SA1513: Closing brace should be followed by blank line -dotnet_diagnostic.SA1513.severity = error - -# SA1514: Element documentation header should be preceded by blank line -dotnet_diagnostic.SA1514.severity = none - -# SA1515: Single-line comment should be preceded by blank line -dotnet_diagnostic.SA1515.severity = none - -# SA1516: Elements should be separated by blank line -dotnet_diagnostic.SA1516.severity = none - -# SA1517: Code should not contain blank lines at start of file -dotnet_diagnostic.SA1517.severity = warning - -# SA1518: Code should not contain blank lines at the end of the file -dotnet_diagnostic.SA1518.severity = warning - -# SA1519: Braces should not be omitted from multi-line child statement -dotnet_diagnostic.SA1519.severity = none - -# SA1520: Use braces consistently -dotnet_diagnostic.SA1520.severity = none - -# SA1600: Elements should be documented -dotnet_diagnostic.SA1600.severity = none - -# SA1601: Partial elements should be documented -dotnet_diagnostic.SA1601.severity = none - -# SA1602: Enumeration items should be documented -dotnet_diagnostic.SA1602.severity = none - -# SA1603: Documentation should contain valid XML -dotnet_diagnostic.SA1603.severity = none - -# SA1604: Element documentation should have summary -dotnet_diagnostic.SA1604.severity = none - -# SA1605: Partial element documentation should have summary -dotnet_diagnostic.SA1605.severity = none - -# SA1606: Element documentation should have summary text -dotnet_diagnostic.SA1606.severity = none - -# SA1607: Partial element documentation should have summary text -dotnet_diagnostic.SA1607.severity = none - -# SA1608: Element documentation should not have default summary -dotnet_diagnostic.SA1608.severity = none - -# SA1609: Property documentation should have value -dotnet_diagnostic.SA1609.severity = none - -# SA1610: Property documentation should have value text -dotnet_diagnostic.SA1610.severity = none - -# SA1611: The documentation for parameter 'message' is missing -dotnet_diagnostic.SA1611.severity = none - -# SA1612: The parameter documentation is at incorrect position -dotnet_diagnostic.SA1612.severity = none - -# SA1613: Element parameter documentation should declare parameter name -dotnet_diagnostic.SA1613.severity = none - -# SA1614: Element parameter documentation should have text -dotnet_diagnostic.SA1614.severity = none - -# SA1615: Element return value should be documented -dotnet_diagnostic.SA1615.severity = none - -# SA1616: Element return value documentation should have text -dotnet_diagnostic.SA1616.severity = none - -# SA1617: Void return value should not be documented -dotnet_diagnostic.SA1617.severity = none - -# SA1618: The documentation for type parameter is missing -dotnet_diagnostic.SA1618.severity = none - -# SA1619: The documentation for type parameter is missing -dotnet_diagnostic.SA1619.severity = none - -# SA1620: Generic type parameter documentation should match type parameters -dotnet_diagnostic.SA1620.severity = none - -# SA1621: Generic type parameter documentation should declare parameter name -dotnet_diagnostic.SA1621.severity = none - -# SA1622: Generic type parameter documentation should have text -dotnet_diagnostic.SA1622.severity = none - -# SA1623: Property documentation text -dotnet_diagnostic.SA1623.severity = none - -# SA1624: Because the property only contains a visible get accessor, the documentation summary text should begin with 'Gets' -dotnet_diagnostic.SA1624.severity = none - -# SA1625: Element documentation should not be copied and pasted -dotnet_diagnostic.SA1625.severity = none - -# SA1626: Single-line comments should not use documentation style slashes -dotnet_diagnostic.SA1626.severity = none - -# SA1627: The documentation text within the \'exception\' tag should not be empty -dotnet_diagnostic.SA1627.severity = none - -# SA1628: Documentation text should begin with a capital letter -dotnet_diagnostic.SA1628.severity = none - -# SA1629: Documentation text should end with a period -dotnet_diagnostic.SA1629.severity = none - -# SA1630: Documentation text should contain whitespace -dotnet_diagnostic.SA1630.severity = none - -# SA1631: Documentation should meet character percentage -dotnet_diagnostic.SA1631.severity = none - -# SA1632: Documentation text should meet minimum character length -dotnet_diagnostic.SA1632.severity = none - -# SA1633: File should have header -dotnet_diagnostic.SA1633.severity = none - -# SA1634: File header should show copyright -dotnet_diagnostic.SA1634.severity = none - -# SA1635: File header should have copyright text -dotnet_diagnostic.SA1635.severity = none - -# SA1636: File header copyright text should match -dotnet_diagnostic.SA1636.severity = none - -# SA1637: File header should contain file name -dotnet_diagnostic.SA1637.severity = none - -# SA1638: File header file name documentation should match file name -dotnet_diagnostic.SA1638.severity = none - -# SA1639: File header should have summary -dotnet_diagnostic.SA1639.severity = none - -# SA1640: File header should have valid company text -dotnet_diagnostic.SA1640.severity = none - -# SA1641: File header company name text should match -dotnet_diagnostic.SA1641.severity = none - -# SA1642: Constructor summary documentation should begin with standard text -dotnet_diagnostic.SA1642.severity = none - -# SA1643: Destructor summary documentation should begin with standard text -dotnet_diagnostic.SA1643.severity = none - -# SA1644: Documentation headers should not contain blank lines -dotnet_diagnostic.SA1644.severity = none - -# SA1645: Included documentation file does not exist -dotnet_diagnostic.SA1645.severity = none - -# SA1646: Included documentation XPath does not exist -dotnet_diagnostic.SA1646.severity = none - -# SA1647: Include node does not contain valid file and path -dotnet_diagnostic.SA1647.severity = none - -# SA1648: Inheritdoc should be used with inheriting class -dotnet_diagnostic.SA1648.severity = none - -# SA1649: File name should match first type name -dotnet_diagnostic.SA1649.severity = none - -# SA1650: Element documentation should be spelled correctly -dotnet_diagnostic.SA1650.severity = none - -# SA1651: Do not use placeholder elements -dotnet_diagnostic.SA1651.severity = none - -# SX1101: Do not prefix local calls with 'this.' -dotnet_diagnostic.SX1101.severity = none - -# SX1309: Field names should begin with underscore -dotnet_diagnostic.SX1309.severity = none - -# Static field names should begin with underscore -dotnet_diagnostic.SX1309S.severity = none - -# IDE0001: Simplify name -dotnet_diagnostic.IDE0001.severity = suggestion - -# IDE0002: Simplify member access -dotnet_diagnostic.IDE0002.severity = suggestion - -# IDE0003: Remove this or Me qualification -dotnet_diagnostic.IDE0003.severity = suggestion - -# IDE0004: Remove Unnecessary Cast -dotnet_diagnostic.IDE0004.severity = suggestion - -# IDE0005: Using directive is unnecessary. -dotnet_diagnostic.IDE0005.severity = suggestion - -# IDE0007: Use implicit type -dotnet_diagnostic.IDE0007.severity = silent - -# IDE0008: Use explicit type -dotnet_diagnostic.IDE0008.severity = suggestion - -# IDE0009: Add this or Me qualification -dotnet_diagnostic.IDE0009.severity = silent - -# IDE0010: Add missing cases -dotnet_diagnostic.IDE0010.severity = silent - -# IDE0011: Add braces -dotnet_diagnostic.IDE0011.severity = silent - -# IDE0016: Use 'throw' expression -dotnet_diagnostic.IDE0016.severity = silent - -# IDE0017: Simplify object initialization -dotnet_diagnostic.IDE0017.severity = suggestion - -# IDE0018: Inline variable declaration -dotnet_diagnostic.IDE0018.severity = suggestion - -# IDE0019: Use pattern matching to avoid as followed by a null check -dotnet_diagnostic.IDE0019.severity = suggestion - -# IDE0020: Use pattern matching to avoid is check followed by a cast (with variable) -dotnet_diagnostic.IDE0020.severity = warning - -# IDE0021: Use expression body for constructors -dotnet_diagnostic.IDE0021.severity = silent - -# IDE0022: Use expression body for methods -dotnet_diagnostic.IDE0022.severity = silent - -# IDE0023: Use expression body for operators -dotnet_diagnostic.IDE0023.severity = silent - -# IDE0024: Use expression body for operators -dotnet_diagnostic.IDE0024.severity = silent - -# IDE0025: Use expression body for properties -dotnet_diagnostic.IDE0025.severity = silent - -# IDE0026: Use expression body for indexers -dotnet_diagnostic.IDE0026.severity = silent - -# IDE0027: Use expression body for accessors -dotnet_diagnostic.IDE0027.severity = silent - -# IDE0028: Simplify collection initialization -dotnet_diagnostic.IDE0028.severity = suggestion - -# IDE0029: Use coalesce expression -dotnet_diagnostic.IDE0029.severity = warning - -# IDE0030: Use coalesce expression -dotnet_diagnostic.IDE0030.severity = warning - -# IDE0031: Use null propagation -dotnet_diagnostic.IDE0031.severity = warning - -# IDE0032: Use auto property -dotnet_diagnostic.IDE0032.severity = silent - -# IDE0033: Use explicitly provided tuple name -dotnet_diagnostic.IDE0033.severity = suggestion - -# IDE0034: Simplify 'default' expression -dotnet_diagnostic.IDE0034.severity = suggestion - -# IDE0035: Remove unreachable code -dotnet_diagnostic.IDE0035.severity = suggestion - -# IDE0036: Order modifiers -dotnet_diagnostic.IDE0036.severity = warning - -# IDE0037: Use inferred member name -dotnet_diagnostic.IDE0037.severity = silent - -# IDE0038: Use pattern matching to avoid is check followed by a cast (without variable) -dotnet_diagnostic.IDE0038.severity = suggestion - -# IDE0039: Use local function -dotnet_diagnostic.IDE0039.severity = suggestion - -# IDE0040: Add accessibility modifiers -dotnet_diagnostic.IDE0040.severity = suggestion - -# IDE0041: Use 'is null' check -dotnet_diagnostic.IDE0041.severity = warning - -# IDE0042: Deconstruct variable declaration -dotnet_diagnostic.IDE0042.severity = silent - -# IDE0043: Invalid format string -dotnet_diagnostic.IDE0043.severity = warning - -# IDE0044: Add readonly modifier -dotnet_diagnostic.IDE0044.severity = suggestion - -# IDE0045: Use conditional expression for assignment -dotnet_diagnostic.IDE0045.severity = suggestion - -# IDE0046: Use conditional expression for return -dotnet_diagnostic.IDE0046.severity = suggestion - -# IDE0047: Remove unnecessary parentheses -dotnet_diagnostic.IDE0047.severity = silent - -# IDE0048: Add parentheses for clarity -dotnet_diagnostic.IDE0048.severity = silent - -# IDE0049: Use language keywords instead of framework type names for type references -dotnet_diagnostic.IDE0049.severity = warning - -# IDE0051: Remove unused private members -dotnet_diagnostic.IDE0051.severity = suggestion - -# IDE0052: Remove unread private members -dotnet_diagnostic.IDE0052.severity = suggestion - -# IDE0053: Use expression body for lambdas -dotnet_diagnostic.IDE0053.severity = silent - -# IDE0054: Use compound assignment -dotnet_diagnostic.IDE0054.severity = warning - -# IDE0055: Fix formatting -dotnet_diagnostic.IDE0055.severity = suggestion - -# IDE0056: Use index operator -dotnet_diagnostic.IDE0056.severity = suggestion - -# IDE0057: Use range operator -dotnet_diagnostic.IDE0057.severity = suggestion - -# IDE0058: Expression value is never used -dotnet_diagnostic.IDE0058.severity = silent - -# IDE0059: Unnecessary assignment of a value -dotnet_diagnostic.IDE0059.severity = none # TODO: warning - -# IDE0060: Remove unused parameter -dotnet_diagnostic.IDE0060.severity = silent -dotnet_code_quality_unused_parameters = non_public - -# IDE0061: Use expression body for local functions -dotnet_diagnostic.IDE0061.severity = silent - -# IDE0062: Make local function 'static' -dotnet_diagnostic.IDE0062.severity = warning - -# IDE0063: Use simple 'using' statement -dotnet_diagnostic.IDE0063.severity = silent - -# IDE0064: Make readonly fields writable -dotnet_diagnostic.IDE0064.severity = silent - -# IDE0065: Misplaced using directive -dotnet_diagnostic.IDE0065.severity = warning - -# IDE0066: Convert switch statement to expression -dotnet_diagnostic.IDE0066.severity = suggestion - -# IDE0070: Use 'System.HashCode' -dotnet_diagnostic.IDE0070.severity = suggestion - -# IDE0071: Simplify interpolation -dotnet_diagnostic.IDE0071.severity = warning - -# IDE0072: Add missing cases -dotnet_diagnostic.IDE0072.severity = silent - -# IDE0073: The file header is missing or not located at the top of the file -dotnet_diagnostic.IDE0073.severity = warning - -# IDE0074: Use compound assignment -dotnet_diagnostic.IDE0074.severity = warning - -# IDE0075: Simplify conditional expression -dotnet_diagnostic.IDE0075.severity = silent - -# IDE0076: Invalid global 'SuppressMessageAttribute' -dotnet_diagnostic.IDE0076.severity = warning - -# IDE0077: Avoid legacy format target in 'SuppressMessageAttribute' -dotnet_diagnostic.IDE0077.severity = silent - -# IDE0078: Use pattern matching -dotnet_diagnostic.IDE0078.severity = suggestion - -# IDE0079: Remove unnecessary suppression -dotnet_diagnostic.IDE0079.severity = suggestion - -# IDE0080: Remove unnecessary suppression operator -dotnet_diagnostic.IDE0080.severity = warning - -# IDE0081: Remove unnecessary suppression operator -dotnet_diagnostic.IDE0081.severity = none - -# IDE0082: 'typeof' can be converted to 'nameof' -dotnet_diagnostic.IDE0082.severity = warning - -# IDE0083: Use pattern matching -dotnet_diagnostic.IDE0083.severity = silent - -# IDE0084: Use pattern matching (IsNot operator) -dotnet_diagnostic.IDE0084.severity = none - -# IDE0090: Use 'new(...)' -dotnet_diagnostic.IDE0090.severity = silent - -# IDE0100: Remove redundant equality -dotnet_diagnostic.IDE0100.severity = warning - -# IDE0110: Remove unnecessary discard -dotnet_diagnostic.IDE0110.severity = warning - -# IDE0120: Simplify LINQ expression -dotnet_diagnostic.IDE0120.severity = none - -# IDE0130: Namespace does not match folder structure -dotnet_diagnostic.IDE0130.severity = silent - -# IDE0140: Simplify object creation -dotnet_diagnostic.IDE0140.severity = none - -# IDE0150: Prefer 'null' check over type check -dotnet_diagnostic.IDE0150.severity = silent - -# IDE0160: Convert to block scoped namespace -dotnet_diagnostic.IDE0160.severity = silent - -# IDE0161: Convert to file-scoped namespace -dotnet_diagnostic.IDE0161.severity = silent - -# IDE0170: Simplify property pattern -dotnet_diagnostic.IDE0170.severity = warning - -# IDE0180: Use tuple swap -dotnet_diagnostic.IDE0180.severity = suggestion - -# IDE0200: Remove unnecessary lambda expression -dotnet_diagnostic.IDE0200.severity = warning - -# IDE0210: Use top-level statements -dotnet_diagnostic.IDE0210.severity = silent - -# IDE0211: Use program main -dotnet_diagnostic.IDE0211.severity = silent - -# IDE0220: foreach cast -dotnet_diagnostic.IDE0220.severity = silent - -# IDE0230: Use UTF8 string literal -dotnet_diagnostic.IDE0230.severity = suggestion - -# IDE1005: Delegate invocation can be simplified. -dotnet_diagnostic.IDE1005.severity = warning - -# IDE1006: Naming styles -dotnet_diagnostic.IDE1006.severity = silent - -# IDE2000: Allow multiple blank lines -dotnet_diagnostic.IDE2000.severity = silent - -# IDE2001: Embedded statements must be on their own line -dotnet_diagnostic.IDE2001.severity = silent - -# IDE2002: Consecutive braces must not have blank line between them -dotnet_diagnostic.IDE2002.severity = silent - -# IDE2003: Allow statement immediately after block -dotnet_diagnostic.IDE2003.severity = silent - -# IDE2004: Blank line not allowed after constructor initializer colon -dotnet_diagnostic.IDE2004.severity = silent - -# CSIsNull001 to catch uses of == null -dotnet_diagnostic.CSIsNull001.severity = warning - -# CSIsNull002 to catch uses of != null -dotnet_diagnostic.CSIsNull002.severity = warning \ No newline at end of file diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/.editorconfig b/src/Microsoft.DotNet.Wpf/cycle-breakers/.editorconfig new file mode 100644 index 00000000000..58c105528bb --- /dev/null +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/.editorconfig @@ -0,0 +1,39 @@ +# editorconfig.org + +# This file contains temporary overrides for higher level .editorconfig rules. +# For cycle-breakers matching most rules is not as critical. Overrides that +# should NOT be re-enabled are marked as "none". Ones that can be fixed and +# removed are marked as "suggestion". + +# C# and VB files +[*.{cs,vb}] + +# CA1066: Implement IEquatable when overriding Object.Equals +dotnet_diagnostic.CA1066.severity = none + +# CA1725: Parameter names should match base declaration +dotnet_diagnostic.CA1725.severity = none + +# CA1822: Mark members as static +dotnet_diagnostic.CA1822.severity = none + +# CA1823: Avoid unused private fields +dotnet_diagnostic.CA1823.severity = none + +# IDE0034: Simplify 'default' expression +dotnet_diagnostic.IDE0034.severity = suggestion + +# IDE0036: Order modifiers +dotnet_diagnostic.IDE0036.severity = suggestion + +# IDE0044: Add readonly modifier +dotnet_diagnostic.IDE0044.severity = none + +# IDE0051: Remove unused private members +dotnet_diagnostic.IDE0051.severity = none + +# IDE0251: Make member 'readonly' +dotnet_diagnostic.IDE0251.severity = none + +# IDE1006: Naming Styles +dotnet_diagnostic.IDE1006.severity = suggestion diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-PresentationUI-api-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-PresentationUI-api-cycle.csproj index 2e3b8e3cde4..20cd6ca5691 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-PresentationUI-api-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-PresentationUI-api-cycle.csproj @@ -7,6 +7,7 @@ false true AnyCPU + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-ReachFramework-impl-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-ReachFramework-impl-cycle.csproj index 7e5f89fb274..f64d8db6240 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-ReachFramework-impl-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-ReachFramework-impl-cycle.csproj @@ -10,6 +10,7 @@ None $(NoWarn);0169 + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-api-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-api-cycle.csproj index b63356a15d3..1535dafaafb 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-api-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-api-cycle.csproj @@ -8,6 +8,7 @@ true AnyCPU None + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-impl-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-impl-cycle.csproj index 8bbacd20753..e22d16e5b9e 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-impl-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework-System.Printing-impl-cycle.csproj @@ -10,6 +10,7 @@ None $(NoWarn);0169 + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs index 62548f80e12..cc873925aaf 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.DocumentViewer.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.DocumentViewer.cs index 8ad74b19761..fff31a2b7b1 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.DocumentViewer.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.DocumentViewer.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRange.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRange.cs index a89cc61cc21..ec8b08d833f 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRange.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRange.cs @@ -1,13 +1,13 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ -namespace System.Windows.Controls +namespace System.Windows.Controls { public partial struct PageRange { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRangeSelection.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRangeSelection.cs index ab7bf05e2b4..aed7ad5f38b 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRangeSelection.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.PageRangeSelection.cs @@ -1,11 +1,11 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ -namespace System.Windows.Controls +namespace System.Windows.Controls { public enum PageRangeSelection { @@ -14,4 +14,4 @@ public enum PageRangeSelection SelectedPages = 3, UserPages = 1, } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.ToolBar.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.ToolBar.cs index dd8c1aaa0e9..7c4f82ae991 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.ToolBar.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Controls.ToolBar.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocument.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocument.cs index 037f874104d..1046b53f379 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocument.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocument.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -8,6 +8,6 @@ namespace System.Windows.Documents { public sealed partial class FixedDocument - { + { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocumentSequence.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocumentSequence.cs index dabdd8a464d..906c7891948 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocumentSequence.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedDocumentSequence.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -8,6 +8,6 @@ namespace System.Windows.Documents { public partial class FixedDocumentSequence - { + { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedPage.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedPage.cs index 267c8bfa479..15b86cda43f 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedPage.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.FixedPage.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -8,6 +8,6 @@ namespace System.Windows.Documents { public sealed partial class FixedPage - { + { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.Delegates.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.Delegates.cs index dae5d8a865f..88c71eae2e0 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.Delegates.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.Delegates.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -45,4 +45,4 @@ public WritingPrintTicketRequiredEventArgs(System.Windows.Xps.Serialization.Prin public System.Windows.Xps.Serialization.PrintTicketLevel CurrentPrintTicketLevel { get { throw null; } } public int Sequence { get { throw null; } } } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriter.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriter.cs index 136303f63fb..039c7191f43 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriter.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriter.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -48,4 +48,4 @@ protected SerializerWriter() { } public abstract void WriteAsync(System.Windows.Media.Visual visual, System.Printing.PrintTicket printTicket); public abstract void WriteAsync(System.Windows.Media.Visual visual, System.Printing.PrintTicket printTicket, object userState); } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriterCollator.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriterCollator.cs index f4e1ca1c7d8..39b74c8c7a6 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriterCollator.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/System.Windows.Documents.Serialization.SerializerWriterCollator.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -21,4 +21,4 @@ protected SerializerWriterCollator() { } public abstract void WriteAsync(System.Windows.Media.Visual visual, System.Printing.PrintTicket printTicket); public abstract void WriteAsync(System.Windows.Media.Visual visual, System.Printing.PrintTicket printTicket, object userState); } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI-PresentationFramework-impl-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI-PresentationFramework-impl-cycle.csproj index 6d67efac6ba..1e42869325a 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI-PresentationFramework-impl-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI-PresentationFramework-impl-cycle.csproj @@ -9,6 +9,7 @@ None $(NoWarn);0169 + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.cs index 896e8700f93..3aa710e2efc 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -13,4 +13,4 @@ namespace System.Windows.Documents /// public static class PresentationUIStyleResources { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.internals.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.internals.cs index b90f2d61058..d8297dff6c0 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.internals.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationUI/PresentationUI.internals.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-PresentationFramework-api-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-PresentationFramework-api-cycle.csproj index 433665f2d4f..7b2a88912a8 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-PresentationFramework-api-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-PresentationFramework-api-cycle.csproj @@ -7,6 +7,7 @@ false AnyCPU + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-System.Printing-api-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-System.Printing-api-cycle.csproj index f16bbaeff4b..9a2fa06726f 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-System.Printing-api-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/ReachFramework-System.Printing-api-cycle.csproj @@ -7,6 +7,7 @@ false AnyCPU + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintCapabilities.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintCapabilities.cs index 235104aef72..b7728caedd7 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintCapabilities.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintCapabilities.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -10,4 +10,4 @@ namespace System.Printing public sealed partial class PrintCapabilities { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicket.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicket.cs index cfbf4cfd025..cfa66eda4dd 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicket.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicket.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -11,4 +11,4 @@ public sealed partial class PrintTicket { private PrintTicket() {} } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicketScope.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicketScope.cs index 49c7962a53f..4af6e1c3aec 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicketScope.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.PrintTicketScope.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -10,4 +10,4 @@ namespace System.Printing public enum PrintTicketScope { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.ValidationResult.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.ValidationResult.cs index 8cf3b5172d7..954ab0e6cea 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.ValidationResult.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Printing.ValidationResult.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -10,4 +10,4 @@ namespace System.Printing public partial struct ValidationResult { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.PackagingProgressEventArgs.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.PackagingProgressEventArgs.cs index eaf254973e1..c2f78c2ef5d 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.PackagingProgressEventArgs.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.PackagingProgressEventArgs.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -11,4 +11,4 @@ public partial class PackagingProgressEventArgs { private PackagingProgressEventArgs() {} } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.XpsDocument.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.XpsDocument.cs index 277c90cec64..e24ff9e4f57 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.XpsDocument.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Packaging.XpsDocument.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -10,4 +10,4 @@ namespace System.Windows.Xps.Packaging public partial class XpsDocument { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.PrintTicketLevel.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.PrintTicketLevel.cs index e7212c996bc..3d6115b8ba3 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.PrintTicketLevel.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.PrintTicketLevel.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -10,4 +10,4 @@ namespace System.Windows.Xps.Serialization public enum PrintTicketLevel { } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.RCW.IXpsOMPackageWriter.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.RCW.IXpsOMPackageWriter.cs index 7f53b608d61..5b56a30a26f 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.RCW.IXpsOMPackageWriter.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/ReachFramework/System.Windows.Xps.Serialization.RCW.IXpsOMPackageWriter.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -14,4 +14,4 @@ internal partial interface IXpsOMPackageWriter { // INTENTIONALLY empty to avoid exposing the entire type closure to reference assemblies } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing-PresentationFramework-api-cycle.csproj b/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing-PresentationFramework-api-cycle.csproj index 0eaeac98003..a081fb50062 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing-PresentationFramework-api-cycle.csproj +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing-PresentationFramework-api-cycle.csproj @@ -7,6 +7,7 @@ false x86;x64;arm64 + true diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing.PrintQueue.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing.PrintQueue.cs index 567d8ad8855..8faf60e2e7f 100644 --- a/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing.PrintQueue.cs +++ b/src/Microsoft.DotNet.Wpf/cycle-breakers/System.Printing/System.Printing.PrintQueue.cs @@ -1,6 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. + // ------------------------------------------------------------------------------ // Changes to this file must follow the http://aka.ms/api-review process. // ------------------------------------------------------------------------------ @@ -9,8 +9,8 @@ namespace System.Printing { public class PrintQueue { - private PrintQueue() - { + private PrintQueue() + { } } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/src/.editorconfig b/src/Microsoft.DotNet.Wpf/src/.editorconfig new file mode 100644 index 00000000000..597fadf387e --- /dev/null +++ b/src/Microsoft.DotNet.Wpf/src/.editorconfig @@ -0,0 +1,345 @@ +# editorconfig.org + +# This file contains temporary overrides for higher level .editorconfig rules. +# These need removed as particular rules get fixed. Marking as suggestion so +# codefixes and defaults are still available. + +# C# and VB files +[*.{cs,vb}] + +dotnet_style_prefer_collection_expression = when_types_exactly_match:suggestion +csharp_prefer_system_threading_lock = true:suggestion +csharp_style_pattern_matching_over_as_with_null_check = true:suggestion + +# NOTE: If existing public API, CA1036 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1036: Override methods on comparable types +dotnet_diagnostic.CA1036.severity = suggestion + +# CA1052: Static holder types should be Static or NotInheritable +dotnet_diagnostic.CA1052.severity = suggestion + +# NOTE: If existing public API, CA1066 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1066: Implement IEquatable when overriding Object.Equals +dotnet_diagnostic.CA1066.severity = suggestion + +# NOTE: If existing public API, CA1067 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1067: Override Object.Equals(object) when implementing IEquatable +dotnet_diagnostic.CA1067.severity = suggestion + +# NOTE: If existing public API, CA1070 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1070: Do not declare event fields as virtual +dotnet_diagnostic.CA1070.severity = suggestion + +# CA1310: Specify StringComparison for correctness +dotnet_diagnostic.CA1310.severity = suggestion + +# CA1419: Provide a parameterless constructor that is as visible as the containing type for concrete types derived from 'System.Runtime.InteropServices.SafeHandle' +dotnet_diagnostic.CA1419.severity = suggestion + +# CA1507: Use nameof in place of string +dotnet_diagnostic.CA1507.severity = suggestion + +# CA1510: Use ArgumentNullException throw helper +dotnet_diagnostic.CA1510.severity = suggestion + +# NOTE: If existing public API, CA2211 should be suppressed individually +# in the GlobalSuppressions file. + +# CA2211: Non-constant fields should not be visible +dotnet_diagnostic.CA2211.severity = suggestion + +# CA1512: Use ArgumentOutOfRangeException throw helper +dotnet_diagnostic.CA1512.severity = suggestion + +# CA1513: Use ObjectDisposedException throw helper +dotnet_diagnostic.CA1513.severity = suggestion + +# CA1514: Avoid redundant length argument +dotnet_diagnostic.CA1514.severity = suggestion + +# CA5394: Do not use insecure randomness +dotnet_diagnostic.CA5394.severity = suggestion + +# NOTE: If existing public API, CA1725 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1725: Parameter names should match base declaration +dotnet_diagnostic.CA1725.severity = suggestion + +# CA1802: Use literals where appropriate +dotnet_diagnostic.CA1802.severity = suggestion + +# CA1805: Do not initialize unnecessarily +dotnet_diagnostic.CA1805.severity = suggestion + +# CA1810: Initialize reference type static fields inline +dotnet_diagnostic.CA1810.severity = suggestion + +# NOTE: If existing public API, CA1815 should be suppressed individually +# in the GlobalSuppressions file. + +# CA1815: Override equals and operator equals on value types +dotnet_diagnostic.CA1815.severity = none + +# CA1822: Mark members as static +dotnet_diagnostic.CA1822.severity = suggestion + +# CA1823: Avoid unused private fields +dotnet_diagnostic.CA1823.severity = suggestion + +# CA1825: Avoid zero-length array allocations +dotnet_diagnostic.CA1825.severity = suggestion + +# CA1834: Use StringBuilder.Append(char) for single character strings +dotnet_diagnostic.CA1834.severity = suggestion + +# This will go away as part of porting to CsWin32 +# CA1838: Avoid StringBuilder parameters for P/Invokes +dotnet_diagnostic.CA1838.severity = suggestion + +# CA1845: Use span-based 'string.Concat' +dotnet_diagnostic.CA1845.severity = suggestion + +# CA1846: Prefer AsSpan over Substring +dotnet_diagnostic.CA1846.severity = suggestion + +# CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters +dotnet_diagnostic.CA1847.severity = suggestion + +# CA1851: Possible multiple enumerations of IEnumerable collection +dotnet_diagnostic.CA1851.severity = suggestion + +# CA1852: Seal internal types +dotnet_diagnostic.CA1852.severity = suggestion + +# CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)' +dotnet_diagnostic.CA1853.severity = suggestion + +# CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method +dotnet_diagnostic.CA1854.severity = suggestion + +# CA1858: Use StartsWith instead of IndexOf +dotnet_diagnostic.CA1858.severity = suggestion + +# CA1859: Use concrete types when possible for improved performance +dotnet_diagnostic.CA1859.severity = suggestion + +# CA2011: Do not assign property within its setter +dotnet_diagnostic.CA2011.severity = suggestion + +# CA2019: ThreadStatic fields should not use inline initialization +dotnet_diagnostic.CA2019.severity = suggestion + +# Should change all internal IntPtr/UIntPtr to nint/uint. IntPtr/UIntPtr no +# longer do checked operations so they are now equivalent. +# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr +dotnet_diagnostic.CA2020.severity = suggestion + +# NOTE: If thrown externally, CA2201 should be suppressed individually +# in the GlobalSuppressions file. + +# CA2201: Do not raise reserved exception types +dotnet_diagnostic.CA2201.severity = suggestion + +# CA2207: Initialize value type static fields inline +dotnet_diagnostic.CA2207.severity = suggestion + +# CA2208: Instantiate argument exceptions correctly +dotnet_diagnostic.CA2208.severity = suggestion + +# CA2219: Do not raise exceptions in finally clauses +dotnet_diagnostic.CA2219.severity = suggestion + +# CA2242: Test for NaN correctly +dotnet_diagnostic.CA2242.severity = suggestion + +# CA2249: Consider using 'string.Contains' instead of 'string.IndexOf' +dotnet_diagnostic.CA2249.severity = suggestion + +# CA2251: Use String.Equals over String.Compare +dotnet_diagnostic.CA2251.severity = suggestion + +# CA2300: Do not use insecure deserializer BinaryFormatter +dotnet_diagnostic.CA2300.severity = suggestion + +# CA2302: Ensure BinaryFormatter.Binder is set before calling BinaryFormatter.Deserialize +dotnet_diagnostic.CA2302.severity = suggestion + +# CA5350: Do Not Use Weak Cryptographic Algorithms +dotnet_diagnostic.CA5350.severity = suggestion + +# CA5351: Do Not Use Broken Cryptographic Algorithms +dotnet_diagnostic.CA5351.severity = suggestion + +# CA5362: Potential reference cycle in deserialized object graph +dotnet_diagnostic.CA5362.severity = suggestion + +# CSIsNull001: Use 'is' pattern check +dotnet_diagnostic.CSIsNull001.severity = suggestion + +# CSIsNull002: Use 'is not' pattern check +dotnet_diagnostic.CSIsNull002.severity = suggestion + +# IDE0005: Using directive is unnecessary. +dotnet_diagnostic.IDE0005.severity = suggestion + +# IDE0017: Simplify object initialization +dotnet_diagnostic.IDE0017.severity = suggestion + +# IDE0019: Use pattern matching to avoid as followed by a null check +dotnet_diagnostic.IDE0019.severity = suggestion + +# IDE0020: Use pattern matching to avoid is check followed by a cast (with variable) +dotnet_diagnostic.IDE0020.severity = suggestion + +# IDE0029: Use coalesce expression +dotnet_diagnostic.IDE0029.severity = suggestion + +# IDE0030: Null check can be simplified +dotnet_diagnostic.IDE0030.severity = suggestion + +# IDE0031: Use null propagation +dotnet_diagnostic.IDE0031.severity = suggestion + +# IDE0034: Simplify 'default' expression +dotnet_diagnostic.IDE0034.severity = suggestion + +# IDE0036: Order modifiers +dotnet_diagnostic.IDE0036.severity = suggestion + +# IDE0040: Add accessibility modifiers +dotnet_diagnostic.IDE0040.severity = suggestion + +# IDE0041: Use 'is null' check +dotnet_diagnostic.IDE0041.severity = suggestion + +# IDE0044: Add readonly modifier +dotnet_diagnostic.IDE0044.severity = suggestion + +# IDE0051: Remove unused private members +dotnet_diagnostic.IDE0051.severity = suggestion + +# IDE0052: Remove unread private members +dotnet_diagnostic.IDE0052.severity = suggestion + +# IDE0057: Use range operator +dotnet_diagnostic.IDE0057.severity = suggestion + +# IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0060.severity = suggestion + +# IDE0062: Make local function 'static' +dotnet_diagnostic.IDE0062.severity = suggestion + +# IDE0063: Use simple 'using' statement +dotnet_diagnostic.IDE0063.severity = suggestion + +# IDE0065: Misplaced using directive +dotnet_diagnostic.IDE0065.severity = suggestion + +# IDE0066: Convert switch statement to expression +dotnet_diagnostic.IDE0066.severity = suggestion + +# IDE0073: The file header is missing or not located at the top of the file +dotnet_diagnostic.IDE0073.severity = suggestion + +# IDE0074: Use compound assignment +dotnet_diagnostic.IDE0074.severity = suggestion + +# IDE0075: Simplify conditional expression +dotnet_diagnostic.IDE0075.severity = suggestion + +# IDE0076: Invalid global 'SuppressMessageAttribute' +dotnet_diagnostic.IDE0076.severity = suggestion + +# IDE0077: Avoid legacy global suppression format +dotnet_diagnostic.IDE0077.severity = suggestion + +# IDE0078: Use pattern matching +dotnet_diagnostic.IDE0078.severity = suggestion + +# IDE0082: 'typeof' can be converted to 'nameof' +dotnet_diagnostic.IDE0082.severity = suggestion + +# IDE0100: Remove redundant equality +dotnet_diagnostic.IDE0100.severity = suggestion + +# IDE0150: Prefer 'null' check over type check +dotnet_diagnostic.IDE0150.severity = suggestion + +# IDE0180: Use tuple to swap values +dotnet_diagnostic.IDE0180.severity = suggestion + +# IDE0251: Make member 'readonly' +dotnet_diagnostic.IDE0251.severity = suggestion + +# IDE0270: Use coalesce expression +dotnet_diagnostic.IDE0270.severity = suggestion + +# IDE0300: Simplify collection initialization +dotnet_diagnostic.IDE0300.severity = suggestion + +# NOTE: For thread statics (t_), IDE1006 should be suppressed individually +# in the GlobalSuppressions file. + +# IDE1006: Naming Styles +dotnet_diagnostic.IDE1006.severity = suggestion + +# SA1001: Commas should not be preceded by whitespace +dotnet_diagnostic.SA1001.severity = suggestion + +# SA1005: Single line comment should begin with a space +dotnet_diagnostic.SA1005.severity = suggestion + +# SA1014: Opening generic brackets should not be preceded by a space +dotnet_diagnostic.SA1014.severity = suggestion + +# SA1027: Tabs and spaces should be used correctly +dotnet_diagnostic.SA1027.severity = suggestion + +# SA1028: Code should not contain trailing whitespace +dotnet_diagnostic.SA1028.severity = suggestion + +# SA1121: Use built-in type alias +dotnet_diagnostic.SA1121.severity = suggestion + +# SA1129: Do not use default value type constructor +dotnet_diagnostic.SA1129.severity = suggestion + +# SA1131: Constant values should appear on the right-hand side of comparisons +dotnet_diagnostic.SA1131.severity = suggestion + +# SA1400: Member should declare an access modifier +dotnet_diagnostic.SA1400.severity = suggestion + +# SA1408: Conditional expressions should declare precedence +dotnet_diagnostic.SA1408.severity = suggestion + +# SA1500: Braces for multi-line statements should not share line +dotnet_diagnostic.SA1500.severity = suggestion + +# SA1505: An opening brace should not be followed by a blank line +dotnet_diagnostic.SA1505.severity = suggestion + +# SA1507: Code should not contain multiple blank lines in a row +dotnet_diagnostic.SA1507.severity = suggestion + +# SA1508: A closing brace should not be preceded by a blank line +dotnet_diagnostic.SA1508.severity = suggestion + +# SA1513: Closing brace should be followed by blank line +dotnet_diagnostic.SA1513.severity = suggestion + +# SA1518: Code should not contain blank lines at the end of the file +dotnet_diagnostic.SA1518.severity = suggestion + +# SYSLIB1045: Convert to 'GeneratedRegexAttribute'. +dotnet_diagnostic.SYSLIB1045.severity = suggestion \ No newline at end of file diff --git a/src/Microsoft.DotNet.Wpf/src/Shared/RefAssemblyAttrs.cs b/src/Microsoft.DotNet.Wpf/src/Shared/RefAssemblyAttrs.cs index acc0c81ed76..d431f7e94f1 100644 --- a/src/Microsoft.DotNet.Wpf/src/Shared/RefAssemblyAttrs.cs +++ b/src/Microsoft.DotNet.Wpf/src/Shared/RefAssemblyAttrs.cs @@ -1,6 +1,5 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. // The C++ version of these definitions is in inc\BuildInfo.hxx. diff --git a/src/Microsoft.DotNet.Wpf/src/System.Windows.Primitives/System.Windows.Primitives.csproj b/src/Microsoft.DotNet.Wpf/src/System.Windows.Primitives/System.Windows.Primitives.csproj index 5916d80d27f..04d26172aab 100644 --- a/src/Microsoft.DotNet.Wpf/src/System.Windows.Primitives/System.Windows.Primitives.csproj +++ b/src/Microsoft.DotNet.Wpf/src/System.Windows.Primitives/System.Windows.Primitives.csproj @@ -19,6 +19,7 @@ true $(DefaultItemExcludes);ref\** + true diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormatWriterTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormatWriterTests.cs index 1965b78edbd..a1f787d4434 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormatWriterTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormatWriterTests.cs @@ -2,9 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Collections; -using System.Collections.Generic; using System.Runtime.Serialization.Formatters.Binary; -using PresentationCore.Tests.TestUtilities; using PresentationCore.Tests.FluentAssertions; using System.Formats.Nrbf; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormattedTypes.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormattedTypes.cs index 4ecf9d26280..84674112bd1 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormattedTypes.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/BinaryFormattedTypes.cs @@ -3,10 +3,7 @@ using System.Collections; using System.ComponentModel; -using System.Drawing; using System.Runtime.Serialization; -using PresentationCore.Tests.TestUtilities; -using PresentationCore.Tests.FluentAssertions; namespace PresentationCore.Tests.BinaryFormat; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/CountTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/CountTests.cs index c6b5f2667b2..3aa9093f43c 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/CountTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/CountTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using PresentationCore.Tests.TestUtilities; using PresentationCore.Tests.FluentAssertions; namespace PresentationCore.Tests.BinaryFormat; @@ -32,4 +31,4 @@ public void CountToStringIsInt() { ((Count)5).ToString().Should().Be("5"); } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/DataObjectTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/DataObjectTests.cs index 00936d38443..099ed1ccf34 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/DataObjectTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/DataObjectTests.cs @@ -1,13 +1,6 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using PresentationCore.Tests.TestUtilities; -using PresentationCore.Tests.FluentAssertions; -using System.Formats.Nrbf; -using System.Drawing; -using System.Windows; -using System.Threading; - namespace PresentationCore.Tests.BinaryFormat; public class DataObjectTests diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/HashTableTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/HashTableTests.cs index 5113c08be0b..a636a6b93e4 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/HashTableTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/HashTableTests.cs @@ -2,8 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Collections; -using System.Collections.Generic; -using System.Drawing; using System.Formats.Nrbf; using System.Runtime.Serialization; using System.Runtime.Serialization.Formatters.Binary; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/ListTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/ListTests.cs index e8fa948b6b9..1363742228f 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/ListTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/ListTests.cs @@ -2,11 +2,7 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Collections; -using System.Drawing; using System.Runtime.Serialization.Formatters.Binary; -using System.Collections.Generic; -using System.Windows; -using FluentAssertions; using PresentationCore.Tests.TestUtilities; using PresentationCore.Tests.FluentAssertions; using System.Formats.Nrbf; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/NullTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/NullTests.cs index f5ec5d47bf4..0c29ba267c5 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/NullTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/NullTests.cs @@ -1,8 +1,6 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using PresentationCore.Tests.TestUtilities; - namespace PresentationCore.Tests.BinaryFormat; public class NullTests diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/PrimitiveTypeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/PrimitiveTypeTests.cs index da83b1c030f..845ccecb40a 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/PrimitiveTypeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/PrimitiveTypeTests.cs @@ -3,11 +3,6 @@ using System.Runtime.Serialization.Formatters.Binary; using System.Text; -using System.Collections.Generic; -using System.Windows; -using FluentAssertions; -using System.IO; -using PresentationCore.Tests.TestUtilities; using System.Globalization; using System.Runtime.Serialization; using System.Runtime.CompilerServices; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/StringRecordsCollectionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/StringRecordsCollectionTests.cs index 2adcd0b2d12..f51ec8fd7d9 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/StringRecordsCollectionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/StringRecordsCollectionTests.cs @@ -1,8 +1,6 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using PresentationCore.Tests.TestUtilities; - namespace PresentationCore.Tests.BinaryFormat; public class StringRecordsCollectionTests diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/SystemDrawingTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/SystemDrawingTests.cs index 7ef30fc027a..4bc265b10c6 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/SystemDrawingTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/BinaryFormat/SystemDrawingTests.cs @@ -1,9 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System.Drawing; using PresentationCore.Tests.TestUtilities; -using PresentationCore.Tests.FluentAssertions; using System.Formats.Nrbf; namespace PresentationCore.Tests.BinaryFormat; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/ComparisonHelpers.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/ComparisonHelpers.cs index 47955be03af..f2dbf8cdea8 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/ComparisonHelpers.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/ComparisonHelpers.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Numerics; -using System; namespace PresentationCore.Tests.FluentAssertions; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/FluentAssertExtensions.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/FluentAssertExtensions.cs index 3c816c75e25..f9d4a7d3a9d 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/FluentAssertExtensions.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/FluentAssertExtensions.cs @@ -1,13 +1,10 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System.Drawing; -using FluentAssertions; using FluentAssertions.Collections; -using System.Collections.Generic; using FluentAssertions.Numeric; -namespace PresentationCore.Tests.FluentAssertions; +namespace PresentationCore.Tests.FluentAssertions; public static class FluentAssertExtensions { diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/PointFAssertions.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/PointFAssertions.cs index 8281fbd0a8b..f1fb2fdc01b 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/PointFAssertions.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/PointFAssertions.cs @@ -1,8 +1,6 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System.Drawing; - namespace PresentationCore.Tests.FluentAssertions; public class PointFAssertions(PointF value) diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/RectangleFAssertions.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/RectangleFAssertions.cs index 821f287d3f5..9f2dfb56392 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/RectangleFAssertions.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/FluentAssertions/RectangleFAssertions.cs @@ -1,8 +1,6 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System.Drawing; - namespace PresentationCore.Tests.FluentAssertions; public class RectangleFAssertions(RectangleF value) { diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj index 1fdde532919..22b66899765 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj @@ -9,6 +9,7 @@ true $(NoWarn);SYSLIB5005 + true diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatTestExtensions.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatTestExtensions.cs index 06ff94533e3..00c66d90dd4 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatTestExtensions.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatTestExtensions.cs @@ -1,12 +1,9 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -using System; -using System.IO; using System.ComponentModel; using System.Runtime.Serialization; using System.Runtime.Serialization.Formatters.Binary; -using System.Windows; using System.Formats.Nrbf; namespace PresentationCore.Tests.TestUtilities; @@ -14,7 +11,7 @@ namespace PresentationCore.Tests.TestUtilities; internal static class BinaryFormatTestExtensions { /// - /// Serializes the object using the and reads it into a . + /// Serializes the object using the and reads it into a . /// public static SerializationRecord SerializeAndParse(this object source) => NrbfDecoder.Decode(source.Serialize()); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatterScope.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatterScope.cs index d0d2397e037..3c73e69c7cf 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatterScope.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/TestUtilities/BinaryFormatterScope.cs @@ -2,7 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. using System.Runtime.Serialization.Formatters.Binary; -using System.Threading; namespace System; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System.Xaml.Tests.csproj b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System.Xaml.Tests.csproj index 8833b8dae2f..3a7a273d4c9 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System.Xaml.Tests.csproj +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System.Xaml.Tests.csproj @@ -6,6 +6,7 @@ true enable x64;x86;arm64 + true diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/AcceptedMarkupExtensionExpressionTypeAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/AcceptedMarkupExtensionExpressionTypeAttributeTests.cs index 8ab21ac7cb8..4b6076b169a 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/AcceptedMarkupExtensionExpressionTypeAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/AcceptedMarkupExtensionExpressionTypeAttributeTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using Xunit; #pragma warning disable 0618 @@ -14,7 +12,7 @@ public class AcceptedMarkupExtensionExpressionTypeAttributeTests [Theory] [InlineData(null)] [InlineData(typeof(int))] - public void Ctor_Type(Type type) + public void Ctor_Type(Type? type) { var attribute = new AcceptedMarkupExtensionExpressionTypeAttribute(type); Assert.Equal(type, attribute.Type); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ArrayExtensionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ArrayExtensionTests.cs index be8bb1a5ffa..2cc2a9d3a9a 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ArrayExtensionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ArrayExtensionTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using System.Collections; using System.Collections.Generic; using Xunit; @@ -39,9 +38,9 @@ public void Ctor_NullType_ThrowsArgumentNullException() public static IEnumerable Ctor_Array_TestData() { - yield return new object[] { new object[0], typeof(object) }; + yield return new object[] { Array.Empty(), typeof(object) }; yield return new object[] { new object[1], typeof(object) }; - yield return new object[] { new int[0], typeof(int) }; + yield return new object[] { Array.Empty(), typeof(int) }; yield return new object[] { new int[] { 1, 2, 3, 4, 5, 6 }, typeof(int) }; yield return new object[] { new int[0, 0], typeof(int) }; yield return new object[] { new int[0, 1], typeof(int) }; @@ -75,7 +74,7 @@ public void Ctor_MultdimensionalArray_ThrowsRankException() [InlineData(null)] [InlineData("string")] [InlineData(1)] - public void AddChild_Invoke_AddsToItems(object value) + public void AddChild_Invoke_AddsToItems(object? value) { var extension = new ArrayExtension(); extension.AddChild(value); @@ -86,7 +85,7 @@ public void AddChild_Invoke_AddsToItems(object value) [InlineData(null)] [InlineData("")] [InlineData("string")] - public void AddText_Invoke_AddsToItems(string text) + public void AddText_Invoke_AddsToItems(string? text) { var extension = new ArrayExtension(); extension.AddText(text); @@ -120,12 +119,14 @@ public void ProvideValue_InvalidArrayType_ThrowsInvalidOperationException() [Theory] [InlineData(null)] [InlineData(typeof(int))] - public void Type_Set_GetReturnsExpected(Type value) + public void Type_Set_GetReturnsExpected(Type? value) { - var extension = new ArrayExtension(); + ArrayExtension extension = new() + { + // Set. + Type = value + }; - // Set. - extension.Type = value; Assert.Equal(value, extension.Type); // Set same. diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ConstructorArgumentAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ConstructorArgumentAttributeTests.cs index 1765acd798a..547e483d5e3 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ConstructorArgumentAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ConstructorArgumentAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests @@ -12,7 +11,7 @@ public class ConstructorArgumentAttributeTests [InlineData(null)] [InlineData("")] [InlineData("argumentName")] - public void Ctor_String(string argumentName) + public void Ctor_String(string? argumentName) { var attribute = new ConstructorArgumentAttribute(argumentName); Assert.Equal(argumentName, attribute.ArgumentName); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentPropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentPropertyAttributeTests.cs index bdca3ecf46d..184fac8a199 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentPropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentPropertyAttributeTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using Xunit; namespace System.Windows.Markup.Tests; @@ -20,7 +18,7 @@ public void Ctor_Default() [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new ContentPropertyAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentWrapperAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentWrapperAttributeTests.cs index 9cb988042c5..0dd9b21a955 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentWrapperAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ContentWrapperAttributeTests.cs @@ -1,6 +1,5 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using System.Collections.Generic; using Xunit; @@ -43,7 +42,7 @@ public void Equals_Invoke_ReturnsExpected(ContentWrapperAttribute attribute, obj public void GetHashCode_Invoke_ReturnsExpected() { var attribute = new ContentWrapperAttribute(typeof(int)); - Assert.Equal(typeof(int).GetHashCode(), attribute.GetHashCode()); + Assert.Equal(typeof(int).GetHashCode(), attribute.GetHashCode()); } [Fact] diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DateTimeValueSerializerTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DateTimeValueSerializerTests.cs index 6d7f8cc2ccf..7b4e4d5d955 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DateTimeValueSerializerTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DateTimeValueSerializerTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using System.Collections.Generic; using System.Globalization; using Xunit; @@ -10,16 +9,16 @@ namespace System.Windows.Markup.Tests; public class DateTimeValueSerializerTests { - public static IEnumerable CanConvertFrom_TestData() + public static IEnumerable CanConvertFrom_TestData() { - yield return new object[] { new DateTime(), true }; - yield return new object[] { new object(), false }; - yield return new object[] { null, false }; + yield return new object?[] { new DateTime(), true }; + yield return new object?[] { new object(), false }; + yield return new object?[] { null, false }; } [Theory] [MemberData(nameof(CanConvertFrom_TestData))] - public void CanConvertToString_Invoke_ReturnsFalse(object value, bool expected) + public void CanConvertToString_Invoke_ReturnsFalse(object? value, bool expected) { var serializer = new DateTimeValueSerializer(); Assert.Equal(expected, serializer.CanConvertToString(value, null)); @@ -42,11 +41,11 @@ public void ConvertToString_DateTime_ReturnsExpected(DateTime date, string forma var serializer = new DateTimeValueSerializer(); Assert.Equal(date.ToString(format, CultureInfo.InvariantCulture), serializer.ConvertToString(date, null)); } - + [Theory] [InlineData("notDateTime")] [InlineData(null)] - public void ConvertToString_NotDateTime_ThrowsNotSupportedException(object value) + public void ConvertToString_NotDateTime_ThrowsNotSupportedException(object? value) { var serializer = new DateTimeValueSerializer(); Assert.Throws(() => serializer.ConvertToString(value, null)); @@ -81,6 +80,6 @@ public void ConvertFromString_String_ReturnsExpected(string value, DateTime expe public void ConvertFromString_NullString_ThrowsNotSupportedException() { var serializer = new DateTimeValueSerializer(); - Assert.Throws(() => serializer.ConvertFromString(null!, null)); + Assert.Throws(() => serializer.ConvertFromString(null!, null)); } } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DependsOnAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DependsOnAttributeTests.cs index eb559923353..87ce6675cb5 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DependsOnAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DependsOnAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class DependsOnAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new DependsOnAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DictionaryKeyPropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DictionaryKeyPropertyAttributeTests.cs index 15fcfe84aca..6f75392bb2b 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DictionaryKeyPropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/DictionaryKeyPropertyAttributeTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using Xunit; namespace System.Windows.Markup.Tests; @@ -13,7 +11,7 @@ public class DictionaryKeyPropertyAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new DictionaryKeyPropertyAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionBracketCharactersAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionBracketCharactersAttributeTests.cs index 0f251e397d9..d4d18fd5e09 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionBracketCharactersAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionBracketCharactersAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionReturnTypeAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionReturnTypeAttributeTests.cs index 532c9f46b8a..67789867bab 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionReturnTypeAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/MarkupExtensionReturnTypeAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; #pragma warning disable 0618 @@ -21,7 +20,7 @@ public void Ctor_Default() [Theory] [InlineData(null)] [InlineData(typeof(int))] - public void Ctor_Type(Type returnType) + public void Ctor_Type(Type? returnType) { var attribute = new MarkupExtensionReturnTypeAttribute(returnType); Assert.Equal(returnType, attribute.ReturnType); @@ -31,7 +30,7 @@ public void Ctor_Type(Type returnType) [Theory] [InlineData(null, null)] [InlineData(typeof(int), typeof(string))] - public void Ctor_Type_Type(Type returnType, Type expressionType) + public void Ctor_Type_Type(Type? returnType, Type? expressionType) { var attribute = new MarkupExtensionReturnTypeAttribute(returnType, expressionType); Assert.Equal(returnType, attribute.ReturnType); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameReferenceConverterTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameReferenceConverterTests.cs index 137e016871c..03fe5e4a660 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameReferenceConverterTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameReferenceConverterTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using System.Collections.Generic; using System.ComponentModel; using System.ComponentModel.Design.Serialization; @@ -19,10 +17,10 @@ public class NameReferenceConverterTests [InlineData(typeof(object), false)] [InlineData(typeof(string), true)] [InlineData(typeof(InstanceDescriptor), true)] - public void CanConvertFrom_Invoke_ReturnsExpected(Type type, bool expected) + public void CanConvertFrom_Invoke_ReturnsExpected(Type? type, bool expected) { var converter = new NameReferenceConverter(); - Assert.Equal(expected, converter.CanConvertFrom(type)); + Assert.Equal(expected, converter.CanConvertFrom(type!)); } [Fact] @@ -47,7 +45,7 @@ public void ConvertFrom_ResolveSuccessful_ReturnsExpected() [Theory] [InlineData("fixup")] [InlineData(null)] - public void ConvertFrom_ResolveUnsuccessful_ReturnsExpected(string fixup) + public void ConvertFrom_ResolveUnsuccessful_ReturnsExpected(string? fixup) { var converter = new NameReferenceConverter(); var context = new CustomTypeDescriptorContext @@ -58,7 +56,7 @@ public void ConvertFrom_ResolveUnsuccessful_ReturnsExpected(string fixup) return new CustomXamlNameResolver { ResolveAction = name => null!, - GetFixupTokenAction = (names, canAssignDirectly) => fixup + GetFixupTokenAction = (names, canAssignDirectly) => fixup! }; } }; @@ -106,7 +104,7 @@ public void ConvertFrom_NonIXamlNameResolverService_ThrowsInvalidCastException() [InlineData(null)] [InlineData(1)] [InlineData("")] - public void ConvertFrom_InvalidValue_ThrowsInvalidOperationException(object value) + public void ConvertFrom_InvalidValue_ThrowsInvalidOperationException(object? value) { var converter = new NameReferenceConverter(); var context = new CustomTypeDescriptorContext @@ -120,9 +118,9 @@ public void ConvertFrom_InvalidValue_ThrowsInvalidOperationException(object valu Assert.Throws(() => converter.ConvertFrom(context, null, value)); } - public static IEnumerable CanConvertTo_TestData() + public static IEnumerable CanConvertTo_TestData() { - yield return new object[] { null, null, false }; + yield return new object?[] { null, null, false }; yield return new object[] { new CustomTypeDescriptorContext { GetServiceAction = serviceType => null! }, typeof(string), false }; yield return new object[] { new CustomTypeDescriptorContext { GetServiceAction = serviceType => new object() }, typeof(string), false }; yield return new object[] { new CustomTypeDescriptorContext { GetServiceAction = serviceType => new CustomXamlNameProvider() }, typeof(int), false }; @@ -140,7 +138,7 @@ public void CanConvertTo_Invoke_ReturnsExpected(ITypeDescriptorContext context, [Theory] [InlineData(null)] [InlineData("name")] - public void ConvertTo_ValidService_ReturnsExpected(string name) + public void ConvertTo_ValidService_ReturnsExpected(string? name) { var converter = new NameReferenceConverter(); var context = new CustomTypeDescriptorContext @@ -150,7 +148,7 @@ public void ConvertTo_ValidService_ReturnsExpected(string name) Assert.Equal(typeof(IXamlNameProvider), serviceType); return new CustomXamlNameProvider { - GetNameAction = value => name + GetNameAction = value => name! }; } }; @@ -202,16 +200,11 @@ private class CustomTypeDescriptorContext : ITypeDescriptorContext public PropertyDescriptor PropertyDescriptor => throw new NotImplementedException(); - public Func GetServiceAction { get; set; } + public Func? GetServiceAction { get; set; } public object GetService(Type serviceType) { - if (GetServiceAction is null) - { - throw new NotImplementedException(); - } - - return GetServiceAction(serviceType); + return GetServiceAction is null ? throw new NotImplementedException() : GetServiceAction(serviceType); } public void OnComponentChanged() => throw new NotImplementedException(); @@ -223,24 +216,19 @@ private class CustomXamlNameResolver : IXamlNameResolver { public bool IsFixupTokenAvailable => throw new NotImplementedException(); - public Func ResolveAction { get; set; } + public Func? ResolveAction { get; set; } public object Resolve(string name) { - if (ResolveAction is null) - { - throw new NotImplementedException(); - } - - return ResolveAction(name); + return ResolveAction is null ? throw new NotImplementedException() : ResolveAction(name); } public object Resolve(string name, out bool isFullyInitialized) => throw new NotImplementedException(); public object GetFixupToken(IEnumerable names) => throw new NotImplementedException(); - public Func, bool, object> GetFixupTokenAction { get; set; } - + public Func, bool, object>? GetFixupTokenAction { get; set; } + public object GetFixupToken(IEnumerable names, bool canAssignDirectly) { if (GetFixupTokenAction is null) @@ -263,16 +251,11 @@ public event EventHandler OnNameScopeInitializationComplete private class CustomXamlNameProvider : IXamlNameProvider { - public Func GetNameAction { get; set; } - + public Func? GetNameAction { get; set; } + public string GetName(object value) { - if (GetNameAction is null) - { - throw new NotImplementedException(); - } - - return GetNameAction(value); + return GetNameAction is null ? throw new NotImplementedException() : GetNameAction(value); } } } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameScopePropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameScopePropertyAttributeTests.cs index 63e059b70bc..f617a484c46 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameScopePropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NameScopePropertyAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class NameScopePropertyAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new NameScopePropertyAttribute(name); Assert.Equal(name, attribute.Name); @@ -23,7 +22,7 @@ public void Ctor_String(string name) [InlineData(null, null)] [InlineData("", typeof(int))] [InlineData("name", typeof(string))] - public void Ctor_String_Type(string name, Type type) + public void Ctor_String_Type(string? name, Type? type) { var attribute = new NameScopePropertyAttribute(name, type); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NullExtensionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NullExtensionTests.cs index 24bd615d438..46ff9e49dea 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NullExtensionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/NullExtensionTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/PropertyDefinitionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/PropertyDefinitionTests.cs index 9738d7d0959..eb55e69d147 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/PropertyDefinitionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/PropertyDefinitionTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ReferenceTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ReferenceTests.cs index 496179e081c..07c10f4be2e 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ReferenceTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ReferenceTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using System.Collections.Generic; using System.Xaml; using Xunit; @@ -22,7 +20,7 @@ public void Ctor_Default() [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var reference = new Reference(name); Assert.Equal(name, reference.Name); @@ -46,7 +44,7 @@ public void ProvideValue_ResolveSuccessful_ReturnsExpected() [Theory] [InlineData("fixup")] [InlineData(null)] - public void ProvideValue_ResolveUnsuccessful_ReturnsExpected(string fixup) + public void ProvideValue_ResolveUnsuccessful_ReturnsExpected(string? fixup) { var reference = new Reference("name"); @@ -55,7 +53,7 @@ public void ProvideValue_ResolveUnsuccessful_ReturnsExpected(string fixup) ServiceAction = serviceType => new CustomXamlNameResolver { ResolveAction = name => null!, - GetFixupTokenAction = (names, canAssignDirectly) => fixup + GetFixupTokenAction = (names, canAssignDirectly) => fixup! } }; Assert.Equal(fixup, reference.ProvideValue(provider)); @@ -71,12 +69,12 @@ public void ProvideValue_NullServiceProvider_ThrowsArgumentNullException() [Theory] [InlineData(null)] [InlineData("string")] - public void ProvideValue_NonIXamlNameResolverProvider_ThrowsInvalidOperationException(object value) + public void ProvideValue_NonIXamlNameResolverProvider_ThrowsInvalidOperationException(object? value) { var reference = new Reference("name"); var provider = new CustomServiceProvider { - ServiceAction = serviceType => value + ServiceAction = serviceType => value! }; Assert.Throws(() => reference.ProvideValue(provider)); } @@ -84,7 +82,7 @@ public void ProvideValue_NonIXamlNameResolverProvider_ThrowsInvalidOperationExce [Theory] [InlineData(null)] [InlineData("")] - public void ProvideValue_NullOrEmptyName_ThrowsInvalidOperationException(string name) + public void ProvideValue_NullOrEmptyName_ThrowsInvalidOperationException(string? name) { var reference = new Reference(name); var provider = new CustomServiceProvider @@ -93,57 +91,36 @@ public void ProvideValue_NullOrEmptyName_ThrowsInvalidOperationException(string }; Assert.Throws(() => reference.ProvideValue(provider)); } - + private class CustomServiceProvider : IServiceProvider { - public Func ServiceAction { get; set; } - - public object GetService(Type serviceType) - { - if (ServiceAction is null) - { - throw new NotImplementedException(); - } + public Func? ServiceAction { get; set; } - return ServiceAction(serviceType); - } + public object GetService(Type serviceType) => + ServiceAction is null ? throw new NotImplementedException() : ServiceAction(serviceType); } - + private class CustomXamlNameResolver : IXamlNameResolver { public bool IsFixupTokenAvailable => throw new NotImplementedException(); - public Func ResolveAction { get; set; } - - public object Resolve(string name) - { - if (ResolveAction is null) - { - throw new NotImplementedException(); - } + public Func? ResolveAction { get; set; } - return ResolveAction(name); - } + public object Resolve(string name) => + ResolveAction is null ? throw new NotImplementedException() : ResolveAction(name); public object Resolve(string name, out bool isFullyInitialized) => throw new NotImplementedException(); public object GetFixupToken(IEnumerable names) => throw new NotImplementedException(); - public Func, bool, object> GetFixupTokenAction { get; set; } - - public object GetFixupToken(IEnumerable names, bool canAssignDirectly) - { - if (GetFixupTokenAction is null) - { - throw new NotImplementedException(); - } + public Func, bool, object>? GetFixupTokenAction { get; set; } - return GetFixupTokenAction(names, canAssignDirectly); - } + public object GetFixupToken(IEnumerable names, bool canAssignDirectly) => + GetFixupTokenAction is null ? throw new NotImplementedException() : GetFixupTokenAction(names, canAssignDirectly); - public IEnumerable> GetAllNamesAndValuesInScope() - => throw new NotImplementedException(); + public IEnumerable> GetAllNamesAndValuesInScope() => + throw new NotImplementedException(); public event EventHandler OnNameScopeInitializationComplete { diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RootNamespaceAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RootNamespaceAttributeTests.cs index ada5fbff4dc..2e6fa9e89ea 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RootNamespaceAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RootNamespaceAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class RootNamespaceAttributeTests [InlineData(null)] [InlineData("")] [InlineData("nameSpace")] - public void Ctor_String(string nameSpace) + public void Ctor_String(string? nameSpace) { var attribute = new RootNamespaceAttribute(nameSpace); Assert.Equal(nameSpace, attribute.Namespace); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RuntimeNamePropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RuntimeNamePropertyAttributeTests.cs index 7c031e84c4b..2aa5fd81fd3 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RuntimeNamePropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/RuntimeNamePropertyAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class RuntimeNamePropertyAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new RuntimeNamePropertyAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StaticExtensionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StaticExtensionTests.cs index a4394e17b22..ef56b83f4e2 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StaticExtensionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StaticExtensionTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using System.ComponentModel; using System.ComponentModel.Design.Serialization; using System.Linq; @@ -123,12 +122,12 @@ public void ProvideValue_NullServiceProvider_ThrowsArgumentNullException() [Theory] [InlineData(1)] [InlineData(null)] - public void ProvideValue_InvalidTypeResolver_ThrowsArgumentException(object service) + public void ProvideValue_InvalidTypeResolver_ThrowsArgumentException(object? service) { var extension = new StaticExtension("type.member"); var provider = new CustomServiceProvider { - ServiceAction = serviceType => service + ServiceAction = serviceType => service! }; Assert.Throws(() => extension.ProvideValue(provider)); } @@ -202,7 +201,7 @@ public void MemberType_SetNull_ThrowsArgumemtNullException() [InlineData(typeof(string), true)] [InlineData(typeof(int), false)] [InlineData(null, false)] - public void StaticExtensionConverter_CanConvertTo_ReturnsExpected(Type type, bool expected) + public void StaticExtensionConverter_CanConvertTo_ReturnsExpected(Type? type, bool expected) { var extension = new StaticExtension("member"); TypeConverter converter = TypeDescriptor.GetConverter(extension); @@ -243,54 +242,56 @@ public void StaticExtensionConverter_ConvertToInvalidType_ThrowsNotSupportedExce TypeConverter converter = TypeDescriptor.GetConverter(extension); Assert.Throws(() => converter.ConvertTo(extension, typeof(int))); } - + private class CustomServiceProvider : IServiceProvider { - public Func ServiceAction { get; set; } + public Func? ServiceAction { get; set; } - public object GetService(Type serviceType) - { - if (ServiceAction is null) - { - throw new NotImplementedException(); - } - - return ServiceAction(serviceType); - } + public object GetService(Type serviceType) => + ServiceAction is null ? throw new NotImplementedException() : ServiceAction(serviceType); } private class CustomXamlTypeResolver : IXamlTypeResolver { - public Func ResolveAction { get; set; } - - public Type Resolve(string qualifiedTypeName) - { - if (ResolveAction is null) - { - throw new NotImplementedException(); - } + public Func? ResolveAction { get; set; } - return ResolveAction(qualifiedTypeName); - } + public Type Resolve(string qualifiedTypeName) => + ResolveAction is null ? throw new NotImplementedException() : ResolveAction(qualifiedTypeName); } public class BaseType { +#pragma warning disable CA2211 // Non-constant fields should not be visible public static int s_inheritedField = 1; +#pragma warning disable IDE1006 // Naming Styles public static int InheritedProperty = 2; +#pragma warning restore IDE1006 +#pragma warning restore CA2211 } #pragma warning disable 0169 +#pragma warning disable CA1051 // Do not declare visible instance fields public class CustomType : BaseType { +#pragma warning disable CA2211 // Non-constant fields should not be visible public static int s_field = 3; +#pragma warning restore CA2211 public static int StaticProperty { get; set; } = 4; +#pragma warning disable CA1823 // Avoid unused private fields +#pragma warning disable IDE0044 // Add readonly modifier +#pragma warning disable IDE0051 // Remove unused private members private static int s_privateField; +#pragma warning restore IDE0051 +#pragma warning restore IDE0044 +#pragma warning restore CA1823 public int _field; +#pragma warning disable IDE0051 // Remove unused private members private static int PrivateStaticProperty { get; set; } +#pragma warning restore IDE0051 public int Property { get; set; } } +#pragma warning restore CA1051 #pragma warning restore 0169 } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StringValueSerializerTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StringValueSerializerTests.cs index 97eaeea12de..46428ea7bf7 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StringValueSerializerTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/StringValueSerializerTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -25,7 +24,7 @@ public void GetSerializerFor_StringConvertFromString_ReturnsTrue() [Theory] [InlineData(null)] [InlineData("value")] - public void GetSerializerFor_StringConvertToString_ReturnsValue(object value) + public void GetSerializerFor_StringConvertToString_ReturnsValue(object? value) { ValueSerializer serializer = ValueSerializer.GetSerializerFor(typeof(string))!; Assert.Equal(value, serializer.ConvertToString(value, null)); @@ -41,9 +40,9 @@ public void GetSerializerFor_StringConvertToStringValueNotString_ThrowsInvalidCa [Theory] [InlineData(null)] [InlineData("value")] - public void GetSerializerFor_StringConvertFromString_ReturnsValue(string value) + public void GetSerializerFor_StringConvertFromString_ReturnsValue(string? value) { ValueSerializer serializer = ValueSerializer.GetSerializerFor(typeof(string))!; - Assert.Equal(value, serializer.ConvertFromString(value, null)); + Assert.Equal(value, serializer.ConvertFromString(value!, null)); } } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TrimSurroundingWhitespaceAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TrimSurroundingWhitespaceAttributeTests.cs index 894b3db7bbc..04bd8f65a15 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TrimSurroundingWhitespaceAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TrimSurroundingWhitespaceAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TypeExtensionTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TypeExtensionTests.cs index ea37290d240..3abbfc2f3d7 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TypeExtensionTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/TypeExtensionTests.cs @@ -1,8 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable using System.ComponentModel; using System.ComponentModel.Design.Serialization; using System.Linq; @@ -95,12 +93,12 @@ public void ProvideValue_NullServiceProvider_ThrowsArgumentNullException() [Theory] [InlineData(1)] [InlineData(null)] - public void ProvideValue_InvalidTypeResolver_ThrowsInvalidOperationException(object service) + public void ProvideValue_InvalidTypeResolver_ThrowsInvalidOperationException(object? service) { var extension = new TypeExtension("typeName"); var provider = new CustomServiceProvider { - ServiceAction = serviceType => service + ServiceAction = serviceType => service! }; Assert.Throws(() => extension.ProvideValue(provider)); } @@ -164,7 +162,7 @@ public void Type_SetNull_ThrowsArgumemtNullException() [InlineData(typeof(string), true)] [InlineData(typeof(int), false)] [InlineData(null, false)] - public void TypeExtensionConverter_CanConvertTo_ReturnsExpected(Type type, bool expected) + public void TypeExtensionConverter_CanConvertTo_ReturnsExpected(Type? type, bool expected) { var extension = new TypeExtension("member"); TypeConverter converter = TypeDescriptor.GetConverter(extension); @@ -208,31 +206,17 @@ public void TypeExtensionConverter_ConvertToInvalidType_ThrowsNotSupportedExcept private class CustomServiceProvider : IServiceProvider { - public Func ServiceAction { get; set; } + public Func? ServiceAction { get; set; } - public object GetService(Type serviceType) - { - if (ServiceAction is null) - { - throw new NotImplementedException(); - } - - return ServiceAction(serviceType); - } + public object GetService(Type serviceType) => + ServiceAction is null ? throw new NotImplementedException() : ServiceAction(serviceType); } private class CustomXamlTypeResolver : IXamlTypeResolver { - public Func ResolveAction { get; set; } - - public Type Resolve(string qualifiedTypeName) - { - if (ResolveAction is null) - { - throw new NotImplementedException(); - } + public Func? ResolveAction { get; set; } - return ResolveAction(qualifiedTypeName); - } + public Type Resolve(string qualifiedTypeName) => + ResolveAction is null ? throw new NotImplementedException() : ResolveAction(qualifiedTypeName); } } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UidPropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UidPropertyAttributeTests.cs index c85eb9b065d..6abafa7be5b 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UidPropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UidPropertyAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class UidPropertyAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new UidPropertyAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UsableDuringInitializationAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UsableDuringInitializationAttributeTests.cs index 1fd8ff47242..6935bf75d01 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UsableDuringInitializationAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/UsableDuringInitializationAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ValueSerializerTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ValueSerializerTests.cs index 14977e17494..6893487447c 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ValueSerializerTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/ValueSerializerTests.cs @@ -1,6 +1,5 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using System.Collections.Generic; using System.ComponentModel; @@ -8,7 +7,7 @@ using Xunit; namespace System.Windows.Markup.Tests; - + public class ValueSerializerTests { public static IEnumerable CanConvertToString_TestData() @@ -440,7 +439,7 @@ public class CustomValueSerializerContext : IValueSerializerContext public ValueSerializer? SerializerResult { get; set; } public ValueSerializer? GetValueSerializerFor(Type type) => SerializerResult; - + public ValueSerializer? GetValueSerializerFor(PropertyDescriptor type) => SerializerResult; public IContainer Container => throw new NotImplementedException(); @@ -459,9 +458,9 @@ public class CustomValueSerializerContext : IValueSerializerContext public class CustomTypeConverter : TypeConverter { - public override bool CanConvertTo(ITypeDescriptorContext? context, Type? sourceType) + public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destinationType) { - Assert.Equal(typeof(string), sourceType); + Assert.Equal(typeof(string), destinationType); return true; } @@ -484,7 +483,7 @@ public override object ConvertTo(ITypeDescriptorContext? context, CultureInfo? c public class CannotConvertToTypeConverter : TypeConverter { - public override bool CanConvertTo(ITypeDescriptorContext? context, Type? sourceType) + public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destinationType) { return false; } @@ -497,7 +496,7 @@ public override bool CanConvertFrom(ITypeDescriptorContext? context, Type? sourc public class CannotConvertFromTypeConverter : TypeConverter { - public override bool CanConvertTo(ITypeDescriptorContext? context, Type? sourceType) + public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destinationType) { return true; } @@ -519,7 +518,7 @@ internal class InternalClass : TypeConverter public class NestedPublicClass { } } -class PrivateClass : TypeConverter +internal class PrivateClass : TypeConverter { public class NestedPublicClass { } } diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/WhitespaceSignificantCollectionAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/WhitespaceSignificantCollectionAttributeTests.cs index 3fba0b2cc76..5d2066489a2 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/WhitespaceSignificantCollectionAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/WhitespaceSignificantCollectionAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XDataTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XDataTests.cs index c5cc9a08f26..885706486d5 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XDataTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XDataTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using System.IO; using System.Xml; using Xunit; @@ -21,7 +20,7 @@ public void Ctor_Default() [InlineData(null)] [InlineData("")] [InlineData("text")] - public void Text_Set_GetReturnsExpected(string value) + public void Text_Set_GetReturnsExpected(string? value) { var data = new XData { Text = value }; Assert.Equal(value, data.Text); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlDeferLoadAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlDeferLoadAttributeTests.cs index 28a8faa228b..59ca063d784 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlDeferLoadAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlDeferLoadAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionAttributeTests.cs index b4ea0a0086f..16bb5cb27ef 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class XamlSetMarkupExtensionAttributeTests [InlineData(null)] [InlineData("")] [InlineData("xamlSetMarkupExtensionHandler")] - public void Ctor_String(string xamlSetMarkupExtensionHandler) + public void Ctor_String(string? xamlSetMarkupExtensionHandler) { var attribute = new XamlSetMarkupExtensionAttribute(xamlSetMarkupExtensionHandler); Assert.Equal(xamlSetMarkupExtensionHandler, attribute.XamlSetMarkupExtensionHandler); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionEventArgsTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionEventArgsTests.cs index 19f830549a8..b9f8956dc52 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionEventArgsTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetMarkupExtensionEventArgsTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using System.Collections.Generic; using System.Xaml; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterAttributeTests.cs index a1e2b70cfc9..af37634c3c8 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class XamlSetTypeConverterAttributeTests [InlineData(null)] [InlineData("")] [InlineData("xamlSetTypeConverterHandler")] - public void Ctor_String(string xamlSetTypeConverterHandler) + public void Ctor_String(string? xamlSetTypeConverterHandler) { var attribute = new XamlSetTypeConverterAttribute(xamlSetTypeConverterHandler); Assert.Equal(xamlSetTypeConverterHandler, attribute.XamlSetTypeConverterHandler); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterEventArgsTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterEventArgsTests.cs index ecd0c5fa708..9be6c06a4c2 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterEventArgsTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetTypeConverterEventArgsTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using System.Collections.Generic; using System.ComponentModel; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetValueEventArgsTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetValueEventArgsTests.cs index 429eb4b10f4..2da2edc9d58 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetValueEventArgsTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XamlSetValueEventArgsTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using System.Collections.Generic; using System.Xaml; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlLangPropertyAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlLangPropertyAttributeTests.cs index c14d11713fd..21496e77fcc 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlLangPropertyAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlLangPropertyAttributeTests.cs @@ -1,7 +1,6 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. -#nullable disable + using Xunit; namespace System.Windows.Markup.Tests; @@ -12,7 +11,7 @@ public class XmlLangPropertyAttributeTests [InlineData(null)] [InlineData("")] [InlineData("name")] - public void Ctor_String(string name) + public void Ctor_String(string? name) { var attribute = new XmlLangPropertyAttribute(name); Assert.Equal(name, attribute.Name); diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsCompatibleWithAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsCompatibleWithAttributeTests.cs index 4b71c659dda..04567a22a9d 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsCompatibleWithAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsCompatibleWithAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsDefinitionAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsDefinitionAttributeTests.cs index 38e014d59e4..cdeb7872390 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsDefinitionAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsDefinitionAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsPrefixAttributeTests.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsPrefixAttributeTests.cs index f8b2c744725..eacbd2aaa6c 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsPrefixAttributeTests.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/System.Xaml.Tests/System/Windows/Markup/XmlnsPrefixAttributeTests.cs @@ -1,6 +1,5 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -// See the LICENSE file in the project root for more information. using Xunit; diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/GlobalUsings.cs b/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/GlobalUsings.cs index 0338090b4fb..6a4deaf1f55 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/GlobalUsings.cs +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/GlobalUsings.cs @@ -2,4 +2,6 @@ // The .NET Foundation licenses this file to you under the MIT license. global using Xunit; +#pragma warning disable IDE0005 // Using directive is unnecessary. New project, this will be used. global using FluentAssertions; +#pragma warning restore IDE0005 diff --git a/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/WindowsBase.Tests.csproj b/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/WindowsBase.Tests.csproj index ad42f9c74ca..0299b96932f 100644 --- a/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/WindowsBase.Tests.csproj +++ b/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/WindowsBase.Tests.csproj @@ -5,6 +5,7 @@ x64;x86;arm64 $(TargetFramework)-windows + true