Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tablet Device #119

Open
mildronize opened this issue Aug 8, 2021 · 8 comments · Fixed by #181
Open

Support Tablet Device #119

mildronize opened this issue Aug 8, 2021 · 8 comments · Fixed by #181

Comments

@mildronize
Copy link
Collaborator

mildronize commented Aug 8, 2021

Website should be supported Tablet device size.

Problems

Problem on width 800px-1100px

  • The menu bar display multiple lines,
  • Sidebar width is too wider for tablet.

here is the screenshot on device width about 800px

image

and here is the screenshot on device width about 1100px

image

Problem on width about 767px (on tablet portrait);

  • Too wider width for sidebar

here is the screenshot on device width about 767px

image

Possible Solution

  • Adjust font size and sidebar width on targeted screen width range.
@aaronamm
Copy link
Member

Could you please give a screenshot of issue on a tablet device?
Thanks.

@mildronize
Copy link
Collaborator Author

Yes @aaronamm, I've updated the topic

@aaronamm
Copy link
Member

@mildronize Thank you so much.

@runyasak
Copy link
Contributor

runyasak commented Oct 26, 2021

I want to help on this PR.
Please, give me more specific actual result. 😁 🙏

Updated:

I understand on 800px-1100px case.
But, i'm not sure for 767px case. Do you want to show sidebar ? Because you can use sidebar menu from hamburger button on the top-right.

@mildronize
Copy link
Collaborator Author

@runyasak Thank you so much for your intention to help this issue. The idea of 767px case is when user open sidebar, the sidebar width should be equal to desktop size, not 100% width.

The expected solution of 767px case. When user open the menu, the sidebar width should be same width desktop size.

image

However, this case may change behavior of sidebar in JS or CSS, feel free to help us.

Again, Thank you very much,

@runyasak
Copy link
Contributor

Hi, @mildronize.

I have fixed for 800px - 1100px case, please checkout this #181 .

However, there have a bug for sidebar on 767px, you can scroll down to see content and that would be hard work to do.
image

@mildronize mildronize linked a pull request Oct 29, 2021 that will close this issue
@mildronize
Copy link
Collaborator Author

@runyasak Thank you very much. I've merged.

@mildronize
Copy link
Collaborator Author

Yep for the case sidebar on 767px, it'll take some time to do.
That PR #181 Look great that solved the problem. @runyasak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants