Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning warn the option sizeByPixelDensity is deprecated and should not be used. It will be removed in the next major release of Gatsby. #207

Open
kaiwanyawit-chawankul opened this issue Feb 8, 2022 · 4 comments

Comments

@kaiwanyawit-chawankul
Copy link
Contributor

warn the option sizeByPixelDensity is deprecated and should not be used. It will be removed in the next major release of Gatsby.

image

Should we change this deprecated function?

CC: @aaronamm @mildronize

@mildronize
Copy link
Collaborator

@kaiwanyawit-chawankul Thanks for your suggestion, my opinion it doesn't hurry to fix this issue, because in order to migrate Gatsby with major release is not easy, due to a huge dependency of this project. this project still use Gatsby 2.x,

Answer your question, if we can migrate from Gatsby 2.x to 3.x, this deprecated function will be more easy.

@aaronamm
Copy link
Member

@kaiwanyawit-chawankul Thanks for your suggestion and agree with @mildronize for his idea.
I think we should consider to migrate our website to Gatsby version 4 as our first priority.

However, I don't know if you would like to help us on migration. Please let me know if you would like to try or not.
I am happy to support you but I accept this might be a huge PR, LoL.

@kaiwanyawit-chawankul
Copy link
Contributor Author

Hi @mildronize @aaronamm,

This error came from gatsby-plugin-sharp for warning about sizeByPixelDensity
which is have nothing to do with the use in gatsby-remark-images

image

That mean we don't have to worry about it.
Based on those links below. Maybe I am wrong.

https://diff.intrinsic.com/gatsby-plugin-sharp/2.0.36/2.0.37
gatsbyjs/gatsby#23376
gatsbyjs/gatsby#12743

What do you think?

@mildronize
Copy link
Collaborator

I think @kaiwanyawit-chawankul you can be true, could you please remove that line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants