Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic improvements of json_schema (follow up on #98) #114

Open
torymur opened this issue Dec 6, 2024 · 0 comments · May be fixed by #133
Open

Basic improvements of json_schema (follow up on #98) #114

torymur opened this issue Dec 6, 2024 · 0 comments · May be fixed by #133
Assignees
@torymur
Labels
enhancement New feature or request json schema

Comments

@torymur
Copy link
Contributor

torymur commented Dec 6, 2024

There are some leftovers from #98 to improve json schema:

  • add more tests: for white space patterns, expected errors, etc.
  • simplification of errors and their integration into the lib
  • docs
@torymur torymur added the enhancement New feature or request label Dec 6, 2024
@torymur torymur changed the title Basic improvements of json_schema (follow up on https://github.com/dottxt-ai/outlines-core/pull/98) Basic improvements of json_schema (follow up on #98) Dec 6, 2024
@rlouf rlouf added vLLM and removed vLLM labels Dec 12, 2024
@torymur torymur linked a pull request Dec 20, 2024 that will close this issue
Draft
4 tasks
@torymur torymur self-assigned this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torymur torymur

Labels
enhancement New feature or request json schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic improvements of json_schema (follow up on PR #98) dottxt-ai/outlines-core
2 participants
@torymur @rlouf