From 93e0c01f6da423388106bc1d09ae713d29b7d25c Mon Sep 17 00:00:00 2001 From: M Conrad Date: Wed, 2 Jan 2019 13:11:01 -0500 Subject: [PATCH] Require minimum version of Archive::Zip Spreadsheet::ParseXLSX has a test case that opens a scalar ref as a file. Archive::Zip earlier than 1.34 can't support this, and fails the test. ``` error: file not seekable at /usr/lib/perl5/vendor_perl/5.12.3/Archive/Zip/Archive.pm line 576. Archive::Zip::Archive::readFromFileHandle(Archive::Zip::Archive=HASH(0x8e3ca60), GLOB(0x8d2e368)) called at /home/mconrad/.cpanm/work/1546451049.12404/Spreadsheet-ParseXLSX-0. 27/blib/lib/Spreadsheet/ParseXLSX.pm line 58 Spreadsheet::ParseXLSX::parse(Spreadsheet::ParseXLSX=HASH(0x8d1fed0), SCALAR(0x8c85d08)) called at t/basic.t line 17 Can't open scalar ref as a zip file at /home/mconrad/.cpanm/work/1546451049.12404/Spreadsheet-ParseXLSX-0.27/blib/lib/Spreadsheet/ParseXLSX.pm line 58. ``` --- lib/Spreadsheet/ParseXLSX.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Spreadsheet/ParseXLSX.pm b/lib/Spreadsheet/ParseXLSX.pm index 5df5111..c6bc078 100644 --- a/lib/Spreadsheet/ParseXLSX.pm +++ b/lib/Spreadsheet/ParseXLSX.pm @@ -4,7 +4,7 @@ use warnings; use 5.010; # ABSTRACT: parse XLSX files -use Archive::Zip; +use Archive::Zip 1.34; use Graphics::ColorUtils 'rgb2hls', 'hls2rgb'; use Scalar::Util 'openhandle'; use Spreadsheet::ParseExcel 0.61;