Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions regarding the Scalability of iterations #1

Open
offthewallace opened this issue Apr 12, 2023 · 1 comment
Open

Questions regarding the Scalability of iterations #1

offthewallace opened this issue Apr 12, 2023 · 1 comment

Comments

@offthewallace
Copy link

Hi, I am trying to run the experiment for generating the figure3 in journal version of HDMM. However, when I run the scalability for generate 100 inner iterations for OPTx, it output the type error ( for experiments in scalability_5d.csv) :
hdmm/experiments/journal/scalability.py", line 118, in
temp1.optimize(W, iters=100)
TypeError: Kronecker.optimize() got an unexpected keyword argument 'iters'.

temp1 = templates.DefaultKron(domain, approx=False)

So I am wondering if those iters=100 are for just generate for loop around temp.optimize? or its defined as line 280 for class Kronecker's optimize function in templeates.py from scr/hdmm? where as the for _ in range(10): the 10 is actually represent for iters?

@ryan112358
Copy link
Collaborator

Hi @offthewallace , thanks for bringing this issue to our attention. It's been a while since I've used this code, but I think I'd recommend just removing that option from optimize, I expect the default number of iterations should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants