theme: Adds very basic theme support. #112
Conversation
abaire
force-pushed
the
theme_support
branch
4 times, most recently
from
bb58e9f to
b9803f8
Compare
abaire
force-pushed
the
theme_support
branch
6 times, most recently
from
e21adb1 to
a504757
Compare
|
|
||
| std::ifstream themeFile(themeFilePath); | ||
| nlohmann::json json; | ||
| // FIXME: Once nxdk supports C++ Exceptions, this needs to be put in a try-catch block! |
There was a problem hiding this comment.
This is supported now is it not?
| public: | ||
| struct MenuTheme { | ||
| std::string font; | ||
| // TODO: Actually support this in Font. |
There was a problem hiding this comment.
Minor nit: font not Font
There was a problem hiding this comment.
Pretty sure I was referring to the Font class, so I think the capitalization is correct. Making it "font" would be ambiguous with the member var just above.
| #endif | ||
| { "logging", nlohmann::json(o.logging) }, | ||
| { "homescreenConfig", nlohmann::json(o.homescreen) } }; | ||
| { "homescreen", nlohmann::json(o.homescreen) } }; |
There was a problem hiding this comment.
Nit: specific reason why this was changed? Listing it as config may make it easier for outside devs to understand.
There was a problem hiding this comment.
It's been a long time, but looking a few lines down at line 246 it's specifically looking for "homescreen" when reading the config file, so I think saving the config would always cause the default values to be used.
It also strikes me as more consistent to use "homescreen" in the same way that "logging", etc... is used rather than "loggingConfig".
There was a problem hiding this comment.
Edit: Sounds Good, voice to text is really losing today
2 participants
Puts in the foundation for theme selection.
Resources/NeXThemesand drops thenew_allworkaround by addingRESOURCEStoTARGET.ThemeJSON parsing class.defaulttheme subdir and adds a .json definition file for them.Some nice followups would be:
Fontso the font color can be changed.HalQuickRebootRoutineto return to dashboard XboxDev/nxdk#507 will need to be fixed)