Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: playerctl plugin is empty when no players are running #312

Open
joncvn opened this issue Nov 16, 2024 · 3 comments
Open

Bug: playerctl plugin is empty when no players are running #312

joncvn opened this issue Nov 16, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@joncvn
Copy link

joncvn commented Nov 16, 2024

Describe the bug

Hello there, first of all, thank you for all your dedication to work on a such amazing plugin ! I have an issue with the playerctl plugin, it show an empty plugin when no players are running, even with set -g @dracula-show-empty-plugins false setup.

Configuration file

# Make colors inside tmux look the same as outside of tmux
set -g default-terminal "screen-256color"

# List of plugins
set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'tmux-plugins/tmux-sensible'
set -g @plugin 'tmux-plugins/tmux-resurrect'
set -g @plugin 'dracula/tmux'

# available plugins: battery, cpu-usage, git, gpu-usage, ram-usage, tmux-ram-usage, network, network-bandwidth, network-ping, ssh-session, attached-clients, network-vpn, weather, time, mpc, spotify-tui, krbtgt, playerctl, kubernetes-context, synchronize-panes
set -g @dracula-plugins "ssh-session ram-usage battery playerctl time"
set -g @dracula-ignore-window-colors false
set -g @dracula-show-powerline true
set -g @dracula-show-flags true
set -g @dracula-show-empty-plugins false

# it can accept `hostname` (full hostname), `session`, `shortname` (short name), `smiley`, `window`, or any character.
set -g @dracula-show-left-icon session

# Datetime 
set -g @dracula-show-timezone false
set -g @dracula-day-month true

# Monitor resource
set -g @dracula-cpu-usage-label "\uf4bc"
set -g @dracula-ram-usage-label "\uec19"

# Battery
set -g @dracula-battery-label false
set -g @dracula-no-battery-label false
set -g @dracula-show-battery-status true

# default is 1, it can accept any number and 0 disables padding.
set -g @dracula-left-icon-padding 0 

# Playerctl settings
set -g @dracula-playerctl-format "\uf001 {{ artist }} - {{ title }}"


# Left symbol separator
set -g @dracula-show-left-sep \ue0b8 #this is the following symbol -> 

# Right symbol separator
set -g @dracula-show-right-sep \ue0b2 # this is the following symbol -> 


set -g @dracula-colors "
# Tomorrow Night Color Palette
pink='#cc6666'
orange='#de935f'
yellow='#f0c574'
green='#b5bd68'
cyan='#8abdb6'
light_purple='#b294ba'
white='#c4c8c5'
dark_gray='#363a41'
red='#cc6666'
gray='#1d1f21'
dark_purple='#373b41'
"

# Initialize TMUX plugin manager (keep this line at the very bottom of tmux.conf)
run -b '~/.tmux/plugins/tpm/tpm'

I am using the set -g @dracula-colors option to override the default theme for using another one, thank you for reading it and for your time.

Screenshots

No player is running
image

One player is running
image

System

  • OS: Ubuntu 24.04.1 LTS
  • Terminal: Kitty
  • Tmux Version:
    ❯ tmux -V       
    tmux 3.4
    
@joncvn joncvn added the bug Something isn't working label Nov 16, 2024
@joncvn joncvn changed the title Bug: playerctl plugin is empty when no players is running Bug: playerctl plugin is empty when no players are running Nov 16, 2024
@Theoreticallyhugo
Copy link
Contributor

first of all i'm very happy to see that you're using custom colours, as its been one of my most favourite changes i worked on implementing. i would love to see you write a pr (or an issue, providing info) adding your colour scheme to the docs!

now to your issue: i hope i fixed it in #314, but need you to test it properly. please let us know :D

@joncvn
Copy link
Author

joncvn commented Nov 19, 2024

i would love to contribute to this project by adding a new colorscheme ! I will write a PR as soon as possible

@joncvn
Copy link
Author

joncvn commented Nov 19, 2024

here we go : #315
Let me know if it can be improve, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants