Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model ID #20

Open
3 of 4 tasks
cb-Hades opened this issue Nov 29, 2024 · 1 comment
Open
3 of 4 tasks

Improve model ID #20

cb-Hades opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cb-Hades
Copy link
Collaborator

cb-Hades commented Nov 29, 2024

Improve the setting of the model ID to be "less random".

TODOs (main)

  • HQTB
  • CMPB

TODOs (details)

  • improve default
  • add option to prvude model ID in the yaml

Notes:

  • should the name of the output files also be adjusted?
@cb-Hades cb-Hades added the enhancement New feature or request label Nov 29, 2024
niinina added a commit that referenced this issue Dec 28, 2024
niinina added a commit that referenced this issue Dec 28, 2024
@cb-Hades
Copy link
Collaborator Author

cb-Hades commented Jan 8, 2025

Current solution by @niinina

if not config['general']['modelname']:
        modelname = 'i'+config['general']['organism']+config['general']['strainid']+config['general']['authorinitials']+str(date.today().year).removeprefix('20')
else:
        modelname = config['general']['modelname']

Thoughts:
First, check if all values for the "standard" are given. If that is the case, use those. If that is not the case, check for the general name. Otherwise, either throw an error or use a default. That way, the most sophisticated version is always used when it is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants