-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringBuilder is very slow #177
Comments
StringBuilder uses array for concatenation. This is very slow. GWT uses plain javascript strings with StringBuilder. I would recommend taking the GWT approach instead of array. |
"ScriptHelper.eval*", is this really javascript eval? Or dragome creates raw javascript method for it? |
Hi @norzak sorry for the delay, ScriptHelper in general creates raw js for eval, but in some particular cases, for example when you are not using a constant string as parameter it uses eval. |
It seems it could easy to use gwt implementation: https://github.com/gwtproject/gwt/blob/master/user/super/com/google/gwt/emul/java/lang/StringBuilder.java |
Great. I agree. |
For string concatenation which is faster with Dragome? StringBuilder does not seem to be fast. It uses array and uses array push for append. Is concat method of String faster? what do you recommend?
The text was updated successfully, but these errors were encountered: