Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange compare in code of DragomeJavaScriptGenerator #185

Open
nicolaichuk opened this issue Oct 12, 2017 · 1 comment
Open

Strange compare in code of DragomeJavaScriptGenerator #185

nicolaichuk opened this issue Oct 12, 2017 · 1 comment

Comments

@nicolaichuk
Copy link
Contributor

nicolaichuk commented Oct 12, 2017

	private boolean isW3C(MethodInvocation invocation)
	{
		MethodBinding methodBinding= invocation.getMethodBinding();

// ...
		if (methodBinding.equals("org.w3c.dom5.NamedNodeMap"))
		{
			if (name.equals("setNamedItemNS") || name.equals("setNamedItem"))
				return false;
		}
		if (methodBinding.equals("org.w3c.dom5.Element"))
		{
			if (name.equals("setAttributeNode") || name.equals("setAttributeNodeNS"))
				return false;
		}
// ...

}

and

methodBinding is MethodBinding and dont have override equals function.
and you try compare with text string @_@

@RP-fernandopetrola
Copy link
Collaborator

Hi, this method is not in use, I'll remove it in next release. thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants