Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streams XADD/XTRIM require journal rewrite during the replication #4202

Open
romange opened this issue Nov 27, 2024 · 0 comments
Open

streams XADD/XTRIM require journal rewrite during the replication #4202

romange opened this issue Nov 27, 2024 · 0 comments
Assignees
@BagritsevichStepan
Labels
API-7 Redis API 7 enhancement New feature or request STREAMS Streams API

Comments

@romange
Copy link
Collaborator

romange commented Nov 27, 2024

XADD may trim the stream, XTRIM does it as well.
Their arguments may specify the intent in declarative way like ~ 1000 or COUNT 1000.

Currently, Dragonfly does not rewrite journal stream commands at all.

Dragonfly master should rewrite it into ... MINID = <id> to provide exact state semantics for slave to comply.
@romange romange added enhancement New feature or request API-7 Redis API 7 STREAMS Streams API labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BagritsevichStepan BagritsevichStepan

Labels
API-7 Redis API 7 enhancement New feature or request STREAMS Streams API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romange @BagritsevichStepan