Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Takeover improvements #4238

Open
2 tasks
adiholden opened this issue Dec 2, 2024 · 1 comment
Open
2 tasks

Takeover improvements #4238

adiholden opened this issue Dec 2, 2024 · 1 comment
Assignees
@BorysTheDev
Labels
enhancement New feature or request

Comments

@adiholden
Copy link
Collaborator

  • Dont allow all commands on takeover state
    Today we allow read commands but if we have a big read command running in pipeline it can take a while to send all data to client which leads to fail in takeover

  • If dispatch tracker failed to wait on all dispatched commands, close problematic connection which did not finish dispatch.
@adiholden adiholden added enhancement New feature or request Next Up task that is ready to be worked on and should be added to working queue labels Dec 2, 2024
@romange
Copy link
Collaborator

romange commented Dec 2, 2024

We should also print more details about the connections that had not been not closed (maybe we do that already, I do not know).

@BorysTheDev BorysTheDev mentioned this issue Dec 5, 2024
Merged
@adiholden adiholden removed the Next Up task that is ready to be worked on and should be added to working queue label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BorysTheDev BorysTheDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romange @BorysTheDev @adiholden