Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate valkey's stream and stream-cgroups tcl tests to stream_family_test.cc #4291

Open
romange opened this issue Dec 11, 2024 · 0 comments
Open

migrate valkey's stream and stream-cgroups tcl tests to stream_family_test.cc #4291

romange opened this issue Dec 11, 2024 · 0 comments
Labels
API-7 Redis API 7 enhancement New feature or request

Comments

@romange
Copy link
Collaborator

romange commented Dec 11, 2024

tests/unit/type/stream-cgroups.tcl contains lots of good tests for streams.
We should make an effort to increase the coverage around streams.

Example of tests already migrated:

  1. SeenActiveTime was migrated from "Consumer seen-time and active-time" test
  2. XsetIdSmallerMaxDeleted was migrated from "XSETID cannot set smaller ID than current MAXDELETEDID"
  3. XAddMaxSeq was migrated from "XADD with artial ID with maximal seq"
  4. AutoClaimDelCount was migrated from "XAUTOCLAIM with XDEL and count"
  5. AutoClaimPelItemsFromAnotherConsumer was migrated from "XCLAIM can claim PEL items from another consumer"
@romange romange added enhancement New feature or request API-7 Redis API 7 labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API-7 Redis API 7 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romange