Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed replication items in cache_mode full sync #4306

Closed
chakaz opened this issue Dec 13, 2024 · 2 comments · Fixed by #4307
Closed

Missed replication items in cache_mode full sync #4306

chakaz opened this issue Dec 13, 2024 · 2 comments · Fixed by #4307
Labels
bug Something isn't working

Comments

@chakaz
Copy link
Collaborator

chakaz commented Dec 13, 2024

We've seen 2 regtests failures:

https://github.com/dragonflydb/dragonfly/actions/runs/12229971008/job/34110555900
https://github.com/dragonflydb/dragonfly/actions/runs/12224081214/job/34096392568

This (very rarely) happens when cache_mode is enabled due to unprotected BumpUp()
@chakaz chakaz added the bug Something isn't working label Dec 13, 2024
chakaz added a commit that referenced this issue Dec 13, 2024
@chakaz
fix: Protect BumpUp() from running in parallel to serialization
f4ad469 
Fixes #4306
@chakaz chakaz mentioned this issue Dec 13, 2024
Merged
@romange
Copy link
Collaborator

romange commented Dec 13, 2024

I wonder if it's related to this:
#4303

@kostasrim
Copy link
Contributor

@romange it shall not, they are not using serialization max chunk size and we did not have this issue with the db slice mutex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Protect BumpUp() from running in parallel to serialization dragonflydb/dragonfly
3 participants
@romange @chakaz @kostasrim