fix: stream memory counting durin snapshot loading #4346
Merged
+74
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit test |
BorysTheDev
force-pushed
the
fix_stream_memory_counting
branch
2 times, most recently
from
0e9ab52 to
c7e2c60
Compare
adiholden
reviewed
Dec 24, 2024
adiholden
reviewed
Dec 24, 2024
BorysTheDev
force-pushed
the
fix_stream_memory_counting
branch
from
c7e2c60 to
b7155d9
Compare
BorysTheDev
force-pushed
the
fix_stream_memory_counting
branch
from
b7155d9 to
1cebba5
Compare
adiholden
reviewed
Dec 26, 2024
adiholden
reviewed
Dec 26, 2024
BorysTheDev
force-pushed
the
fix_stream_memory_counting
branch
from
0770123 to
fe1f4ef
Compare
adiholden
reviewed
Dec 26, 2024
adiholden
reviewed
Dec 26, 2024
BorysTheDev
force-pushed
the
fix_stream_memory_counting
branch
from
fe1f4ef to
ea10bed
Compare
adiholden
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4321
problem: we didn't calculate stream memory usage during snapshot loading