Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create SlotSets on the stack #4358

Open
chakaz opened this issue Dec 23, 2024 · 1 comment
Open

Do not create SlotSets on the stack #4358

chakaz opened this issue Dec 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@chakaz
Copy link
Collaborator

chakaz commented Dec 23, 2024

Function GetRemovedSlots() creates and returns (on the stack) a SlotSet of size 16kb. This can cause stack overflows.

@chakaz chakaz added the bug Something isn't working label Dec 23, 2024
@chakaz
Copy link
Collaborator Author

chakaz commented Dec 23, 2024

We should also probably move these to be private, if possible:

  SlotSet(const TBitSet& s) {
    *slots_ = s;
  }

  SlotSet(const SlotSet& s) {
    *slots_ = *s.slots_;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant