Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve seeder(v1) to send big values #4430

Open
adiholden opened this issue Jan 8, 2025 · 1 comment
Open

Improve seeder(v1) to send big values #4430

adiholden opened this issue Jan 8, 2025 · 1 comment
Assignees

Comments

@adiholden
Copy link
Collaborator

Cluster tests use DflySeederFactory which does not send big value by default
We should change this to send few big entries in order to test big values in all cluster test

@chakaz
Copy link
Collaborator

chakaz commented Feb 5, 2025

I only briefly looked into this issue, my very initial changes are in the branch chakaz/seeder-huge
This change is not enough because we create huge commands there, which are too long for a single command and dragonfly rejects it. It's not the command itself that's too long, but the number of arguments.
We can modify the seeder to use bigger chunks with smaller arguments for the huge values. But it's yet to be proven that our tests will pass with that change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants