Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete system tests #181

Open
jtpaasch opened this issue Mar 24, 2022 · 2 comments
Open

Fix incomplete system tests #181

jtpaasch opened this issue Mar 24, 2022 · 2 comments
Assignees

Comments

@jtpaasch
Copy link
Contributor

The system test that exercises arm-bounds-check is currently failing.

The main program that gets compiled on my machine runs fine, and doesn't raise the expected error (which causes the test to fail).

On inspection, it would appear that there aren't any reference executables here:
https://github.com/draperlaboratory/VIBES/tree/main/resources/exes/arm-bounds-check

This particular resource/exe needs reference executables, like the other resources/exes, so that it runs predictably on different machines, with an appropriate Makefile to generate the relevant artifacts. You can follow, say, https://github.com/draperlaboratory/VIBES/tree/main/resources/exes/arm-simple-compiled as a template (see its Makefile and *.reference files).

The system test that exercises this resource/exe then needs to exercise main.reference rather than main:

It looks like some other resource/exes and system tests might need similar updates, e.g.:

I would actually just fix this myself, but compiling the program on my machine results in an executable that doesn't exhibit the expected error.

@jtpaasch
Copy link
Contributor Author

@bmourad01 no hurry on this, but if you add the reference binaries to the repo and push them, I can do the rest of this ticket.

@bmourad01
Copy link
Contributor

I think this has been taken care of for a while now. Can you confirm @jtpaasch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants