Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi rows& cols menu #4579

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

feat: add multi rows& cols menu #4579

wants to merge 8 commits into from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 5, 2025 •
edited by zhaolixin7
Loading

close #4637
close https://github.com/dream-num/univer-pro/issues/3850

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025 •
edited
Loading

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  d80a91f
info  For more information, see full report

@wzhudev
Copy link
Member

wzhudev commented Feb 10, 2025

If this PR is a WIP please make it a draft PR.

@lumixraku lumixraku force-pushed the feat/add-rows-menu branch 5 times, most recently from 6625f34 to 004bcf1 Compare February 13, 2025 08:43
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Feb 13, 2025
@lumixraku lumixraku marked this pull request as draft February 13, 2025 08:44
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 5.66038% with 100 lines in your changes missing coverage. Please review.

Project coverage is 32.65%. Comparing base (4af5426) to head (d80a91f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ts/src/commands/commands/insert-row-col.command.ts 5.19% 73 Missing ⚠️
...ages/sheets-ui/src/controllers/menu/insert.menu.ts 0.00% 20 Missing ⚠️
packages/ui/src/components/menu/desktop/Menu.tsx 0.00% 4 Missing ⚠️
.../src/views/components/context-menu/ContextMenu.tsx 0.00% 2 Missing ⚠️
...ui/src/services/contextmenu/contextmenu.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #4579      +/-   ##
==========================================
- Coverage   32.68%   32.65%   -0.03%     
==========================================
  Files        2603     2603              
  Lines      135484   135588     +104     
  Branches    30124    30140      +16     
==========================================
+ Hits        44277    44281       +4     
- Misses      91207    91307     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as ready for review February 13, 2025 09:44
wzhudev
wzhudev requested changes Feb 15, 2025
View reviewed changes
packages/sheets-ui/src/controllers/menu/insert.menu.ts
},
},
value$: new Observable<number>((subscriber) => {
subscriber.next(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的初始值应该跟用户当前选中的行数一致

packages/ui/src/services/contextmenu/contextmenu.service.ts
}

export const IContextMenuService = createIdentifier<IContextMenuService>('ui.contextmenu.service');

export class ContextMenuService extends Disposable implements IContextMenuService {
private _currentHandler: IContextMenuHandler | null = null;

trigger$: BehaviorSubject<number> = new BehaviorSubject<number>(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should complete this Subject when the service disposes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there better ways to trigger changes instead of a trigger$ observable?

@zhaolixin7
Copy link

右键菜单文案：丢了个“行”
image

@univer-bot
Copy link

univer-bot bot commented Feb 17, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Right-click menu copy: Lost a "route"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev requested changes

@weird94 weird94 Awaiting requested review from weird94

@VicKun4937 VicKun4937 Awaiting requested review from VicKun4937 VicKun4937 is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The column width on the menu uses the value that was set last time
3 participants
@lumixraku @wzhudev @zhaolixin7