Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation.results does not take into account working directory #7

Open
FranseFrikandel opened this issue Sep 2, 2023 · 1 comment · May be fixed by #8
Open

Simulation.results does not take into account working directory #7

FranseFrikandel opened this issue Sep 2, 2023 · 1 comment · May be fixed by #8
Assignees
Labels
bug Something isn't working
Milestone

Comments

@FranseFrikandel
Copy link

It appears that in the Simulation class (pyccx/analysis/analysis.py), the working directory that was set on object creation is not taken into account when trying to retrieve the results using the results() function. This causes a file not found error when trying to retrieve the results of an analysis when the working directory is not the same as the directory the python script was executed from.

Changing line 500 from: return ResultProcessor('input')
To: return ResultProcessor(os.path.join(self._workingDirectory, 'input'))

Appears to resolve this issue.

@drlukeparry drlukeparry self-assigned this Sep 2, 2023
@drlukeparry drlukeparry added the bug Something isn't working label Sep 2, 2023
@drlukeparry drlukeparry added this to the v0.2 milestone Sep 2, 2023
@drlukeparry
Copy link
Owner

Thank you for the suggestion. Yes, I agree with the issue and will incorporate this in the future.

I would like to also consider using input decks (.inp) with time information to ensure that the simulation runs are unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants