Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrase check consider non-translatable all bracket notation phrases to be an error #6

Open
drmuey opened this issue Oct 17, 2019 · 0 comments

Comments

@drmuey
Copy link
Owner

drmuey commented Oct 17, 2019

Update Locale::Maketext::Utils::Phrase::Norm::Consider’s check to error out when the “all bracket notation” phrase are functions that mean the translator can’t do anything.

e.g. asis, comment, num, date*, etc

if the phrase is '[asis,Whatever]' there is nothing for the translator to do so that should just be the string Whatever instead of locale➜maketext('[asis,Whatever]')

if the phrase is [numf,42] you should just locale➜num(42) as again there is nothing for the translator to do

this however does give the translator something to touch (though arguably the decoration should be done outside the phrase-hence why its just a warning to trigger thinking on it) [output,strong,Whatever]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant