diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 00000000..db3d66a0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,13 @@ +# Scrabble +Congratulations! You're submitting your assignment. + +## Comprehension Questions + +| Feature | Feedback | +|--- |--- | +| How do you feel you and your partner did in sharing responsibilities? | | +| Why do you think we chose to make the `score` method in the `Scoring` class a **class method** instead of an **instance method**? | | +| Describe an example of a test you wrote for a _nominal case_. | | +| Describe an example of a test you wrote for an _edge case_. | | +| What was your final test coverage percentage? | | +| Is there a specific piece of code you'd like feedback on? | | diff --git a/feedback.md b/feedback.md index 045ec307..c54b7daf 100644 --- a/feedback.md +++ b/feedback.md @@ -7,17 +7,21 @@ | Answered comprehension questions | | | Both Teammates contributed to the codebase | | | Regular Commits with meaningful commit messages | | -| **Wave 1** | | -| `Scoring` class | | +| **Scoring class** | | | `score` method | | -| Uses hash to store the alpha score | | +| Uses appropriate data structure to store the letter score | | +| Appropriately handles edge cases | | | Tests `score` edge cases (one-letter word, 7 letter word) | | | `highest_scoring_word` method | | -| Appropriately handling edge cases | | +| Appropriately handles edge cases | | | Tests `highest_scoring_word` edge cases (ties, no words, no array) | | -| **Wave 2** | | -| `Player` class | | -| **Baseline** | | -| Readable code with consistent indentation. | | -| **Extras** | | - +| **Player class** | | +| Uses an array to keep track of words played | | +| Uses existing code to create `highest_scoring_word` and `highest_word_score` | | +| Returns `true` or `false` from `won?` method | | +| Tests edge cases on the `play(word)` method for words that cannot be scored | | +| **TileBag class** | | +| Uses a data structure to keep the set of default tiles in the bag | | +| `draw_tiles` method uses the parameter to draw a set of random tiles | | +| `tiles_remaining` method returns a count | | +| Tests `draw_tiles` edge cases for different parameter inputs | |